unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Pal Gloss <pcfeb0009@gmx.com>
To: 49924@debbugs.gnu.org
Subject: bug#49924: e1ce9904aa5511468d295cac3221cb77de994331 does not fix #49924
Date: Sat, 7 Aug 2021 16:02:31 +0200	[thread overview]
Message-ID: <trinity-1ee75b2b-7125-4dba-946f-05d2247b1b6a-1628344950856@3c-app-mailcom-bs13> (raw)
In-Reply-To: <trinity-5a3e6464-37d4-40a4-8366-8710afb3c55e-1628325937339@3c-app-mailcom-bs08>


Hi,
 
Thank you for the quick response.  Unfortunately, the proposed fix is not sufficient: the issue is not that `file' in `package-quickstart-refresh' is a long list (it's 1 string).  I think that the problem is `pp' that calls `prin1' (through `pp-to-string') and `prin1' is controlled by `print-length' and `print-level', too.
 
> Thanks for analysing and identifying these two problems.  Perhaps we
> should have a version of prin1-to-string that really did prin1 the
> entire expression, because this problem comes up again and again...

I don't know if `pp' is supposed to print "readably" (which I understand
as can be `read' again, resulting in `equalp' object).  If it is, changing
`pp-to-string' to bind the `print-*' variables would at least solve #49924.

If changing `pp-to-string' (no idea who else uses it) is too risky can
`print-length' and `print-level' be rebound in the top `let' of
`package-quickstart-refresh'.  Otherwise, rebind them locally around the
two calls to `pp'.

Kind regards.





  parent reply	other threads:[~2021-08-07 14:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-07  8:45 bug#49924: 28.0.50; `package-quickstart-refresh' fails for "long" (according to `print-length') `package-alist' Pal Gloss
2021-08-07 11:03 ` Lars Ingebrigtsen
2021-08-07 14:02 ` Pal Gloss [this message]
2021-08-09 12:47   ` bug#49924: e1ce9904aa5511468d295cac3221cb77de994331 does not fix #49924 Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=trinity-1ee75b2b-7125-4dba-946f-05d2247b1b6a-1628344950856@3c-app-mailcom-bs13 \
    --to=pcfeb0009@gmx.com \
    --cc=49924@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).