From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Welsh Duggan Newsgroups: gmane.emacs.bugs Subject: bug#11464: 24.1.50; pos-visible-in-window-p returns a false positive with bidi text Date: Thu, 17 May 2012 17:22:36 -0400 Message-ID: References: <87y5owjcto.fsf@gmail.com> <83pqa8vsxw.fsf@gnu.org> <87fwb1dagj.fsf_-_@gmail.com> <83wr4do1qv.fsf@gnu.org> <87bolor98t.fsf@gmail.com> <83sjf0nolt.fsf@gnu.org> <87pqa3csuc.fsf@gmail.com> <83likqojxl.fsf@gnu.org> <83fwayo6mz.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1337289833 12533 80.91.229.3 (17 May 2012 21:23:53 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 17 May 2012 21:23:53 +0000 (UTC) Cc: ari.roponen@gmail.com, 11464@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 17 23:23:51 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SV8Ap-00022f-Ex for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 May 2012 23:23:51 +0200 Original-Received: from localhost ([::1]:47193 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SV8Ao-0007gj-NV for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 May 2012 17:23:50 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:58979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SV8Al-0007ge-IH for bug-gnu-emacs@gnu.org; Thu, 17 May 2012 17:23:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SV8Aj-0000bJ-Mq for bug-gnu-emacs@gnu.org; Thu, 17 May 2012 17:23:47 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50168) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SV8Aj-0000bB-Gl for bug-gnu-emacs@gnu.org; Thu, 17 May 2012 17:23:45 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SV8B0-0001ZD-2n for bug-gnu-emacs@gnu.org; Thu, 17 May 2012 17:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Welsh Duggan Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 May 2012 21:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11464 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11464-submit@debbugs.gnu.org id=B11464.13372897905943 (code B ref 11464); Thu, 17 May 2012 21:24:02 +0000 Original-Received: (at 11464) by debbugs.gnu.org; 17 May 2012 21:23:10 +0000 Original-Received: from localhost ([127.0.0.1]:59714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SV8A9-0001Xo-Ug for submit@debbugs.gnu.org; Thu, 17 May 2012 17:23:10 -0400 Original-Received: from upton.red.cert.org ([192.88.209.60]:49710) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SV8A7-0001XN-Dr for 11464@debbugs.gnu.org; Thu, 17 May 2012 17:23:08 -0400 Original-Received: from bucknell.indigo.cert.org (bucknell.indigo.cert.org [10.60.10.121]) by upton.red.cert.org (8.14.4/8.14.4) with ESMTP id q4HLMfro031755; Thu, 17 May 2012 17:22:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cert.org; s=jthatj15xw2j; t=1337289762; bh=N/kVAV30VRsLGDrY1KgificR5QvHXDwtDAvwGvWZ6Yc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type:Sender:Reply-To; b=CCXWT2xaevB9lCyQNArjLNH/dQmB8brUm+Vai0np1UcI1wKvL3c7c1wE5KnOg2kWx bXJyr0wknfxDMNi66y1yjaWfopO1xKptN4jRDaJEU9k8aD6Wsqjrryyv/341isCLsR PJboe//i2aqsWWRGNs4xOtfv6wtbThL1nHtzNW10= Original-Received: from waterbuck.yellow.cert.org (waterbuck.yellow.cert.org [10.20.128.84]) by bucknell.indigo.cert.org (8.14.4/8.14.4/2.81) with ESMTP id q4HLMfh3003027; Thu, 17 May 2012 17:22:41 -0400 Original-Received: (from mwd@localhost) by waterbuck.yellow.cert.org (8.14.4/8.14.4/Submit/1.6) id q4HLMaEf010501; Thu, 17 May 2012 17:22:36 -0400 X-Authentication-Warning: waterbuck.yellow.cert.org: mwd set sender to mwd@cert.org using -f In-Reply-To: <83fwayo6mz.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 18 May 2012 00:11:00 +0300") User-Agent: Gnus/5.11002 (No Gnus v0.20) Emacs/24.1.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60152 Archived-At: Eli Zaretskii writes: >> From: Michael Welsh Duggan >> Cc: Ari Roponen , 11464@debbugs.gnu.org >> Date: Thu, 17 May 2012 13:56:45 -0400 >> >> else if (top_y < it.last_visible_y) ==> if (255 < 256) ==> if (TRUE) >> >> hence, visible_p _would_ be set to 1 by the else if clause. > > And will never be reset to zero, because 27 <= 256 => FALSE. And yet > Ari said that he needed to change the condition to <=. But where do you get 27? The number was 270, I believe. >> bottom_y = 270 >> it.last_visible_y = 256 >> top_y = 255 >> window_top_y = 0 -- Michael Welsh Duggan (mwd@cert.org)