bug#18156: Thread sorting before loose threads are gathered

bug#18156: Thread sorting before loose threads are gathered

[Michael Welsh Duggan]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Michael Welsh Duggan <mwd@md5i.com> writes:
>
>> Thread sorting happens before loose threads are gathered.  See the
>> definition of `gnus-summary-prepare'.  Threads are made, then cut, then
>> sorted, and then gathered.  I believe they should be made, cut,
>> gathered, and then sorted.  A consequence of the current order is that
>> using `gnus-thread-sort-by-most-recent-{number,date}' in the
>> `gnus-thread-sort-functions' will not pay attention to all messages in a
>> gathered thread.
>
> No, but you have `gnus-sort-gathered-threads-function' to sort inside
> the gathered threads, so I think the current algorithm is correct...

Correct or incorrect, it doesn't allow me to do what I want to do.  Here
is my use case:  I want to sort the threads in my summary buffer,
post-gathering, by the date of the most recent article in the thread.
If threads (not the articles in threads) are sorted before they are
gathered, this seems less than possible.

-- 
Michael Welsh Duggan
(mwd@cert.org)

bug#18156: Thread sorting before loose threads are gathered

[Lars Ingebrigtsen]

Michael Welsh Duggan <mwd@cert.org> writes:

> Correct or incorrect, it doesn't allow me to do what I want to do.  Here
> is my use case:  I want to sort the threads in my summary buffer,
> post-gathering, by the date of the most recent article in the thread.
> If threads (not the articles in threads) are sorted before they are
> gathered, this seems less than possible.

Hm...  I see...

Well, your sorting function could emulate the gathering and then do the
sorting based on that emulation.  The sorting functions should have
access to everything necessary to do so.

The reason I'm less than enthusiastic about changing the order of things
here is that this is really, really old code, and lots people have written
their own sorting functions based on the way it works.  Changing the
order will lead to breakages.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no