unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Kenichi Handa <handa@m17n.org>
To: Yair F <yair.f.lists@gmail.com>
Cc: 6621@debbugs.gnu.org
Subject: bug#6621: Emacs crash when trying to report emacs crash
Date: Fri, 23 Jul 2010 21:38:30 +0900	[thread overview]
Message-ID: <tl763061igp.fsf@m17n.org> (raw)
In-Reply-To: <AANLkTikE5X6BUROA31sXDe7FyIXqy_ZRm-J7iiZb_l4I@mail.gmail.com> (message from Yair F on Thu, 22 Jul 2010 22:55:24 +0300)

In article <AANLkTikE5X6BUROA31sXDe7FyIXqy_ZRm-J7iiZb_l4I@mail.gmail.com>, Yair F <yair.f.lists@gmail.com> writes:

> Since Handa-san is appearnly unavailable I tried to investigate the
> crash myself.
> The problem that I know nothing about emacs' structure.
> All I can do is send the debug session. If you  think that you can
> instruct me more on how to debug it let me know.
> I'll try to get something more meaningful.

Thank you, and sorry for the late response.  I've been busy
for preparing for the next Monday's presentation.

I found a suspicious code in Ffont_shape_gstring, and the
attached patch will fix the bug.  Could you please try it?
I have not yet committed it because I have not yet fully
traced the impact of the change to the other places..

=== modified file 'src/font.c'
--- src/font.c	2010-07-14 03:40:47 +0000
+++ src/font.c	2010-07-23 12:31:43 +0000
@@ -4492,6 +4492,8 @@
     }
   if (i == 3 || XINT (n) == 0)
     return Qnil;
+  if (XINT (n) < LGSTRING_GLYPH_LEN (gstring))
+    LGSTRING_SET_GLYPH (gstring, XINT (n), Qnil);
 
   glyph = LGSTRING_GLYPH (gstring, 0);
   from = LGLYPH_FROM (glyph);

---
Kenichi Handa
handa@m17n.org





  reply	other threads:[~2010-07-23 12:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-12 21:55 bug#6621: Emacs crash when trying to report emacs crash Yair F
2010-07-13 12:17 ` Eli Zaretskii
2010-07-13 16:15   ` Yair F
2010-07-13 17:57     ` Eli Zaretskii
2010-07-13 18:29       ` Yair F
2010-07-14  8:32         ` Eli Zaretskii
2010-07-14 11:10           ` Eli Zaretskii
2010-07-14 17:54           ` Yair F
2010-07-14 20:42             ` Eli Zaretskii
2010-07-16  6:00               ` Kenichi Handa
2010-07-22 19:55                 ` Yair F
2010-07-23 12:38                   ` Kenichi Handa [this message]
2010-07-24 22:05                     ` Yair F
2010-07-26  4:30                       ` Kenichi Handa
2010-07-26 10:12                         ` Juanma Barranquero

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tl763061igp.fsf@m17n.org \
    --to=handa@m17n.org \
    --cc=6621@debbugs.gnu.org \
    --cc=yair.f.lists@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).