unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: tsugutomo.enami@jp.sony.com
To: <18728@debbugs.gnu.org>
Subject: bug#18728: 24.0.50; gnus hangs while reading mail from imap server
Date: Fri, 24 Oct 2014 13:24:18 +0900	[thread overview]
Message-ID: <tkrzjcmf631.fsf@sigxcpu.sm.sony.co.jp> (raw)
In-Reply-To: <m238aokv3u.fsf@lifelogs.com> (Ted Zlatanov's message of "Thu, 16 Oct 2014 09:22:13 -0400")

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

Ted Zlatanov <tzz@lifelogs.com> writes:

> Could you prepare a patch against Emacs trunk or (preferably) Gnus
> master[1], incorporating Andreas' suggestion and with a ChangeLog entry?
> I'll apply it to Gnus master and it will make its way to Emacs trunk
> shortly thereafter.

Ok, patch against today's gnus.git is attached.  I've tested by changing
nnimap-keepalive and nnimap-keepalive-timer to send noop command more
frequently.

enami.

[-- Attachment #2: nnimap-wait-for-response fix to ignore NOOP response. --]
[-- Type: text/plain, Size: 851 bytes --]

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 43c5bfc..2156301 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
+2014-10-24  enami tsugutomo  <tsugutomo.enami@jp.sony.com>
+
+	* nnimap.el (nnimap-wait-for-response): Ignore NOOP response requested
+	to keep connection open.
+
 2014-10-20  Glenn Morris  <rgm@gnu.org>
 
 	* Merge in all changes up to 24.4 release.
diff --git a/lisp/nnimap.el b/lisp/nnimap.el
index ad48d47..7992151 100644
--- a/lisp/nnimap.el
+++ b/lisp/nnimap.el
@@ -1888,7 +1888,7 @@ Return the server's response to the SELECT or EXAMINE command."
 			(while (and (not (bobp))
 				    (progn
 				      (forward-line -1)
-				      (looking-at "\\*"))))
+				      (looking-at "\\*\\|[0-9]+ OK NOOP"))))
 			(not (looking-at (format "%d .*\n" sequence)))))
 	    (when messagep
 	      (nnheader-message-maybe

  reply	other threads:[~2014-10-24  4:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-14 22:56 bug#18728: 24.0.50; gnus hangs while reading mail from imap server tsugutomo.enami
2014-10-15  7:59 ` Andreas Schwab
2014-10-16 13:22 ` Ted Zlatanov
2014-10-24  4:24   ` tsugutomo.enami [this message]
2014-10-24  6:06     ` Katsumi Yamaoka
2014-10-24 13:43       ` Ted Zlatanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tkrzjcmf631.fsf@sigxcpu.sm.sony.co.jp \
    --to=tsugutomo.enami@jp.sony.com \
    --cc=18728@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).