bug#12902: 24.3.50; emacs trunk fails to unexec on NetBSD/amd64

bug#12902: 24.3.50; emacs trunk fails to unexec on NetBSD/amd64

[enami tsugutomo]

[-- Attachment #1: Type: text/plain, Size: 2170 bytes --]

Hi, all.

Emacs trunk as of today fails to build on NetBSD/amd64.  Please see the
failure.log attached below.

The failure reason was ELFSIZE macro in src/unexelf.c is defined to 32
while NetBSD/amd64 is 64bit architecture.  On emacs 24.2, the ELFSIZE is
once defined to 32 but redefined to 64 several line later so the build
succeeded.  On trunk, #ifndef ELFSIZE is added so it never override
ELFSIZE.

The trunk build succeeds if `defined _LP64' is added.  See the attached
unexelf.c.dif for detail.

Thanks.

enami.


In GNU Emacs 24.3.50.2 (x86_64--netbsd)
 of 2012-11-16 on rplaca.sm.sony.co.jp
Bzr revision: 110904 dmantipov@yandex.ru-20121115052505-55q3brwje5ykngug
Configured using:
 `configure 'x86_64--netbsd' '--with-x=no' 'build_alias=x86_64--netbsd'
 'host_alias=x86_64--netbsd' 'target_alias=x86_64--netbsd''

Important settings:
  locale-coding-system: nil
  default enable-multibyte-characters: t

Major mode: Fundamental

Minor modes in effect:
  file-name-shadow-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t

Recent input:
ESC x r e p o TAB r TAB RET

Recent messages:
("emacs")
For information about GNU Emacs and the GNU system, type C-h C-a.
Making completion list...

Load-path shadows:
None found.

Features:
(shadow sort gnus-util time-date mail-extr emacsbug message format-spec
rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail regexp-opt rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils help-mode easymenu japan-util
ediff-hook vc-hooks lisp-float-type tabulated-list newcomment lisp-mode
register page menu-bar rfn-eshadow timer jit-lock font-lock syntax
facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak
czech european ethiopic indian cyrillic chinese case-table epa-hook
jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces
cus-face macroexp files text-properties overlay sha1 md5 base64 format
env code-pages mule custom widget hashtable-print-readable backquote
make-network-process multi-tty emacs)


[-- Attachment #2: build failure log on NetBSD/amd64 --]
[-- Type: text/plain, Size: 4289 bytes --]

[ -r "/home/enami/src/emacs/src/config.in" ] || ( cd /home/enami/src/emacs && autoheader )
cd lib && make all                            CC='gcc -std=gnu99' CFLAGS='-g3 -O2' CPPFLAGS=''  LDFLAGS='-Wl,-znocombreloc' MAKE='make'
make  all-am
cd lib-src && make all                            CC='gcc -std=gnu99' CFLAGS='-g3 -O2' CPPFLAGS=''  LDFLAGS='-Wl,-znocombreloc' MAKE='make'
boot=bootstrap-emacs;                          if [ ! -x "src/$boot" ]; then                                      cd src; make all                                      CC='gcc -std=gnu99' CFLAGS='-g3 -O2' CPPFLAGS=''          LDFLAGS='-Wl,-znocombreloc' MAKE='make' BOOTSTRAPEMACS="$boot";  fi;
if [ -r .bzr/checkout/dirstate ]; then 			 vcswitness="`pwd`/.bzr/checkout/dirstate"; 	 fi; 							 cd src; make all                              CC='gcc -std=gnu99' CFLAGS='-g3 -O2' CPPFLAGS=''  LDFLAGS='-Wl,-znocombreloc' MAKE='make' BOOTSTRAPEMACS=""	 VCSWITNESS="$vcswitness"
cd ../lisp; make   update-subdirs
cd /home/enami/src/emacs/lisp; subdirs=`find . -type d -print`;  for file in $subdirs; do  case $file in */.* | */.*/* | */=* | */cedet* ) ;;  *) wins="$wins $file" ;;  esac;  done;  for file in $wins; do  /home/enami/src/emacs/build-aux/update-subdirs $file;  done;
if test "no" = "yes"; then  rm -f bootstrap-emacs;  ln temacs bootstrap-emacs;  else  `/bin/pwd`/temacs --batch --load loadup bootstrap || exit 1;  test "X" = X ||  -zex emacs;  mv -f emacs bootstrap-emacs;  fi
Loading loadup.el (source)...
Using load-path (/home/enami/src/emacs/lisp /home/enami/src/emacs/lisp/emacs-lisp /home/enami/src/emacs/lisp/language /home/enami/src/emacs/lisp/international /home/enami/src/emacs/lisp/textmodes)
Loading emacs-lisp/byte-run...
Loading emacs-lisp/backquote...
Loading subr...
Loading version...
Loading widget...
Loading custom...
Loading emacs-lisp/map-ynp...
Loading international/mule...
Loading international/mule-conf...
Loading env...
Loading format...
Loading bindings...
Loading cus-start...
Loading window...
Loading files...
Loading emacs-lisp/macroexp...
Loading cus-face...
Loading faces...
Loading button...
Loading startup...
Loading /home/enami/src/emacs/lisp/loaddefs.el (source)...
Loading minibuffer...
Loading abbrev...
Loading simple...
Loading help...
Loading jka-cmpr-hook...
Loading epa-hook...
Loading international/mule-cmds...
Loading case-table...
Loading /home/enami/src/emacs/lisp/international/charprop.el (source)...
Loading international/characters...
Loading composite...
Loading language/chinese...
Loading language/cyrillic...
Loading language/indian...
Loading language/sinhala...
Loading language/english...
Loading language/ethiopic...
Loading language/european...
Loading language/czech...
Loading language/slovak...
Loading language/romanian...
Loading language/greek...
Loading language/hebrew...
Loading language/japanese...
Loading /home/enami/src/emacs/lisp/international/cp51932.el (source)...
Loading /home/enami/src/emacs/lisp/international/eucjp-ms.el (source)...
Loading language/korean...
Loading language/lao...
Loading language/tai-viet...
Loading language/thai...
Loading language/tibetan...
Loading language/vietnamese...
Loading language/misc-lang...
Loading language/utf-8-lang...
Loading language/georgian...
Loading language/khmer...
Loading language/burmese...
Loading language/cham...
Loading indent...
Loading frame...
Loading term/tty-colors...
Loading font-core...
Loading facemenu...
Loading emacs-lisp/syntax...
Loading font-lock...
Loading jit-lock...
Loading emacs-lisp/timer...
Loading isearch...
Loading rfn-eshadow...
Loading menu-bar...
Loading emacs-lisp/lisp...
Loading textmodes/page...
Loading register...
Loading textmodes/paragraphs...
Loading emacs-lisp/lisp-mode...
Loading textmodes/text-mode...
Loading textmodes/fill...
Loading newcomment...
Loading replace...
Loading emacs-lisp/tabulated-list...
Loading buff-menu...
Loading emacs-lisp/float-sup...
Loading vc/vc-hooks...
Loading vc/ediff-hook...
Finding pointers to doc strings...
Finding pointers to doc strings...done
Dumping under the name emacs
emacs: Couldn't find segment next to .bss in /home/enami/src/emacs/src/temacs
*** Error code 1

Stop.
make: stopped in /home/enami/src/emacs/src
*** Error code 1

Stop.
make: stopped in /home/enami/src/emacs

[-- Attachment #3: last few line of success log after unexelf.c is patched. --]
[-- Type: text/plain, Size: 526 bytes --]

Finding pointers to doc strings...
Finding pointers to doc strings...done
Pure-hashed: 20134 strings, 2785 vectors, 32376 conses, 2530 bytecodes, 78 others
Dumping under the name emacs
2253956 pure bytes used
Adding name emacs-24.3.50.2
cd lisp && make all                            CC='gcc -std=gnu99' CFLAGS='-g3 -O2' CPPFLAGS=''  LDFLAGS='-Wl,-znocombreloc' MAKE='make'
cd leim && make all                            CC='gcc -std=gnu99' CFLAGS='-g3 -O2' CPPFLAGS=''  LDFLAGS='-Wl,-znocombreloc' MAKE='make'
enami@rplaca% 

[-- Attachment #4: unexelf.c patch to build on NetBSD/amd64 --]
[-- Type: text/plain, Size: 380 bytes --]

=== modified file 'src/unexelf.c'
--- src/unexelf.c	2012-10-20 21:30:51 +0000
+++ src/unexelf.c	2012-11-16 03:28:04 +0000
@@ -461,7 +461,7 @@
 /*
  * NetBSD does not have normal-looking user-land ELF support.
  */
-# if defined __alpha__ || defined __sparc_v9__
+# if defined __alpha__ || defined __sparc_v9__ || defined _LP64
 #  define ELFSIZE	64
 # else
 #  define ELFSIZE	32

bug#12902: 24.3.50; emacs trunk fails to unexec on NetBSD/amd64

[Glenn Morris]

enami tsugutomo wrote:

> --- src/unexelf.c	2012-10-20 21:30:51 +0000
> +++ src/unexelf.c	2012-11-16 03:28:04 +0000
> @@ -461,7 +461,7 @@
>  /*
>   * NetBSD does not have normal-looking user-land ELF support.
>   */
> -# if defined __alpha__ || defined __sparc_v9__
> +# if defined __alpha__ || defined __sparc_v9__ || defined _LP64
>  #  define ELFSIZE	64
>  # else
>  #  define ELFSIZE	32

Thanks; applied to emacs-24 branch.