* bug#61366: [PATCH] ; Add usage, will not continue if no parameters are provided.
@ 2023-02-08 10:00 Xi Lu
2023-02-18 15:27 ` lux
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Xi Lu @ 2023-02-08 10:00 UTC (permalink / raw)
To: 61366; +Cc: Xi Lu
---
admin/notes/tree-sitter/build-module/build.sh | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/admin/notes/tree-sitter/build-module/build.sh b/admin/notes/tree-sitter/build-module/build.sh
index 9dc674237ca..08a71c1dde1 100755
--- a/admin/notes/tree-sitter/build-module/build.sh
+++ b/admin/notes/tree-sitter/build-module/build.sh
@@ -3,6 +3,12 @@
lang=$1
topdir="$PWD"
+if [ $# -lt 1 ]
+then
+ echo "Usage: $0 <language>"
+ exit
+fi
+
case $(uname) in
"Darwin")
soext="dylib"
--
2.39.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* bug#61366: [PATCH] ; Add usage, will not continue if no parameters are provided.
2023-02-08 10:00 bug#61366: [PATCH] ; Add usage, will not continue if no parameters are provided Xi Lu
@ 2023-02-18 15:27 ` lux
[not found] ` <873573yowp.fsf@shellcodes.org>
2023-03-19 7:53 ` Yuan Fu
2 siblings, 0 replies; 8+ messages in thread
From: lux @ 2023-02-18 15:27 UTC (permalink / raw)
To: 61366
Xi Lu <lx@shellcodes.org> writes:
> ---
> admin/notes/tree-sitter/build-module/build.sh | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/admin/notes/tree-sitter/build-module/build.sh b/admin/notes/tree-sitter/build-module/build.sh
> index 9dc674237ca..08a71c1dde1 100755
> --- a/admin/notes/tree-sitter/build-module/build.sh
> +++ b/admin/notes/tree-sitter/build-module/build.sh
> @@ -3,6 +3,12 @@
> lang=$1
> topdir="$PWD"
>
> +if [ $# -lt 1 ]
> +then
> + echo "Usage: $0 <language>"
> + exit
> +fi
> +
> case $(uname) in
> "Darwin")
> soext="dylib"
This patch need to review. If not give the `language' paramter, some
errors will be printed.
IMHO, Can the batch.sh and build.sh merge to one shell file?
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#61366: [PATCH] ; Add usage, will not continue if no parameters are provided.
[not found] ` <873573yowp.fsf@shellcodes.org>
@ 2023-03-19 3:57 ` lux
2023-03-19 6:05 ` Eli Zaretskii
0 siblings, 1 reply; 8+ messages in thread
From: lux @ 2023-03-19 3:57 UTC (permalink / raw)
To: 61366; +Cc: casouri
On Sat, 2023-02-18 at 23:27 +0800, lux wrote:
> Xi Lu <lx@shellcodes.org> writes:
>
> > ---
> > admin/notes/tree-sitter/build-module/build.sh | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/admin/notes/tree-sitter/build-module/build.sh
> > b/admin/notes/tree-sitter/build-module/build.sh
> > index 9dc674237ca..08a71c1dde1 100755
> > --- a/admin/notes/tree-sitter/build-module/build.sh
> > +++ b/admin/notes/tree-sitter/build-module/build.sh
> > @@ -3,6 +3,12 @@
> > lang=$1
> > topdir="$PWD"
> >
> > +if [ $# -lt 1 ]
> > +then
> > + echo "Usage: $0 <language>"
> > + exit
> > +fi
> > +
> > case $(uname) in
> > "Darwin")
> > soext="dylib"
>
> This patch need to review. If not give the `language' paramter, some
> errors will be printed.
>
> IMHO, Can the batch.sh and build.sh merge to one shell file?
Hi, Yuan Fu, Can you help to look this issue?
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#61366: [PATCH] ; Add usage, will not continue if no parameters are provided.
2023-03-19 3:57 ` lux
@ 2023-03-19 6:05 ` Eli Zaretskii
2023-03-19 6:13 ` Eli Zaretskii
0 siblings, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2023-03-19 6:05 UTC (permalink / raw)
To: lux; +Cc: 61366, casouri
> Cc: casouri@gmail.com
> From: lux <lx@shellcodes.org>
> Date: Sun, 19 Mar 2023 11:57:06 +0800
>
> On Sat, 2023-02-18 at 23:27 +0800, lux wrote:
> > Xi Lu <lx@shellcodes.org> writes:
> >
> > > ---
> > > admin/notes/tree-sitter/build-module/build.sh | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> > > diff --git a/admin/notes/tree-sitter/build-module/build.sh
> > > b/admin/notes/tree-sitter/build-module/build.sh
> > > index 9dc674237ca..08a71c1dde1 100755
> > > --- a/admin/notes/tree-sitter/build-module/build.sh
> > > +++ b/admin/notes/tree-sitter/build-module/build.sh
> > > @@ -3,6 +3,12 @@
> > > lang=$1
> > > topdir="$PWD"
> > >
> > > +if [ $# -lt 1 ]
> > > +then
> > > + echo "Usage: $0 <language>"
> > > + exit
> > > +fi
> > > +
> > > case $(uname) in
> > > "Darwin")
> > > soext="dylib"
> >
> > This patch need to review. If not give the `language' paramter, some
> > errors will be printed.
> >
> > IMHO, Can the batch.sh and build.sh merge to one shell file?
>
> Hi, Yuan Fu, Can you help to look this issue?
I don't see a point, as I'm going to delete these scripts very soon.
They did their job and are no longer needed in our repository.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#61366: [PATCH] ; Add usage, will not continue if no parameters are provided.
2023-03-19 6:05 ` Eli Zaretskii
@ 2023-03-19 6:13 ` Eli Zaretskii
2023-03-19 7:11 ` lux
2023-09-01 19:51 ` Stefan Kangas
0 siblings, 2 replies; 8+ messages in thread
From: Eli Zaretskii @ 2023-03-19 6:13 UTC (permalink / raw)
To: lx; +Cc: 61366, casouri
> Cc: 61366@debbugs.gnu.org, casouri@gmail.com
> Date: Sun, 19 Mar 2023 08:05:46 +0200
> From: Eli Zaretskii <eliz@gnu.org>
>
> > Hi, Yuan Fu, Can you help to look this issue?
>
> I don't see a point, as I'm going to delete these scripts very soon.
Now done.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#61366: [PATCH] ; Add usage, will not continue if no parameters are provided.
2023-03-19 6:13 ` Eli Zaretskii
@ 2023-03-19 7:11 ` lux
2023-09-01 19:51 ` Stefan Kangas
1 sibling, 0 replies; 8+ messages in thread
From: lux @ 2023-03-19 7:11 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 61366, casouri
On Sun, 2023-03-19 at 08:13 +0200, Eli Zaretskii wrote:
> > Cc: 61366@debbugs.gnu.org, casouri@gmail.com
> > Date: Sun, 19 Mar 2023 08:05:46 +0200
> > From: Eli Zaretskii <eliz@gnu.org>
> >
> > > Hi, Yuan Fu, Can you help to look this issue?
> >
> > I don't see a point, as I'm going to delete these scripts very
> > soon.
>
> Now done.
>
>
>
Ok, thank you.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#61366: [PATCH] ; Add usage, will not continue if no parameters are provided.
2023-02-08 10:00 bug#61366: [PATCH] ; Add usage, will not continue if no parameters are provided Xi Lu
2023-02-18 15:27 ` lux
[not found] ` <873573yowp.fsf@shellcodes.org>
@ 2023-03-19 7:53 ` Yuan Fu
2 siblings, 0 replies; 8+ messages in thread
From: Yuan Fu @ 2023-03-19 7:53 UTC (permalink / raw)
To: lux; +Cc: 61366, eliz
lux <lx@shellcodes.org> writes:
> On Sun, 2023-03-19 at 08:13 +0200, Eli Zaretskii wrote:
>> > Cc: 61366@debbugs.gnu.org, casouri@gmail.com
>> > Date: Sun, 19 Mar 2023 08:05:46 +0200
>> > From: Eli Zaretskii <eliz@gnu.org>
>> >
>> > > Hi, Yuan Fu, Can you help to look this issue?
>> >
>> > I don't see a point, as I'm going to delete these scripts very
>> > soon.
>>
>> Now done.
>>
>>
>>
>
> Ok, thank you.
Sorry, I didn’t see this until now. If you have suggestions for the
build script, you can report those at
https://github.com/casouri/tree-sitter-module
Yuan
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#61366: [PATCH] ; Add usage, will not continue if no parameters are provided.
2023-03-19 6:13 ` Eli Zaretskii
2023-03-19 7:11 ` lux
@ 2023-09-01 19:51 ` Stefan Kangas
1 sibling, 0 replies; 8+ messages in thread
From: Stefan Kangas @ 2023-09-01 19:51 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: lx, casouri, 61366-done
Eli Zaretskii <eliz@gnu.org> writes:
> > Cc: 61366@debbugs.gnu.org, casouri@gmail.com
> > Date: Sun, 19 Mar 2023 08:05:46 +0200
> > From: Eli Zaretskii <eliz@gnu.org>
> >
> > > Hi, Yuan Fu, Can you help to look this issue?
> >
> > I don't see a point, as I'm going to delete these scripts very soon.
>
> Now done.
This bug was left open by accident, so I'm closing it now.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-09-01 19:51 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-08 10:00 bug#61366: [PATCH] ; Add usage, will not continue if no parameters are provided Xi Lu
2023-02-18 15:27 ` lux
[not found] ` <873573yowp.fsf@shellcodes.org>
2023-03-19 3:57 ` lux
2023-03-19 6:05 ` Eli Zaretskii
2023-03-19 6:13 ` Eli Zaretskii
2023-03-19 7:11 ` lux
2023-09-01 19:51 ` Stefan Kangas
2023-03-19 7:53 ` Yuan Fu
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).