unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: lux <lx@shellcodes.org>
To: 61366@debbugs.gnu.org
Subject: bug#61366: [PATCH] ; Add usage, will not continue if no parameters are provided.
Date: Sat, 18 Feb 2023 23:27:34 +0800	[thread overview]
Message-ID: <tencent_ACB9E6B426FECE499E2FBC30F88DB3634605@qq.com> (raw)
In-Reply-To: <tencent_C2C8E471C2A582CF387766A66A786B7EEF09@qq.com> (Xi Lu's message of "Wed, 8 Feb 2023 18:00:49 +0800")

Xi Lu <lx@shellcodes.org> writes:

> ---
>  admin/notes/tree-sitter/build-module/build.sh | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/admin/notes/tree-sitter/build-module/build.sh b/admin/notes/tree-sitter/build-module/build.sh
> index 9dc674237ca..08a71c1dde1 100755
> --- a/admin/notes/tree-sitter/build-module/build.sh
> +++ b/admin/notes/tree-sitter/build-module/build.sh
> @@ -3,6 +3,12 @@
>  lang=$1
>  topdir="$PWD"
>  
> +if [ $# -lt 1 ]
> +then
> +    echo "Usage: $0 <language>"
> +    exit
> +fi
> +
>  case $(uname) in
>      "Darwin")
>          soext="dylib"

This patch need to review. If not give the `language' paramter, some
errors will be printed.

IMHO, Can the batch.sh and build.sh merge to one shell file?





  reply	other threads:[~2023-02-18 15:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-08 10:00 bug#61366: [PATCH] ; Add usage, will not continue if no parameters are provided Xi Lu
2023-02-18 15:27 ` lux [this message]
     [not found] ` <873573yowp.fsf@shellcodes.org>
2023-03-19  3:57   ` lux
2023-03-19  6:05     ` Eli Zaretskii
2023-03-19  6:13       ` Eli Zaretskii
2023-03-19  7:11         ` lux
2023-09-01 19:51         ` Stefan Kangas
2023-03-19  7:53 ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_ACB9E6B426FECE499E2FBC30F88DB3634605@qq.com \
    --to=lx@shellcodes.org \
    --cc=61366@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).