unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: LdBeth <andpuke@foxmail.com>
To: nathan@degruchy.org
Cc: 66395@debbugs.gnu.org
Subject: bug#66395: 28.2; Todo-mode locks up when trying to edit an entry
Date: Sat, 07 Oct 2023 14:37:00 -0500	[thread overview]
Message-ID: <tencent_ABFE14DCC2BB991CBB7AB630AA74E0AD2009@qq.com> (raw)
In-Reply-To: 871qe6ntf4.fsf@ndegruchy-wlt

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]


As we have discussed on IRC, the nonstandard timestamp format is the cause.
The hang is cause by the while loop `todo-item-start' not properly handle fail
case, however.

This patch would at least fix the hang.

---
LdBeth


[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 464 bytes --]

--- todo-mode.el.old	2023-10-07 14:28:59.000000000 -0500
+++ todo-mode.el	2023-10-07 14:30:20.000000000 -0500
@@ -5242,8 +5242,8 @@
 	   ;; Buffer is widened.
 	   (looking-at (regexp-quote todo-category-beg)))
     (goto-char (line-beginning-position))
-    (while (not (looking-at todo-item-start))
-      (forward-line -1))
+    (while (and (not (looking-at todo-item-start))
+                (= (forward-line -1) 0)))
     (point)))
 
 (defun todo-item-end ()

  parent reply	other threads:[~2023-10-07 19:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-07 19:06 bug#66395: 28.2; Todo-mode locks up when trying to edit an entry Nathan R. DeGruchy
2023-10-07 19:25 ` Eli Zaretskii
2023-10-07 19:37 ` LdBeth [this message]
2023-10-07 21:27 ` Stephen Berman
2023-10-07 23:20   ` Nathan R. DeGruchy
2023-11-05 22:00   ` Stephen Berman
2023-11-12 14:10     ` bug#55284: " Stephen Berman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_ABFE14DCC2BB991CBB7AB630AA74E0AD2009@qq.com \
    --to=andpuke@foxmail.com \
    --cc=66395@debbugs.gnu.org \
    --cc=nathan@degruchy.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).