* bug#32021: hexl-follow-ascii-mode is not initialized
@ 2018-06-30 17:07 Shuguang
2018-06-30 18:00 ` Eli Zaretskii
0 siblings, 1 reply; 2+ messages in thread
From: Shuguang @ 2018-06-30 17:07 UTC (permalink / raw)
To: 32021
[-- Attachment #1: Type: text/plain, Size: 940 bytes --]
Hi,
Windows 7
Emacs git master/2018.6.24 at least
When I try to toggle hexl-mode, it reports
"defvar: Symbol's value as variable is void: hexl-follow-ascii-mode".
It looks like the definiation of hexl-follow-ascii-mode is incorect.
From the doc of define-minor-mode, it requires INIT-VALUE LIGHTER KEYMAP or at least one keyword argument.
According to the DOC of hexl-follow-ascii-mode, I think the following patch should be proper.
diff --git a/lisp/hexl.el b/lisp/hexl.el
index f37be9d410..6b316dd707 100644
--- a/lisp/hexl.el
+++ b/lisp/hexl.el
@@ -1000,6 +1000,7 @@ hexl-follow-ascii-mode
When following is enabled, the ASCII character corresponding to the
element under the point is highlighted.
The default activation is controlled by `hexl-follow-ascii'."
+ :init-value hexl-follow-ascii
(if hexl-follow-ascii-mode
;; turn it on
(progn
Best Regards,
Shuguang Sun
[-- Attachment #2: Type: text/html, Size: 1242 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#32021: hexl-follow-ascii-mode is not initialized
2018-06-30 17:07 bug#32021: hexl-follow-ascii-mode is not initialized Shuguang
@ 2018-06-30 18:00 ` Eli Zaretskii
0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2018-06-30 18:00 UTC (permalink / raw)
To: Shuguang; +Cc: 32021-done
> From: "Shuguang" <shuguang79@qq.com>
> Date: Sun, 1 Jul 2018 01:07:47 +0800
>
> Windows 7
> Emacs git master/2018.6.24 at least
>
> When I try to toggle hexl-mode, it reports
> "defvar: Symbol's value as variable is void: hexl-follow-ascii-mode".
Thanks, fixed.
> It looks like the definiation of hexl-follow-ascii-mode is incorect.
No, it was a typo in hexl-follow-ascii-mode.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-30 18:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-30 17:07 bug#32021: hexl-follow-ascii-mode is not initialized Shuguang
2018-06-30 18:00 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).