unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eason Huang <aqua0210@foxmail.com>
To: Theodor Thornhill <theo@thornhill.no>
Cc: 61631@debbugs.gnu.org
Subject: bug#61631: 29.0.60; The indentation of switch case is broken on typescript-ts-mode and tsx-ts-mode
Date: Mon, 20 Feb 2023 21:06:14 +0800	[thread overview]
Message-ID: <tencent_A1250348711B92E0126B539B4A72102FC608@qq.com> (raw)
In-Reply-To: <87cz64a4x2.fsf@thornhill.no> (Theodor Thornhill's message of "Mon, 20 Feb 2023 13:37:45 +0100")

Theodor Thornhill <theo@thornhill.no> writes:

> Eason Huang <aqua0210@foxmail.com> writes:
>
>> Theodor Thornhill <theo@thornhill.no> writes:
>>
>>> On 19 February 2023 14:24:30 CET, Eason Huang <aqua0210@foxmail.com> wrote:
>>>>Hello Theodor and Emacs dev team,
>>>>
>>>>Recently I found that the indentation is broken in typescript-ts-mode
>>>>and tsx-ts-mode. When I press RET (M-x newline) after the ':' in the
>>>>case clause, it will always indent to the the same position of previouse line.
>>>>
>>>>For example:
>>>>In typescript-ts-mode and tsx-ts-mode will get this result as below:
>>>>
>>>>```
>>>>let day: number = 1;
>>>>
>>>>switch (day) {
>>>>case 0:
>>>>console.log("It is a Sunday.");
>>>>break;
>>>>case 1:
>>>>console.log("It is a Monday.");
>>>>break;
>>>>default:
>>>>console.log("No such day exists!");
>>>>break;
>>>>}
>>>>```
>>>>expected:
>>>>
>>>>```
>>>>let day: number = 1;
>>>>
>>>>switch (day) {
>>>>case 0:
>>>>  console.log("It is a Sunday.");
>>>>  break;
>>>>case 1:
>>>>  console.log("It is a Monday.");
>>>>  break;
>>>>default:
>>>>  console.log("No such day exists!");
>>>>break;
>>>>}
>>>>```
>>>>
>>>>steps to reprodue:
>>>>
>>>>1. start emacs with `emacs -Q`
>>>>2. C-x C-f ~/test.tsx to open a test.tsx
>>>>3. M-x typescript-ts-mode
>>>>4. input the exmaple code mentioned above
>>>>5. you will see the result.
>>>>
>>>>--
>>>
>>>
>>> Great, thanks! I'll fix it tonight, unless you want to devise a patch yourself?
>>>
>> Hi Theo,
>>
>> Sorry, I have no idear how to fix it.
>>
>> I tried the latest commit(fc4bfa76db9) of emacs-29 branch, but the issue is still existed.
>>
>> --
>> Eason Huang
>
> No problem, pushing it now.
>

Great, thanks!

I just build commit 19480aa30e3, and the issue has been fixed now.

-- 
Eason Huang





  reply	other threads:[~2023-02-20 13:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-19 13:24 bug#61626: 29.0.60; The indentation of switch case is broken on typescript-ts-mode and tsx-ts-mode Eason Huang
2023-02-19 16:03 ` bug#61631: " Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-20 12:26   ` Eason Huang
2023-02-20 12:37     ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-20 13:06       ` Eason Huang [this message]
2023-02-20 14:04         ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_A1250348711B92E0126B539B4A72102FC608@qq.com \
    --to=aqua0210@foxmail.com \
    --cc=61631@debbugs.gnu.org \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).