From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eason Huang Newsgroups: gmane.emacs.bugs Subject: bug#55396: 29.0.50; project-find-file don't work on a project with many submodules Date: Tue, 14 Jun 2022 19:22:15 +0800 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21441"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (darwin) Cc: 55396@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 14 13:23:31 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o14ds-0005Hr-Dj for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Jun 2022 13:23:29 +0200 Original-Received: from localhost ([::1]:51212 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o14dq-0001NW-Km for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Jun 2022 07:23:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o14dS-0001Lp-9U for bug-gnu-emacs@gnu.org; Tue, 14 Jun 2022 07:23:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39182) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o14dS-0003UG-04 for bug-gnu-emacs@gnu.org; Tue, 14 Jun 2022 07:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o14dR-0005Gt-RA for bug-gnu-emacs@gnu.org; Tue, 14 Jun 2022 07:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eason Huang Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Jun 2022 11:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55396 X-GNU-PR-Package: emacs Original-Received: via spool by 55396-submit@debbugs.gnu.org id=B55396.165520575620230 (code B ref 55396); Tue, 14 Jun 2022 11:23:01 +0000 Original-Received: (at 55396) by debbugs.gnu.org; 14 Jun 2022 11:22:36 +0000 Original-Received: from localhost ([127.0.0.1]:33079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o14d2-0005GE-2L for submit@debbugs.gnu.org; Tue, 14 Jun 2022 07:22:36 -0400 Original-Received: from out203-205-251-36.mail.qq.com ([203.205.251.36]:57386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o14ct-0005Fr-Iy for 55396@debbugs.gnu.org; Tue, 14 Jun 2022 07:22:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1655205737; bh=odCW2HhGbLI1TmyloxmQOGMuZKdbwNn9x/ExFNzpvjI=; h=From:To:Cc:Subject:References:Date:In-Reply-To; b=zGdQcVV5S1soQLXQHGurTzdDh0otHPm3Sc4ESHzqd3LgJbI6ZqOWYXPf6RcU2BpeY 29hUPz2YihdrL1NhGjFSW4eQO/16Zz3UaqooF9p3VRHFMcjsqyReHJvG82ji//LqwQ WcSeiv0xZ2GA3CAOJSpXSy+H9Al8I4Ojqbvv6uqc= Original-Received: from MacBook ([114.82.35.172]) by newxmesmtplogicsvrszb6.qq.com (NewEsmtp) with SMTP id 59006071; Tue, 14 Jun 2022 19:22:16 +0800 X-QQ-mid: xmsmtpt1655205736tnreda3q2 X-QQ-XMAILINFO: MEdp4Db0NDmH5YvCx3fXs/CLWKI3Mony6MRr6ebqP0FhilVm0pPZq9qOtg+fcY CE2p6lvs649DY/Gy/XqPqeKrHHzDRDnFFwNl9MKMHJR4RLt1pb8Vv+vwd1+NU+WA/jKeQqljuwPS HuMxC5Wj+giv1IjLWndx81jAS3Q1azTvJv4z7Zn0R2rw3M77F1SC64Y+pJ6IwMyiepqH3kR+viyH 6BRh9PsD/hz+1h4HbZwaj/P6VxYXPesuDfpsec7gnKouMMiC47YADwbdUon3kXCkwK82Nm8DgV8S /825octozXC1gl6p9LTnyvRnNHpdlZ92jGzRV0XwLi1vbEtlr1TsoTgAG14xKoQ9xwgOfhjhsGYn lgxyUMBE9H3LUW7YDypKCc77GO2z2LM6AEcLOJjTFE2Vgn87mKL8JU27rPwnHt8BwVxW0Ib49Mx9 9Wr4W7Z74Dj1kMRSlaBoxFaY7c0xQVw8GBiInrb8bNdiV0AqdjSW0bXS1ZU3crF1an3C5YaLHjIP D8W8EaUnJ/FsgjvrIFDpDJdvTTAlEazqZWDJq9fxvq73xmMgptiFhttxmknEcyaUwzkX+g8euG0I jNC/SES7iIDun26EfCFMAVs0UMZrt1rE+KddJcpwbodMKPm1Bl3OZdYeti93FUBjfhB6nfDcP6vR diA9MdRyk4JPVjMXW5wsx6zR3QJ0XcJ25FZdDHxme/Den6EOQSs/xpFaMbgMlbRr6IfDcs8s/xLq MAgiJO3HudFa74avqAv9a+PZTdwhiT0hfMboyKO2y28F6zY4Qnf/hatKoLM6ob47+2bdI6V2ndly DqzYu55aGmWfiorQWPj4aitXSx2HaVua/JdwbGLW In-Reply-To: (Dmitry Gutov's message of "Tue, 14 Jun 2022 04:03:59 +0300") Original-Message-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234472 Dmitry Gutov writes: > On 13.06.2022 18:00, Eason Huang wrote: >>> Looking at the backtrace, it mentions "/Users/eason/.emacs.d/." over >>> and over again. So it seems like (project--git-submodules) returns a >>> list which has "." as one of its elements. >>> >>> How does that happen? Do you have a submodule entry which points to "."? >>> >> I found that it's this line `load-path = .` cause the issue. Borg need >> this line to add the vertico directory to load-path when user add a >> subDirectory to load-path. May be it is an issue of Borg? > > Now that I've tried adding that locally, it indeed what triggered the > problem. It was a bug in 'project--git-submodules', which I've just > fixed on master in commit 915b34d280. > > I think file listing together with submodules should work fine now in > your case. Not sure about the performance though: we use one process > call per submodule, so the overhead might get noticeable with 42 of > them. But please give it a try. > Great, I tried on my huge .emacs.d project, it works well and fast. Tested on macOS with latest commit. You can close this bug now. Thanks for your great work on it. -- Eason Huang