unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: LdBeth <andpuke@foxmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 64272@debbugs.gnu.org, LdBeth <andpuke@foxmail.com>,
	monnier@iro.umontreal.ca
Subject: bug#64272: 28.1; lisp_file_lexically_bound_p behavior mismatches file local variables
Date: Sun, 25 Jun 2023 18:16:36 -0500	[thread overview]
Message-ID: <tencent_801CA17A56314C746AAC30FFB8DC58BB1109@qq.com> (raw)
In-Reply-To: <83h6qvxv8q.fsf@gnu.org>

>>>>> In <83h6qvxv8q.fsf@gnu.org> 
>>>>>	Eli Zaretskii <eliz@gnu.org> wrote:
ldb> If first line is lisp code, and we want to keep the similar
ldb> behavior of `hack-local-variables-prop-line`, there needs a mean
ldb> to buffer the content of the first line. (Or reset file position
ldb> but I don't think there is a way to do that without
ldb> substantially change lread.c)

Eli> There isn't.  We can only unread one character at a time.

ldb> But it would be easier to only handle the extra whitespace at
ldb> beginning of file.

Eli> So now let me turn the table and ask: if we are only going to support
Eli> whitespace before the semicolon, then what exactly are we gaining
Eli> here?

Haha, we would gain pretty much nothing useful if the issue not resolved.


So as I continue digging into lread.c and trying to find alternative
solutions, I find these:

  DEFSYM (Qget_file_char, "get-file-char");

  /* Used instead of Qget_file_char while loading *.elc files compiled
     by Emacs 21 or older.  */
  DEFSYM (Qget_emacs_mule_file_char, "get-emacs-mule-file-char");

While `get-file-char` is exposed to emacs lisp,
`get-emacs-mule-file-char' is not even a defined lisp function.

There are multiple places in `lread.c` that handles
`Qget_emacs_mule_file_char`. Which I believe it time to consider
them as dead code and remove them.

For the only two functions that calls `lisp_file_lexically_bound_p`,
`load` is hard coded to use `get-file-char` which is a wrapper around
`getc()`, and `eval-buffer` uses the `BUFFERP (readcharfun)`
branch in `readchar`. I think both case can be changed to
use a more flexible way to test file local variables
rather than stick to the READCHAR UNREAD api.

---
ldb






  parent reply	other threads:[~2023-06-25 23:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-24 18:22 bug#64272: 28.1; lisp_file_lexically_bound_p behavior mismatches file local variables LdBeth
2023-06-24 18:52 ` Eli Zaretskii
2023-06-24 19:08   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-25  2:11   ` LdBeth
2023-06-25  6:08     ` Eli Zaretskii
2023-06-25 13:37       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-25 15:02         ` Eli Zaretskii
2023-06-25 15:42           ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-25 17:17           ` LdBeth
2023-06-25 18:16             ` Eli Zaretskii
2023-06-25 23:00               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-26  0:53                 ` LdBeth
2023-06-26 11:13                   ` Eli Zaretskii
2023-06-26 15:18                     ` Gregory Heytings
2023-06-26 15:23                       ` Eli Zaretskii
2023-11-21 13:12                       ` Gerd Möllmann
2023-06-26 10:59                 ` Eli Zaretskii
2023-06-25 23:16               ` LdBeth [this message]
2023-06-26  0:45                 ` LdBeth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_801CA17A56314C746AAC30FFB8DC58BB1109@qq.com \
    --to=andpuke@foxmail.com \
    --cc=64272@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).