From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Shuguang Sun via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#54281: 29.0.50; project-try-vc not return the root Date: Mon, 07 Mar 2022 12:41:11 +0800 Message-ID: Reply-To: Shuguang Sun Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2996"; mail-complaints-to="usenet@ciao.gmane.io" To: 54281@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 07 05:43:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nR5DD-0000fX-4l for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 07 Mar 2022 05:43:11 +0100 Original-Received: from localhost ([::1]:58652 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nR5DC-0000gk-0k for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Mar 2022 23:43:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nR5D5-0000gc-6G for bug-gnu-emacs@gnu.org; Sun, 06 Mar 2022 23:43:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58222) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nR5D4-0003QK-Tn for bug-gnu-emacs@gnu.org; Sun, 06 Mar 2022 23:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nR5D4-0003MB-FC for bug-gnu-emacs@gnu.org; Sun, 06 Mar 2022 23:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Shuguang Sun Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Mar 2022 04:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 54281 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.164662817612887 (code B ref -1); Mon, 07 Mar 2022 04:43:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 Mar 2022 04:42:56 +0000 Original-Received: from localhost ([127.0.0.1]:52119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nR5Cx-0003Lm-Kr for submit@debbugs.gnu.org; Sun, 06 Mar 2022 23:42:55 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:49118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nR5Cu-0003Ld-AY for submit@debbugs.gnu.org; Sun, 06 Mar 2022 23:42:53 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nR5Cu-0000f5-3b for bug-gnu-emacs@gnu.org; Sun, 06 Mar 2022 23:42:52 -0500 Original-Received: from out203-205-221-210.mail.qq.com ([203.205.221.210]:34909) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nR5Cl-0003Ni-5z for bug-gnu-emacs@gnu.org; Sun, 06 Mar 2022 23:42:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1646628153; bh=qZgwCWHlti5Ee132XjsRCgtZh4inPz2hqcFRTxPrqsY=; h=From:To:Subject:Date; b=uyWfP6uTDoodmb/kuIWM+mTKii9nU1leq4PHE3hwaSI6HHaMor+Xg0pj5vfr6FK1W JfO/AWc8LdECiX0V6/9hf3vGwXuvaGUCcrPdshTGA9kV47lL1WGaL2+TnHdjXCaO5R kZxOpysCeHx4XiQNIp0VFjsvrxEjUKPDykJQcLCo= Original-Received: from yj190169-SSG ([116.227.165.141]) by newxmesmtplogicsvrszc9.qq.com (NewEsmtp) with SMTP id A4C98E06; Mon, 07 Mar 2022 12:41:12 +0800 X-QQ-mid: xmsmtpt1646628072tmi2ksgri X-QQ-XMAILINFO: My/elTziho8N9+8FWKanS0hLqCgbfaKaMjer/RwksHN2xAePMWLZ5YAOXrfYzq O/65KwQl+HM6ubUtNwG2mZyrprVtqf61SB1hHipXW5mSpKIVOx32b/Q4+Ai/j8C+7fGtSf/D3OPY B3FmVxNRKVQj29d80weRUk0NsGfWetIrJom7M+CD7w6E3u66zO7yOzcM+vHCxA1lP/WUQUc2dz/0 fl5MF5l5rEpB4fOuxadXgLvt4sn4E0jErWkEasq7P4sdNaYXUTfK6AVFi4tn7dTgpXvyYhgCEHE+ WNoZ0X7eFdc7uO3xSOGrcDnE5XqeaDVb37zWZ4LHkAs3dGMsi+jqY94BmbvxdWQ45RGM/DROurx9 Mi9rKbxRYO9jFCmFli8wg0g8XsuXKfB8UmBAvmbd6vo6lcNDyr/2lDE38KBmamH2BFyqRTa/nO06 tUtI3oKgJCl019yuGj1e7jTPcvAZE6xXB1JM+DKKLA1No2A30+70HyzdpNFpeOqJO82lXo0QIoPE jJjeLheke1fRyv2khtNdJ/4EAGs10EH8Sg56qYhksA9B+uk9/yHwVMPa/or1kScJuwGCr8ifn2UU jrP3oU5SQemOuyQEGkk2s2mdaxtMUxkH/ANQOzmkLzsbPPUo6OGm3u1ZJRBP8qriS4IB3CJpn57D 2Kb6UexgFbHfwCa8Dux9CDxjlgaF7Qzv66zSHOiyH/6M0ZFfUFwsoyLxayKpTV4m9cltdLYYGC+G u1cPnd3g/nX9aqS8VTTO6BaZxiISc4JyeVv62EAtOfQIS9Fj+3GJ+gKb7JXw5Fs++DWPr+0uLeIi VnSpygi5TfcxKthbwxj0koMkNrbAAT9khofLMhKu Original-Message-ID: Received-SPF: pass client-ip=203.205.221.210; envelope-from=shuguang79@qq.com; helo=out203-205-221-210.mail.qq.com X-Spam_score_int: 11 X-Spam_score: 1.1 X-Spam_bar: + X-Spam_report: (1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HELO_DYNAMIC_IPADDR=1.951, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228092 Hi all, The `project-current' and `project-try-vc' can't return the root but just a list of `(vc Git)'. It is found that an `and' should be used in the function `project-try-vc' instead of `or'. The patch below fixs it. ``` diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index daaf86f327..e8bd203979 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -418,7 +418,7 @@ project-vc-external-roots-function backend implementation of `project-external-roots'.") (defun project-try-vc (dir) - (or (vc-file-getprop dir 'project-vc) + (and (vc-file-getprop dir 'project-vc) (let* ((backend (ignore-errors (vc-responsible-backend dir))) (root (pcase backend ``` Best Regards, Shuguang Sun In GNU Emacs 29.0.50 (build 1, x86_64-w64-mingw32) of 2022-03-07 built on Repository revision: 36b31d38cd9bde7ad1ec18c136854cddba0d6bbe Repository branch: master Windowing system distributor 'Microsoft Corp.', version 10.0.19044 System Description: Microsoft Windows 10 Pro (v10.0.2009.19044.1526) Configured using: 'configure --without-pop --with-native-image-api --with-native-compilation --without-compress-install '--program-transform-name=s/^ctags$/ctags.emacs/'' Configured features: ACL DBUS GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP XPM ZLIB Important settings: value of $LANG: CHS locale-coding-system: cp936