From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Shuguang Sun via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60188: 30.0.50; zerop cpd-length are not all handled in project--read-file-cpd-relative Date: Mon, 19 Dec 2022 13:12:09 +0800 Message-ID: Reply-To: Shuguang Sun Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21563"; mail-complaints-to="usenet@ciao.gmane.io" To: 60188@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 19 06:14:33 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p78Tw-0005OI-I6 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Dec 2022 06:14:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p78TX-0002Bg-Va; Mon, 19 Dec 2022 00:14:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p78TS-0002BK-N1 for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 00:14:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p78TS-0005TE-F5 for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 00:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p78TR-0005zR-U1 for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 00:14:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Shuguang Sun Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Dec 2022 05:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 60188 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.167142683923010 (code B ref -1); Mon, 19 Dec 2022 05:14:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 19 Dec 2022 05:13:59 +0000 Original-Received: from localhost ([127.0.0.1]:37880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p78TO-0005z4-Pf for submit@debbugs.gnu.org; Mon, 19 Dec 2022 00:13:59 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:39940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p78TJ-0005yx-Dv for submit@debbugs.gnu.org; Mon, 19 Dec 2022 00:13:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p78TD-00028z-5g for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 00:13:48 -0500 Original-Received: from out162-62-57-64.mail.qq.com ([162.62.57.64]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p78T9-0005Qo-HY for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 00:13:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1671426812; bh=/z3aayjVdM1IExqdVld3dkN7MQDPt+VcR8TjbmPsTss=; h=From:To:Subject:Date; b=PkKomWGiZ3imYp9e0TGkRkbswr7Tqp6cM50yv7AaO1br7yYhhC0WsaU6I1hnRxRxd rf4AocauW5jWA6uMc8nTtm8NlWUidXvetCUmH4fMWCTcHHZn+k4wWl5PI80DEZg8K/ tg5Ch3YIU1Tv5XQ7fc0mkXGUBz2LlMePFEJrb8t0= Original-Received: from YJ190169 ([114.88.230.170]) by newxmesmtplogicsvrszc2-0.qq.com (NewEsmtp) with SMTP id 30A09CB2; Mon, 19 Dec 2022 13:12:10 +0800 X-QQ-mid: xmsmtpt1671426730tmoqmwc6e X-QQ-XMAILINFO: NyTsQ4JOu2J2XJgPSToOrHIFHGepaM7YzY0FKQgbzsbhJHLp4vpOEjbo8G7p4C U2nrBOv+U3BQgAbH23x4HDJu2CCAYg8cC+dIWqhO9tEaTKF31pekuvKD7xayghcvhJrubdR/6Kav fIdRPZMBTViaV5YZFiShGeYFLTH5tJB4l8nTdxNs0HWjyzgroc60bf+Xd4ZuJu8AaUaDpx7FKgha VoRVvQ7SKgPh2p0SwEL2eu1kUYeRJsFrjktQ8E0PeSmoFuGL496uIcXyd0sFuEWos8tqlDGxLMIU wc64PZRpDNPsN5g8rxnvAHWjTZKmuH1omwDfPc2vnth6T6KqftXgcPZZdEjKX+lM9lXxTYvXCbjj DxIsEYDgXuT7J6oExu91Vd5R+P36aZjfzENeXweKWlFmg+jRCO11WVKlXEsiVugZUGLJQy/Adx/8 EU/lUJQK2z1qRwprg61ePb3xq2QgFdLmSwCx8ygOVy8XKvOQt1WrA7YdWpy8mfYYrvG17ANFMB7G mnjKuuCQ7eUbwGbB/eDmBFMlig6pRaeV0dJehf8ZPDOtPy9NDsLsYbgs4xYav7nW944pvTRzzB0J JNMD+m9fWYAHizczznwValjowCy+KX1uFcfKbOTMoob9O8zYB8r2jkJa5xtmBFubHEP+0Cifrlvi lVdXvmXu5Bmc5ND6ImJlXaZ93YfYeDVetnLpDlUbdsQgllrNttVAvVtG59rFnED+ihuSAajhpp1N KRPdy+EWreCgO9bj9vl5l4YdyRH4Tmf0i4XSsY2m153aWllSK+FQXonv+SV6CQqc7UuSQFBfCnod zxODqjbcbWKJxThX2dz4uCAZ/NEGUTRdrIQe3mWh X-OQ-MSGID: <861qowugd2.fsf@qq.com> Received-SPF: pass client-ip=162.62.57.64; envelope-from=shuguang79@qq.com; helo=out162-62-57-64.mail.qq.com X-Spam_score_int: 11 X-Spam_score: 1.1 X-Spam_bar: + X-Spam_report: (1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HELO_DYNAMIC_IPADDR=1.951, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251398 Archived-At: Dear all, When I call C-x p d (project-find-dir), it reports the error message: `project--read-file-cpd-relative: Wrong type argument: stringp, nil` Finaly I found it is due the the zero length of `common-parent-directory` in `project--read-file-cpd-relative` as I using `fd` to provide the list of dirs which does not include the common project root in the returnd dirs. In `project--read-file-cpd-relative`, the zero length of `common-parent-directory` is handled for `prompt` but not for `abbr-cpd` which will be used as parameter of `string-prefix-p`. Below is the diff and a working patch. But no sure for the impact of HIST. ``` diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index 559da6dd649..8c4ea8eeca0 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -1039,7 +1039,9 @@ project--read-file-cpd-relative (_ (when included-cpd (setq substrings (cons "./" substrings)))) (new-collection (project--file-completion-table substrings)) - (abbr-cpd (abbreviate-file-name common-parent-directory)) + (abbr-cpd (if (zerop cpd-length) + "" + (abbreviate-file-name common-parent-directory))) (relname (cl-letf ((history-add-new-input nil) ((symbol-value hist) (mapcan ``` Best Regards, Shuguang Sun In GNU Emacs 30.0.50 (build 1, x86_64-w64-mingw32) of 2022-12-18 built on YJ190169 Repository revision: 2c2ecb46b0ad3e841ac9551e3a80d02893cdf6ec Repository branch: master Windowing system distributor 'Microsoft Corp.', version 10.0.22621 System Description: Microsoft Windows 10 Home China (v10.0.2009.22621.963) Configured using: 'configure --without-pop --with-native-image-api --with-native-compilation --with-tree-sitter --without-compress-install '--program-transform-name=s/^ctags$/ctags.emacs/'' Configured features: ACL DBUS GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XPM ZLIB