unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Yang Yingchao via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 61208@debbugs.gnu.org
Subject: bug#61208: 29.0.60; treesit-beginning/end-of-defun problem with macros in c-ts-mode
Date: Thu, 02 Feb 2023 09:48:19 +0800	[thread overview]
Message-ID: <tencent_0B94CF51357F1219A000EF364C21DAE7A206@qq.com> (raw)
In-Reply-To: <tencent_911881A0ED8B42D8CF38A994235BFE02B207@qq.com>

[-- Attachment #1: Type: text/plain, Size: 2280 bytes --]

On Thu, Feb 02 2023, Yang Yingchao <yang.yingchao@qq.com> wrote:

> On Wed, Feb 01 2023, Theodor Thornhill <theo@thornhill.no> wrote:
>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>>>> Cc: yang.yingchao@qq.com
>>>> Date: Wed, 01 Feb 2023 14:33:24 +0800
>>>> From:  Yang Yingchao via "Bug reports for GNU Emacs,
>>>>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>>>
>>>>
>>>> #define SWITCH()
>>>> #define CASE(name)		case name:
>>>>
>>>> void func(int i)        // LINE_E
>>>> {
>>>>     SWITCH(i)           // LINE_D
>>>>     {
>>>>         CASE(A)         // LINE_C
>>>>         {
>>>>             ;
>>>>         }
>>>>         CASE(B)         // LINE_B
>>>>         {
>>>>             ;           // LINE_A
>>>>         }
>>>>     }
>>>> }
>>>>
>>>> When cursor is at LINE_A, and stoke `C-M-a`, cursor will go to LINE_B;
>>>> then `C-M-a` again, cursor goes to LINE_C, then `C-M-a` again, LINE_D,
>>>> and `C-M-a` again, finally to LINE_E...
>>>
>>> Set treesit-defun-tactic to 'top-level, and your problem is solved.
>>>
>>> Yuan, Theo: do we want to have that set by default in ts-c-mode?  C
>>> doesn't have nested functions, so it should be a better default, what
>>> with all the cpp madness that the C grammar doesn't grok.
>>>
>>> Maybe also in C++ and Java -- AFAIU they don't have nested functions
>>> either.
>>>
>>> WDYT?
>>
>> I'm fine with that change, I think.  Other, "smaller" constructs can be
>> found as sentences or sexps anyway, I think.
>>
>> Theo
>

Thanks for the help.

But in the following C++ code, is it possible to make treesit-beginning/end-of-defun behaves the same as c++-mode ?

,----
| class Test       // LINE_D
| {
| public:
|     Test(int i)  // LINE_C
|     {
|         SWITCH(i)
|         {
|             CASE(A)
|             {
|                 ;
|             }
|             CASE(B) // LINE_B
|             {
|                 ; // LINE_A
|             }
|         }
|     }
| };
`----

When cursor is at LINE_A, if in c++-mode, `C-M-a` moves cursor to LINE_C, which is correct.
But in c++-ts-mode, behaviour of  `C-M-a` is wrong:
if treesit-defun-tactic is nested, it moves to line_B, and if treesit-defun-tactic is top-level,
it moves to LINE_D. Both of them are actually wrong...


--
Yang Yingchao
Yang Yingchao

  parent reply	other threads:[~2023-02-02  1:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fc907ec5049baaaff04d38dd4ed5ab996500a50b6d723604fff453aad543dc86@mu.id>
2023-02-01  6:33 ` bug#61208: 29.0.60; treesit-beginning/end-of-defun problem with macros in c-ts-mode Yang Yingchao via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-01 12:49   ` Eli Zaretskii
2023-02-01 13:10     ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-02  0:48       ` Yang Yingchao via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-02  7:16         ` Eli Zaretskii
     [not found]       ` <875yckubqb.fsf@qq.com>
2023-02-02  1:48         ` Yang Yingchao via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-02-02  2:32     ` Yuan Fu
2023-02-02  7:41       ` Eli Zaretskii
2023-02-02 18:22         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_0B94CF51357F1219A000EF364C21DAE7A206@qq.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=61208@debbugs.gnu.org \
    --cc=yingchao.yang@seaboxdata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).