From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#24675: 26.0.50; Misleading suggestion in Ediff Info manual Date: Tue, 13 Dec 2016 13:03:32 -0500 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1481652258 10377 195.159.176.226 (13 Dec 2016 18:04:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 13 Dec 2016 18:04:18 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: 24675@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 13 19:04:10 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGrQv-0001Y2-TZ for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Dec 2016 19:04:10 +0100 Original-Received: from localhost ([::1]:39863 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGrR0-00024r-8o for geb-bug-gnu-emacs@m.gmane.org; Tue, 13 Dec 2016 13:04:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36241) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGrQu-00024l-Ba for bug-gnu-emacs@gnu.org; Tue, 13 Dec 2016 13:04:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGrQo-0001gy-GR for bug-gnu-emacs@gnu.org; Tue, 13 Dec 2016 13:04:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53813) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cGrQo-0001gt-DY for bug-gnu-emacs@gnu.org; Tue, 13 Dec 2016 13:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cGrQo-0002d4-2v for bug-gnu-emacs@gnu.org; Tue, 13 Dec 2016 13:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Dec 2016 18:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24675 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24675-submit@debbugs.gnu.org id=B24675.148165222510083 (code B ref 24675); Tue, 13 Dec 2016 18:04:02 +0000 Original-Received: (at 24675) by debbugs.gnu.org; 13 Dec 2016 18:03:45 +0000 Original-Received: from localhost ([127.0.0.1]:40979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGrQX-0002cZ-8p for submit@debbugs.gnu.org; Tue, 13 Dec 2016 13:03:45 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:45182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGrQV-0002cN-2o for 24675@debbugs.gnu.org; Tue, 13 Dec 2016 13:03:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGrQP-0001bZ-AR for 24675@debbugs.gnu.org; Tue, 13 Dec 2016 13:03:38 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48853) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGrQL-0001ab-VR; Tue, 13 Dec 2016 13:03:33 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1cGrQK-0000GC-B1; Tue, 13 Dec 2016 13:03:32 -0500 X-Spook: jihad Reynosa illuminati Plague Europol Tornado condor X-Ran: c^9T]?x36o@7Io1z.(*+-ZVs|zAk#V747&uU$:E+ov'}IowKz)I}N;xY"\shMQOn.$t))+ X-Hue: yellow X-Attribution: GM In-Reply-To: (Philipp Stephani's message of "Wed, 12 Oct 2016 17:54:50 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126993 Archived-At: Philipp Stephani wrote: > The Ediff Info manual, in section 7.1 "Hooks", says: > > 'ediff-cleanup-hook' > This hook is run just before 'ediff-quit-hook'. This is a good > place to do various cleanups, such as deleting the variant buffers. > Ediff provides a function, 'ediff-janitor', as one such possible > hook, which you can add to 'ediff-cleanup-hook' with 'add-hook'. > > However, ediff-cleanup-hook is a normal hook, and ediff-janitor is a > function taking two required arguments, so it cannot be added to > ediff-cleanup-hook. The manual should e.g. state that a lambda wrapping > ediff-janitor can be added to ediff-cleanup-hook, but not ediff-janitor > itself. It seems the doc hasn't been updated in the past 14 years. Before 50a07e1, there was a single optional argument. You might be one of the few users of this functionality, so maybe you would like to fix the doc yourself? (Making the arguments optional is an additional possibility?) Since the use of lambda for hooks is basic (eg documented in the "Hooks" section of the manual), personally I don't see a need to mention it here or in other places that refer to normal hook uses.