From: Glenn Morris <rgm@gnu.org>
To: 43314-done@debbugs.gnu.org
Subject: bug#43314: vc-bzr-test-bug9726 test fails on master
Date: Sat, 12 Sep 2020 12:53:46 -0400 [thread overview]
Message-ID: <tc8sdf0wdh.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <CADwFkm=twGtuVWaAsgo5GRSrKnuwM6PUv+X9r7AFqiPMnyRTow@mail.gmail.com> (Stefan Kangas's message of "Thu, 10 Sep 2020 10:55:41 -0700")
Version: 27.2
commit 184a497 (HEAD, origin/emacs-27, emacs-27)
Date: Sat Sep 12 09:51:32 2020 -0700
Make vc-bzr tests work with brz 3.1 (bug#43314)
* test/lisp/vc/vc-bzr-tests.el (vc-bzr-test-bug9726)
(vc-bzr-test-bug9781, vc-bzr-test-faulty-bzr-autoloads):
Make them work with brz 3.1.
diff --git a/test/lisp/vc/vc-bzr-tests.el b/test/lisp/vc/vc-bzr-tests.el
index f738da7..b68a694 100644
--- a/test/lisp/vc/vc-bzr-tests.el
+++ b/test/lisp/vc/vc-bzr-tests.el
@@ -38,13 +38,26 @@
;; abort if they cannot. I could not figure out how to stop bzr
;; doing that, so just give it a temporary homedir for the duration.
;; http://bugs.launchpad.net/bzr/+bug/137407 ?
+ ;;
+ ;; Note that with bzr 2.x, this works:
+ ;; mkdir /tmp/bzr
+ ;; HOME=/nonexistent BZR_HOME=/tmp/bzr bzr status
+ ;; but with brz 3.1, it complains:
+ ;; "failed to open trace file: [Errno 13] Permission denied: '/nonexistent'"
+ ;; which confuses vc-dir.
+ ;; We can quieten brz by adding either BRZ_LOG=/dev/null, or
+ ;; XDG_CACHE_HOME=/tmp/bzr (log defaults to XDG_CACHE_HOME/breezy/brz.log),
+ ;; but it seems simpler to just set HOME to a newly created
+ ;; temporary directory.
+ ;; TODO does this means tests should be setting XDG_ variables (not
+ ;; just HOME) to temporary values too?
(let* ((homedir (make-temp-file "vc-bzr-test" t))
(bzrdir (expand-file-name "bzr" homedir))
(ignored-dir (progn
(make-directory bzrdir)
(expand-file-name "ignored-dir" bzrdir)))
(default-directory (file-name-as-directory bzrdir))
- (process-environment (cons (format "BZR_HOME=%s" homedir)
+ (process-environment (cons (format "HOME=%s" homedir)
process-environment)))
(unwind-protect
(progn
@@ -81,7 +94,7 @@
(expand-file-name "subdir" bzrdir)))
(file (expand-file-name "file" bzrdir))
(default-directory (file-name-as-directory bzrdir))
- (process-environment (cons (format "BZR_HOME=%s" homedir)
+ (process-environment (cons (format "HOME=%s" homedir)
process-environment)))
(unwind-protect
(progn
@@ -119,7 +132,7 @@
(expand-file-name "foo.el" bzrdir)))
(default-directory (file-name-as-directory bzrdir))
(generated-autoload-file (expand-file-name "loaddefs.el" bzrdir))
- (process-environment (cons (format "BZR_HOME=%s" homedir)
+ (process-environment (cons (format "HOME=%s" homedir)
process-environment)))
(unwind-protect
(progn
next prev parent reply other threads:[~2020-09-12 16:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 17:55 bug#43314: vc-bzr-test-bug9726 test fails on master Stefan Kangas
2020-09-10 18:17 ` Eli Zaretskii
2020-09-10 18:58 ` Stefan Kangas
2020-09-10 19:37 ` Eli Zaretskii
2020-09-10 19:50 ` Stefan Kangas
2020-09-11 4:17 ` Richard Stallman
2020-09-12 7:07 ` Eli Zaretskii
2020-09-11 5:44 ` Eli Zaretskii
2020-09-11 9:39 ` Lars Ingebrigtsen
2020-09-11 10:29 ` Eli Zaretskii
2020-09-11 10:31 ` Lars Ingebrigtsen
2020-09-11 10:39 ` Eli Zaretskii
2020-09-12 16:53 ` Glenn Morris [this message]
2020-09-13 10:47 ` Stefan Kangas
2020-09-13 12:07 ` Lars Ingebrigtsen
2020-09-13 12:22 ` Stefan Kangas
2020-09-13 12:41 ` Lars Ingebrigtsen
2020-09-13 12:45 ` Stefan Kangas
2020-09-13 12:50 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tc8sdf0wdh.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=43314-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).