From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michal Nazarewicz Newsgroups: gmane.emacs.bugs Subject: bug#75291: Redisplay not updating fringe when face filter changes Date: Thu, 02 Jan 2025 20:24:44 +0100 Message-ID: References: <874j2h3yzb.fsf@dancol.org> <8634i1jeai.fsf@gnu.org> <87ttah2hcd.fsf@dancol.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39497"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 75291@debbugs.gnu.org To: Daniel Colascione , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 02 20:25:38 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTQp7-000A7G-Gu for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Jan 2025 20:25:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTQor-0006U8-6O; Thu, 02 Jan 2025 14:25:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTQoZ-0006Md-G7 for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 14:25:06 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tTQoZ-0008AN-6G for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 14:25:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=OPQquKrTI0VxjYfQaB1HLY8JyJIN/bwUx5vBdFYnfG8=; b=akk4Uvz34ciTkbx3wr1Ta5VWw0mIDSuHpaPBgu5dxZKMXAVTCPUaUV9aNd3f73rl6d8HJCmGsEFrhk3n+HVhxZnGAXQehn2KcLIarEFrlGHivBIBDQtENMCP5wgx048KapQQcoiKZEudFybCruV8FzZi8DK/Td1MpCAJTYeK/abpkQFox7gqpYp85hx5h2NuPEVQOQ55/75nc05Z4w+Lh0F8+dZgZLAK5vOxdGW31GhTT+PC10EweHCPuBuShAnQLtbSWrcYQSyA2FP6/4ko6YkA//ubz7cHlfetseFliJ5XTpRkcruT2/cmniTXIdJj31qiBCmU+tm8jVMQSFUcKw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tTQoY-0002p3-NN for bug-gnu-emacs@gnu.org; Thu, 02 Jan 2025 14:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michal Nazarewicz Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Jan 2025 19:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75291 X-GNU-PR-Package: emacs Original-Received: via spool by 75291-submit@debbugs.gnu.org id=B75291.173584589110822 (code B ref 75291); Thu, 02 Jan 2025 19:25:02 +0000 Original-Received: (at 75291) by debbugs.gnu.org; 2 Jan 2025 19:24:51 +0000 Original-Received: from localhost ([127.0.0.1]:46713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tTQoM-0002oT-V5 for submit@debbugs.gnu.org; Thu, 02 Jan 2025 14:24:51 -0500 Original-Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:50646) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tTQoK-0002oI-NW for 75291@debbugs.gnu.org; Thu, 02 Jan 2025 14:24:49 -0500 Original-Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-5d3e9a88793so20803791a12.1 for <75291@debbugs.gnu.org>; Thu, 02 Jan 2025 11:24:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735845887; x=1736450687; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:face :references:in-reply-to:subject:cc:to:from:sender:from:to:cc:subject :date:message-id:reply-to; bh=OPQquKrTI0VxjYfQaB1HLY8JyJIN/bwUx5vBdFYnfG8=; b=hngw5+K4Xx30YgXMBp+0K4QyvkP0tdez5YwWYBvWgKYh0qJMNbNcmE/1N25TeL6LGS /6oM9IlUVOyQwhxTXL2SCbbAEORTKxw+QwiHc59EzpIYa7oEHw1s3Fy7UsW7DSbsFG4S 6Lj9GHx3fppXbDWbWg7UITALXFIQ3PchhsJ96no5vRiKIP4I5yF+0yMVeFf0KaZq0lET TlcY8y8JECz32AxthSwP7SBxIj4H3hlbVLL4ph5IDcmO2qYTXI/4ObnS3RvuTH5SbJL7 CQyKcHXES1vcXPsZagTPS+BVrVQBrkovaBGyJWP5ObXLgxZV2H/zuHOb0Zt7kXed5JnR EVfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735845887; x=1736450687; h=content-transfer-encoding:mime-version:message-id:date:face :references:in-reply-to:subject:cc:to:from:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=OPQquKrTI0VxjYfQaB1HLY8JyJIN/bwUx5vBdFYnfG8=; b=hkkE5MTnLt6Q6TFJDF3+a1nFdOdQfRvqSsOKCRPKpzmNViQzVaUFs6W+SrVTQMFrEU hrYcoRD8fGRfzXq8G/sIr37rYq3Z88ltBdILJMDIV44fyUTQM3vaAJilXLX9KFfKpn+T ym0XjnMFG9iLbsOsvCwoBgwRLeY8lqZ2d/WBS4hXsb6tHnbo0Xg8/Dj94tRaDZMJnizh A9se5A9Hpr8+mVamQ2802VPDCRGXVmUium9BNnmUfvjIQRe+1OG8oajRKMAyk4vpx4XZ IiGMfljlFcF4TVIgD5RzcXoj81MQTUznqfdtrMfn7rwhKu/CAXG/cp7ctymCxHih+roP ixHw== X-Gm-Message-State: AOJu0YzB9vH9qk9WZvNsISrDieaxHsm+J0d6RFb0hiwn1o+bXW+KP6Ap cWWn+LLo+GKDN/UcSHKUKqSc7YK+XEd0i0qNJ8LLUPM4kfgTQd4fGTvnR5lH X-Gm-Gg: ASbGnctmq3oOZbs63ohRzSqDF4DPUTEBHi277CkvPE4aKS5oXkObNb6qBfkWPmhdbj4 vtvLSu9zYpha7Mkk86DvhCpqcjNo5yuBI4/uZFzKw+sNSl6jMoydkPYMopyWp2HywYomSC7p3Z4 3IphqQ61Kk90+iS7c4gHdxpK5x2id45mLRJcTT90Ab9JScIi6Y8ubwT9d3Wi+jx85muz6jbRiDC FRp21TMLH0LcyRlDX1oYaWynDdFNa5Q+25S8CAKNh8mmz5igHBXK+Kd5OyvR1P7PCgPuRXFSa+0 DLth0A== X-Google-Smtp-Source: AGHT+IHM1HuTVrZamwUTekbdDxkJ/npf9WWk5i+eVwVV1dO/VNkRcVLerQyoQrCtmLS6FUa6voiOvg== X-Received: by 2002:a17:907:3f2a:b0:aa6:5603:e03d with SMTP id a640c23a62f3a-aac336631f6mr3836478466b.59.1735845886676; Thu, 02 Jan 2025 11:24:46 -0800 (PST) Original-Received: from erwin (87-205-2-211.static.ip.netia.com.pl. [87.205.2.211]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0e894c2esm1843539466b.67.2025.01.02.11.24.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jan 2025 11:24:46 -0800 (PST) In-Reply-To: <87ttah2hcd.fsf@dancol.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWjgIPUupJ7V0jLrom4gmjPs42bY0MdFRLHgE5UPDCbfGm9mH6qmkAJAAACNUlEQVQ4y23SMW/aQBQHcKtb2Zx0abZeIxuTCSELJVmiinboRpGHJktloROQzUQcB2vUXFe35XBYUicRAiYUVSjfru/d+QwlnDz5p/97z+dnVcw5WVQ2zxpcdrQTTiIin3bB6lcaTnaBO5c8eoJG2yBl5El+Ob3fglMW3RUIkQ9xxQ8UBEFQafiVZ/5wZqWExM+LvwEegAY856xZO7MgQkq3jxpO56GXxO5VDQAjpVmWqPLYoSGvIahIuvAVHLeEEDd9DRYAkUcKzscAUgCQ0hwSKBOExuh7kvQQUskY4yjsHqeaCfFjLK6x1AzeeyiRD/C1JW5aGqw5IS5mZre+FVz0RVtoUGPJmBCP/4QPJGKUA1oEMJwAHIv+JljYZYCJi1FRQS2DaUw6sgsQTMfb0Fz9RvjyP3iR01x9RGj0N6HgcefS819CSjidDwIFPSFEDgRg1tUw2oBXAB33T2DV63XbM6AqhZzysm3ZcKZrKBAn5O7Q1rAqGoBKNGRsmUG1n0NKaJtd2RnscTWvnom6fGngDaNrCNl728A+c2gLQP8PFpkEjNWjlGqQfPEhWRqoInSyi2p+drsGDjhAeAeSQI8kfjSwbwCn8gblvIftInzT30HdQT2HlU4gwCbLSQ7VFqVEA0RCtjTwtnjdLlkasNjQwF7x02F2iQSL8XIGB8 VQ71WBKHHf5XCIgLUUtIcGSBPhdZIQorpEBrxsqT3GYgRpmicIqrsEgSZm3FG+iJbHYid0/wGj+iTGCXRsqQAAAABJRU5ErkJggg== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298221 Archived-At: > Eli Zaretskii writes: >> I think this is bug#74876 again. I tried to explain there why the way >> the fringe drawing is implemented doesn't work well with >> face-remapping (or with changes in the fringe face in general). >> >> Maybe I'm missing something, but supporting what this and that bug >> want would need a rewrite of update_window_fringes (and possibly also >> the way we record fringes' attributes in the glyph row). On Thu, Jan 02 2025, Daniel Colascione wrote: > (BTW: my code uses pre-redisplay-function, not a command hook. I've > tried it both ways and found the redisplay hook to be more reliable.) FYI, the actual auto-dim-other-buffers code doesn=E2=80=99t use pre-command-hook. It uses hooks for window, buffer or focus changes. > Anyway, given that the feature has been implemented twice now, maybe we > can find some way to make it work efficiently? Since I managed to work-around the issue, I haven=E2=80=99t looked closely = at the low-level details of the redrawing code. From afar it certainly looks like it should be easy to force redrawing of fringes only, but I also trust Eli=E2=80=99s opinion on complexity of this task more than my impressions. While I=E2=80=99d like to have a function indicating that particular window= =E2=80=99s fringes need to be updated (maybe something like =E2=80=98(force-window-upd= ate window t)=E2=80=99, I won=E2=80=99t have time to work on this any time soon. > Ideally, a change to a face in which the change couldn't possibly affect > layout (e.g. changing a background color) would be pretty efficient from > a redisplay POV, since we wouldn't have to even try to reflow any > text. I don=E2=80=99t think it=E2=80=99s that simple. Even if all you=E2=80=99re= changing is colour, you still need to redraw the text. At best, without anti-aliasing there may be some way to optimise it but I doubt complicating the code to support that would be worth it. --=20 Best regards =E3=83=9F=E3=83=8F=E3=82=A6 =E2=80=9C=F0=9D=93=B6=F0=9D=93=B2=F0=9D=93=B7= =F0=9D=93=AA86=E2=80=9D =E3=83=8A=E3=82=B6=E3=83=AC=E3=83=B4=E3=82=A4=E3=83= =84 =C2=ABIf at first you don=E2=80=99t succeed, give up skydiving=C2=BB