unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#6135: font lock is not turned on in js-mode anymore
@ 2010-05-07 15:22 Paul Pogonyshev
  2010-06-16  3:52 ` Glenn Morris
  0 siblings, 1 reply; 6+ messages in thread
From: Paul Pogonyshev @ 2010-05-07 15:22 UTC (permalink / raw)
  To: 6135

Since a few days, opening a .js file (js-mode) doesn't turn buffer
fontification on, despite `global-font-lock-mode' being t.  Directly
invoking `M-x font-lock-mode' in this new buffer does bring syntax
highlight back, so it's not like "fontification does not work" it is
"fontification is not turned on".

Paul







^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#6135: font lock is not turned on in js-mode anymore
  2010-05-07 15:22 bug#6135: font lock is not turned on in js-mode anymore Paul Pogonyshev
@ 2010-06-16  3:52 ` Glenn Morris
  2010-06-16 13:56   ` Stefan Monnier
  0 siblings, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2010-06-16  3:52 UTC (permalink / raw)
  To: Paul Pogonyshev; +Cc: 6135

Paul Pogonyshev wrote:

> Since a few days, opening a .js file (js-mode) doesn't turn buffer
> fontification on, despite `global-font-lock-mode' being t.  Directly
> invoking `M-x font-lock-mode' in this new buffer does bring syntax
> highlight back, so it's not like "fontification does not work" it is
> "fontification is not turned on".

It seems this is somehow due to
  
  2010-04-27  Stefan Monnier  <monnier at iro.umontreal.ca>
  
  * emacs-lisp/easy-mmode.el (define-globalized-minor-mode): Avoid
  re-enabling a minor mode after the user turned the minor mode off if
  MODE-enable-in-buffers is run twice (typically once from
  fundamental-mode's after-change-major-mode-hook and a second time from
  run-mode-hook's own after-change-major-mode-hook).





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#6135: font lock is not turned on in js-mode anymore
  2010-06-16  3:52 ` Glenn Morris
@ 2010-06-16 13:56   ` Stefan Monnier
  2010-06-16 15:53     ` Glenn Morris
  0 siblings, 1 reply; 6+ messages in thread
From: Stefan Monnier @ 2010-06-16 13:56 UTC (permalink / raw)
  To: Glenn Morris; +Cc: 6135, Paul Pogonyshev

>> Since a few days, opening a .js file (js-mode) doesn't turn buffer
>> fontification on, despite `global-font-lock-mode' being t.  Directly
>> invoking `M-x font-lock-mode' in this new buffer does bring syntax
>> highlight back, so it's not like "fontification does not work" it is
>> "fontification is not turned on".

> It seems this is somehow due to
  
>   2010-04-27  Stefan Monnier  <monnier at iro.umontreal.ca>
  
>   * emacs-lisp/easy-mmode.el (define-globalized-minor-mode): Avoid
>   re-enabling a minor mode after the user turned the minor mode off if
>   MODE-enable-in-buffers is run twice (typically once from
>   fundamental-mode's after-change-major-mode-hook and a second time from
>   run-mode-hook's own after-change-major-mode-hook).

What's the recipe to reproduce the problem?


        Stefan





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#6135: font lock is not turned on in js-mode anymore
  2010-06-16 13:56   ` Stefan Monnier
@ 2010-06-16 15:53     ` Glenn Morris
  2010-06-16 20:01       ` Stefan Monnier
  0 siblings, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2010-06-16 15:53 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: 6135, Paul Pogonyshev

Stefan Monnier wrote:

> What's the recipe to reproduce the problem?

emacs -Q -f js-mode
C-h v font-lock-mode





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#6135: font lock is not turned on in js-mode anymore
  2010-06-16 15:53     ` Glenn Morris
@ 2010-06-16 20:01       ` Stefan Monnier
  2010-06-16 20:55         ` Glenn Morris
  0 siblings, 1 reply; 6+ messages in thread
From: Stefan Monnier @ 2010-06-16 20:01 UTC (permalink / raw)
  To: Glenn Morris; +Cc: 6135, Paul Pogonyshev

>> What's the recipe to reproduce the problem?
> emacs -Q -f js-mode
> C-h v font-lock-mode

Thanks.  I've installed a change in emacs-23 which seems to fix
this problem.  Part of the problem is that js-mode jumps through
some hoops to apply syntax-fontification to the whole buffer eagerly.


        Stefan





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#6135: font lock is not turned on in js-mode anymore
  2010-06-16 20:01       ` Stefan Monnier
@ 2010-06-16 20:55         ` Glenn Morris
  0 siblings, 0 replies; 6+ messages in thread
From: Glenn Morris @ 2010-06-16 20:55 UTC (permalink / raw)
  To: 6135-done

Stefan Monnier wrote:

> I've installed a change in emacs-23 which seems to fix this problem.

Works for me, thanks.





^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2010-06-16 20:55 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-07 15:22 bug#6135: font lock is not turned on in js-mode anymore Paul Pogonyshev
2010-06-16  3:52 ` Glenn Morris
2010-06-16 13:56   ` Stefan Monnier
2010-06-16 15:53     ` Glenn Morris
2010-06-16 20:01       ` Stefan Monnier
2010-06-16 20:55         ` Glenn Morris

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).