From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ruijie Yu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60418: [PATCH] Add :vc keyword to use-package Date: Mon, 17 Apr 2023 00:18:48 +0800 Message-ID: References: <87zgb6uk2r.fsf@hyperspace> <87tu0tl1s4.fsf@hyperspace> <87a5zt2emd.fsf@betli.tmit.bme.hu> <87fs9l9bim.fsf@posteo.net> <87y1n3zsro.fsf@posteo.net> <871qku220f.fsf@betli.tmit.bme.hu> <874jpq920b.fsf@posteo.net> <87cz4ezpwi.fsf@betli.tmit.bme.hu> <87h6tlinft.fsf@hyperspace> <87r0spa712.fsf@posteo.net> <87edopiif5.fsf@hyperspace> <87wn2bzvcp.fsf@hyperspace> Reply-To: Ruijie Yu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16299"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.9.22; emacs 30.0.50 Cc: philipk@posteo.net, felician.nemeth@gmail.com, 60418@debbugs.gnu.org, stefankangas@gmail.com To: Tony Zorman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 16 18:26:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1po5Ch-00045l-Cj for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Apr 2023 18:26:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1po5CX-0000Tr-18; Sun, 16 Apr 2023 12:26:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1po5CW-0000Ta-49 for bug-gnu-emacs@gnu.org; Sun, 16 Apr 2023 12:26:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1po5CU-0006KQ-Q0 for bug-gnu-emacs@gnu.org; Sun, 16 Apr 2023 12:26:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1po5CU-0001xt-47 for bug-gnu-emacs@gnu.org; Sun, 16 Apr 2023 12:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ruijie Yu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Apr 2023 16:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: Philip Kaludercic , Felician Nemeth , 60418@debbugs.gnu.org, bug-gnu-emacs@gnu.org, stefankangas@gmail.com Original-Received: via spool by 60418-submit@debbugs.gnu.org id=B60418.16816623157491 (code B ref 60418); Sun, 16 Apr 2023 16:26:02 +0000 Original-Received: (at 60418) by debbugs.gnu.org; 16 Apr 2023 16:25:15 +0000 Original-Received: from localhost ([127.0.0.1]:52403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1po5Bj-0001wl-GW for submit@debbugs.gnu.org; Sun, 16 Apr 2023 12:25:15 -0400 Original-Received: from netyu.xyz ([152.44.41.246]:33510 helo=mail.netyu.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1po5Bh-0001wd-Sa for 60418@debbugs.gnu.org; Sun, 16 Apr 2023 12:25:14 -0400 Original-Received: from fw.net.yu ( [222.248.4.98]) by netyu.xyz (OpenSMTPD) with ESMTPSA id 192bdca4 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 16 Apr 2023 16:25:12 +0000 (UTC) In-reply-to: <87wn2bzvcp.fsf@hyperspace> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260141 Archived-At: Tony Zorman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > --- a/test/lisp/use-package/use-package-tests.el > +++ b/test/lisp/use-package/use-package-tests.el > @@ -1951,6 +1951,55 @@ bind-key/845 > (should (eq (nth 1 binding) 'ignore)) > (should (eq (nth 2 binding) nil)))) > > +(ert-deftest use-package-test/:vc-1 () > + (match-expansion > + (use-package foo :vc (:url "bar")) > + '(use-package-vc-install '(foo (:url "bar") :last-release) nil))) > + > +(ert-deftest use-package-test/:vc-2 () > + (match-expansion > + (use-package foo > + :vc (baz . (:url "baz" :vc-backend "Git" > + :main-file qux.el :rev "rev-string"))) > + `(use-package-vc-install '(baz > + (:url "baz" :vc-backend Git :main-file "qux.el") > + "rev-string") > + nil))) I'm curious, what is the significance to using quote versus quasiquote? I noticed that there is no unquote inside the quasiquote at all, and am wondering whether it is simply a typo or some sort of peculiarity in `match-expansion'. Admittedly I didn't look into the definition of `match-expansion' since "git fetch" is taking its time on my end for some reason. -- Best, RY