From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ruijie Yu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61326: [DRAFT PATCH v4] Work around zip's filename extension limitation (was: Adding --no-add-suffix to zip patch) Date: Sat, 11 Mar 2023 16:57:08 +0800 Message-ID: References: <87ilgeoc4w.fsf@tullinup.koldfront.dk> <8574C128-9560-490A-88E6-49E415BBDB24@netyu.xyz> <83k00up32i.fsf@gnu.org> <83bkm4nihw.fsf@gnu.org> <83zg8sahin.fsf@gnu.org> <83jzzwa6u3.fsf@gnu.org> <83h6uz8ac4.fsf@gnu.org> <834jqry8fn.fsf@gnu.org> Reply-To: Ruijie Yu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28139"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.8.14; emacs 30.0.50 Cc: asjo@koldfront.dk, 61326@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 11 10:05:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pavAL-00074i-2v for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Mar 2023 10:05:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pavA0-0001P9-LT; Sat, 11 Mar 2023 04:05:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pav9y-0001Oo-Tg for bug-gnu-emacs@gnu.org; Sat, 11 Mar 2023 04:05:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pav9y-0007k8-Hx for bug-gnu-emacs@gnu.org; Sat, 11 Mar 2023 04:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pav9y-00070O-0C for bug-gnu-emacs@gnu.org; Sat, 11 Mar 2023 04:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ruijie Yu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Mar 2023 09:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61326 X-GNU-PR-Package: emacs Original-Received: via spool by 61326-submit@debbugs.gnu.org id=B61326.167852548126893 (code B ref 61326); Sat, 11 Mar 2023 09:05:01 +0000 Original-Received: (at 61326) by debbugs.gnu.org; 11 Mar 2023 09:04:41 +0000 Original-Received: from localhost ([127.0.0.1]:56549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pav9d-0006zh-Eg for submit@debbugs.gnu.org; Sat, 11 Mar 2023 04:04:41 -0500 Original-Received: from netyu.xyz ([152.44.41.246]:50144 helo=mail.netyu.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pav9c-0006zX-CC for 61326@debbugs.gnu.org; Sat, 11 Mar 2023 04:04:40 -0500 Original-Received: from fw.net.yu.netyu.xyz ( [222.248.4.98]) by netyu.xyz (OpenSMTPD) with ESMTPSA id 2f629992 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 11 Mar 2023 09:04:38 +0000 (UTC) In-reply-to: <834jqry8fn.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257766 Archived-At: Eli Zaretskii writes: >> [...] I turned it into a `cl-do' construct. [...] > > I don't object in principle, but in this case it looks like the > implementation based on cl-do needs much more complex code than the > original? If so, I'd prefer the original, simpler and > easier-to-understand code. It's more that everything is buried under the let expression, so it _looks_ more complex. But I do agree that this change might introduce unnecessary cognative load for maintainers and I will revert that change in my next iteration. > The commit log message is not detailed enough: it doesn't mention the > functions you modify. Please see the conventions we follow for log > messages described in CONTRIBUTE, which also mentions useful Emacs > functions which will help you format the log message according to our > conventions. > > Thanks. Thank you for the review. I will take a closer look at etc/CONTRIBUTE -- apparently I didn't read it in enough detail. I will report back within the next few days. -- Best, RY