From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#28396: 26.0.50; display-line-numbers not saved by Save Options Date: Tue, 21 Nov 2017 19:44:05 -0500 Message-ID: References: <83mv64w5le.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1511311512 6925 195.159.176.226 (22 Nov 2017 00:45:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 22 Nov 2017 00:45:12 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: 28396@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 22 01:45:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHJA1-0001Mh-Ft for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 Nov 2017 01:45:05 +0100 Original-Received: from localhost ([::1]:37251 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eHJA8-0002fB-Q9 for geb-bug-gnu-emacs@m.gmane.org; Tue, 21 Nov 2017 19:45:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eHJ9z-0002ev-90 for bug-gnu-emacs@gnu.org; Tue, 21 Nov 2017 19:45:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eHJ9y-0002c5-Cs for bug-gnu-emacs@gnu.org; Tue, 21 Nov 2017 19:45:03 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42932) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eHJ9y-0002c0-9j for bug-gnu-emacs@gnu.org; Tue, 21 Nov 2017 19:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eHJ9y-0003P2-2d for bug-gnu-emacs@gnu.org; Tue, 21 Nov 2017 19:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Nov 2017 00:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28396 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28396-submit@debbugs.gnu.org id=B28396.151131145412976 (code B ref 28396); Wed, 22 Nov 2017 00:45:02 +0000 Original-Received: (at 28396) by debbugs.gnu.org; 22 Nov 2017 00:44:14 +0000 Original-Received: from localhost ([127.0.0.1]:51613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHJ9B-0003NE-Me for submit@debbugs.gnu.org; Tue, 21 Nov 2017 19:44:13 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:33352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHJ99-0003N2-U9 for 28396@debbugs.gnu.org; Tue, 21 Nov 2017 19:44:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eHJ93-0002M2-U4 for 28396@debbugs.gnu.org; Tue, 21 Nov 2017 19:44:06 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50370) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eHJ93-0002Lx-Qd for 28396@debbugs.gnu.org; Tue, 21 Nov 2017 19:44:05 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1eHJ93-0008Lr-Aj; Tue, 21 Nov 2017 19:44:05 -0500 X-Spook: Taiwan counter terrorism Power outage Shots fired Reyosa X-Ran: =^b>>KNX|;2"wqhx@y&oR0I=p"]z`%z3*p"y9]TM?-~#GsMCSQ^pe@;Z,|?yWTiO`wpYac X-Hue: blue X-Attribution: GM In-Reply-To: <83mv64w5le.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 09 Sep 2017 13:04:29 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140223 Archived-At: Eli Zaretskii wrote: > emacs -Q > Click Options in the menu bar > Select Show/Hide->Line Numbers For All Lines->Global Line Numbers Mode > Click Options->Save Options > > The result is that the setting of global-display-line-numbers-mode is > not saved on the init file. commit daa959e (HEAD, origin/emacs-26, emacs-26) Date: Tue Nov 21 19:42:32 2017 -0500 * lisp/menu-bar.el (menu-bar-options-save): Add global-display-line-numbers-mode. (Bug#28396) diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el index 972f84e..9ff3de1 100644 --- a/lisp/menu-bar.el +++ b/lisp/menu-bar.el @@ -669,7 +669,8 @@ menu-bar-options-save (let ((need-save nil)) ;; These are set with menu-bar-make-mm-toggle, which does not ;; put on a customized-value property. - (dolist (elt '(line-number-mode column-number-mode size-indication-mode + (dolist (elt '(global-display-line-numbers-mode + line-number-mode column-number-mode size-indication-mode cua-mode show-paren-mode transient-mark-mode blink-cursor-mode display-time-mode display-battery-mode ;; These are set by other functions that don't set > Note that the solution should also save the sub-mode, when the user > selects, say, Relative Line Numbers. Buffer-local variables like display-line-numbers don't play well with Customize.