From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Julien Danjou Newsgroups: gmane.emacs.bugs Subject: bug#9392: 24.0.50; rmail-forward produces messages in unsupported format that cannot be customized away Date: Fri, 02 Sep 2011 12:54:32 +0200 Message-ID: References: <83vctbcjco.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Trace: dough.gmane.org 1314960948 3489 80.91.229.12 (2 Sep 2011 10:55:48 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 2 Sep 2011 10:55:48 +0000 (UTC) Cc: 9392@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 02 12:55:43 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QzRPS-00026c-PT for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Sep 2011 12:55:43 +0200 Original-Received: from localhost ([::1]:46447 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzRPS-0008Oz-E9 for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Sep 2011 06:55:42 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:40481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzRPP-0008O3-9J for bug-gnu-emacs@gnu.org; Fri, 02 Sep 2011 06:55:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QzRPO-0006NO-8A for bug-gnu-emacs@gnu.org; Fri, 02 Sep 2011 06:55:39 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33290) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QzRPO-0006NK-6c for bug-gnu-emacs@gnu.org; Fri, 02 Sep 2011 06:55:38 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QzRSf-0000p1-Ht; Fri, 02 Sep 2011 06:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Julien Danjou Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Sep 2011 10:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9392 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9392-submit@debbugs.gnu.org id=B9392.13149610833092 (code B ref 9392); Fri, 02 Sep 2011 10:59:01 +0000 Original-Received: (at 9392) by debbugs.gnu.org; 2 Sep 2011 10:58:03 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QzRRi-0000no-QU for submit@debbugs.gnu.org; Fri, 02 Sep 2011 06:58:03 -0400 Original-Received: from prometheus.naquadah.org ([212.85.154.174] helo=mx1.naquadah.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QzRRf-0000nO-DW for 9392@debbugs.gnu.org; Fri, 02 Sep 2011 06:58:01 -0400 Original-Received: from cigue.easter-eggs.fr (coquelicot-a.easter-eggs.com [82.235.59.105]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.naquadah.org (Postfix) with ESMTPSA id 2C7A45C1E8; Fri, 2 Sep 2011 12:54:34 +0200 (CEST) In-Reply-To: <83vctbcjco.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 02 Sep 2011 13:46:31 +0300") User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 02 Sep 2011 06:59:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:50546 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Fri, Sep 02 2011, Eli Zaretskii wrote: > I don't know what was the rationale for this change, because if > message-setup calls message-setup-1, it will still return nil, since > message-setup-1 returns nil unconditionally. The simple patch below > fixes this particular regression. I think I was trying to fix the FIXME. :) diff --git a/lisp/message.el b/lisp/message.el index 28050f8..42ca73c 100644 =2D-- a/lisp/message.el +++ b/lisp/message.el @@ -6582,9 +6582,7 @@ is a function used to switch to and display the mail = buffer." (dolist (h other-headers other-headers) (if (stringp (car h)) (setcar h (intern (capitalize (car h))))))) yank-action send-actions continue switch-function =2D return-action) =2D ;; FIXME: Should return nil if failure. =2D t)) + return-action))) =20 ;;;###autoload (defun message-news (&optional newsgroups subject) > However, rmail-forward is still broken if mail-user-agent is set to > sendmail-user-agent. That is a separate issue. So please do not > close this bug, even if this patch is accepted by the Gnus developers. > > Here's the patch to message.el to restore the Emacs 23.3 default > behavior of rmail-forward: > > =3D=3D=3D modified file 'lisp/gnus/message.el' > --- lisp/gnus/message.el 2011-08-20 00:20:39 +0000 > +++ lisp/gnus/message.el 2011-09-02 09:45:18 +0000 > @@ -6530,7 +6530,9 @@ are not included." > (message-position-point) > ;; Allow correct handling of `message-checksum' in `message-yank-origi= nal': > (set-buffer-modified-p nil) > - (undo-boundary)) > + (undo-boundary) > + ;; rmail-start-mail expects message-mail to return t (Bug#9392) > + t) >=20=20 > (defun message-set-auto-save-file-name () > "Associate the message buffer with a file in the drafts directory." > From=20my quick understanding, this looks good. =2D-=20 Julien Danjou =E2=9D=B1 http://julien.danjou.info --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJOYLXoAAoJEGEbqVCLeKXCbx8QALYIqkeLkG2PeOU53ra5mC3y b6E8ghBZau8vV7yu1Y++OXcN1xy8jWRShrku8ks96i3WYG0mwdiZiBgHFKypSmeS 7ZqUDNmdu0TRkn0hOxL/cUpEl7YtLerMWGH2txxK1PF/hbfJhq6tT/mbst2Y8QYr YcLIbxxLbPxDogPYog/t3Vnm9KHt7vXusPZfZ0E0zc4v9t/IHjNU5S4uO1NfgIRt 4XuzKKOp3aE5KHs3m4+g3mtCsTjIyfvIeAHXG/cowlA3votcUFB1FyKyrP1U7tdq For/X0kTAROhPWDpxXY9KDQeaLHTBRZ7yoW+TWW1bzPXeKD0fw9b5ezom3MkSwzo rouikGfjZUXYQb38jkBBhSJZsMkBeJiY+7OIuNqorm1m13aloF+/x66Bdgjad32+ wrtE5wYwdxa57ALGLim8PxhjQ8Fo1JfHsJH4SrTsulQC5cDYCM4AyUytblUNAr5U 7tFBRBGCDWGdARF1yZHjHFrS5NGzDxOAPGFwbAy9PJcnkZkzTZJyfc3qVE1v6rGk vVOSMF2yu5xdj45YD/tPIew6Lp6sNu4//fHin7KaJW3FjuPYtKoXh2CH+MDY436C 8Q5nSu0bFGQsX5jbPqKOr+XPiQwkCE23/vSr098TMyT7VVKxQAxKBxyjszrN7n9X c+ljGGPlku1SpgcYIvHq =XrJT -----END PGP SIGNATURE----- --=-=-=--