From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62994: [PATCH v7] Add support for colored and styled underlines on tty frames Date: Tue, 23 Apr 2024 08:53:20 +0800 Message-ID: References: <87pm7x5mxc.fsf@kisara.moe> <87sezeitkj.fsf@kisara.moe> <87sezegra8.fsf@yahoo.com> <86bk626imf.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="431"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Jim Porter , 62994@debbugs.gnu.org, mohkale@kisara.moe To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 23 02:54:08 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rz4QC-000AYR-DO for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Apr 2024 02:54:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rz4Ps-0006yQ-Jc; Mon, 22 Apr 2024 20:53:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rz4Pq-0006y7-JH for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2024 20:53:46 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rz4Pq-0002TF-AF for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2024 20:53:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rz4Q6-0002gb-3d for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2024 20:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Apr 2024 00:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62994 X-GNU-PR-Package: emacs Original-Received: via spool by 62994-submit@debbugs.gnu.org id=B62994.171383362310181 (code B ref 62994); Tue, 23 Apr 2024 00:54:02 +0000 Original-Received: (at 62994) by debbugs.gnu.org; 23 Apr 2024 00:53:43 +0000 Original-Received: from localhost ([127.0.0.1]:48811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rz4Pm-0002e9-Nu for submit@debbugs.gnu.org; Mon, 22 Apr 2024 20:53:43 -0400 Original-Received: from sonic302-22.consmr.mail.ne1.yahoo.com ([66.163.186.148]:44183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rz4Pk-0002d0-0t for 62994@debbugs.gnu.org; Mon, 22 Apr 2024 20:53:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1713833598; bh=TAX02gVkueZnrY6ZZdW7IlUKai+uaMXKPz5tDOw2lok=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=gSwLJn/dQstfqwPL7gWCTh3YLzQyRmydZPqhVr0OXfXbdlcYGWSHTHMxYY/z1y/sD1w1LXKti4veS0A7HR/pK7QsnF9t07IZtTxxkizSuOdlPijmT1vBRM4JFJezTrjFR2oGS2w1H5zny9bJB5C0UCl2A0EgRCMx7WOBYIBkYHbrAEDYIXXoB8xZFymCcGGCqNFCT3+UWIGfNrelrneifiol672J5Trc+ZB0osPJyeEF1G59/W+u8EuxRHg8DSBRpANVJnAugAzd78GallIAOWMjpcJ8JqXbw1E7AsCagW9OLLKR/eT6Xj+xOTZ9He49i4kMiBfoL3HEJMhycQQkvA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1713833598; bh=T98T8IdQIlg8imgs5knLR9xr6NreCmEFRmDZQeNcVt8=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=ItkqkSjpuB2ljv0/vFBBOd0zFhFx802ygLZxXr2LSyA/PzJG/VQpkM0WVq11K2xUhrlJnKq0WjwqgCh1OrcoIvST+D89P71qJ+CgkOeRIgaIlsPTpn1knHcV2B5+L9YQNRG3qeUDosTNBhvvzHchdFo7nmlm3FCU3TGXg6YE16+EsjRNxnr7YHTLqA9/uDM8fzyQKov+RmDqbPO0194DR7ZGjJiwSu1GOqCKiNIXIO5r8+8/wjexPeZWxG6uadVLKelL/kZDudeBuD0wbmSCy1qYcpOfQA9vChl92PGLUDicm6dpck+4qyzLk3PP3p5UnGN6Bxq4OfBlgSghBWhh5A== X-YMail-OSG: i1hlxCAVM1lcK8PvGzeHe9.B2RLV6jP5wCJ3kCKwPY2V9mfeWda.R45oM0Wa_EM CW66d57R2UWUfkuuqA_iJ7J4Juulx1J2RwferfdP9C3TxobLLch5SNtrmIBueAcWq4ogLv8Wp6Rj 0jr62xdDM0IYRc4aPaU_Z9mKf456WriSOIhm76gbkp0xW.ZlllhsZ8R8nSDMCzyWgFjY8BQxUulI ReaEFaljfg3HuYbWYCY6fa2R0XQFujCzvTS6YuSx9KThdPzt.9kTHUW9ItDzknGlyZakPHNO4mMu HPas2J0xxZ_ltTSv1cwqWaXDUtkwX4wtdTnM3wOkZCe1Cs5tumUy7.FQwaaTI8p2ZcJzABRDucYm kJIncPRdCZWSgmWTn1gKLaOGQab2vVf2hdZcyvCzFeqS5lgxcjDqc0xfupGzA3ldcfYXJ46DDpFB sECCN0458AK7S_Q6cjCrPKrzbxeNBooivMFvE7kAFeWlmf4iW5ZPblbNqMotrSzBD1c8CdIhEv4Q 8auamQ.rQ1iirWB9uExYS3Kt2IbzAh950ddSUajjO0rtDYBZNYd6Ym18O5bzMU2xDpBQSfV_q9Ah sw201G3lJtX9rLb6cKPFz13D_8FS1LDBAWaKsMoNzDx4ZfpK2imi6ZJ3gPHt61WEC0Mg0OjoJLym GHejLd3RuHv329hmcYKl4_dPDgC6BZo.kDn5QtiesMIxjiY7u.rU1MGpQGusBRabVwtBp_wzpWbi LPSnH_NMLk4zEIemZDafykwvHIvnZI0OPPudN8wj9ViTHAO607HRN7yF2j75kCcyWFgfXkAaqDLH nOGVSkDG8nSMU1vezWGtQmJ2ZXdJjdiBvBLpiupFwt X-Sonic-MF: X-Sonic-ID: d9d998bb-20a9-4ca6-9395-f07f4d537b17 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ne1.yahoo.com with HTTP; Tue, 23 Apr 2024 00:53:18 +0000 Original-Received: by hermes--production-sg3-6f9f87bd85-qljs5 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID b00f3bc68f88858e33dc0daf2a8bfece; Tue, 23 Apr 2024 00:53:15 +0000 (UTC) In-Reply-To: <86bk626imf.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 22 Apr 2024 09:01:28 +0300") X-Mailer: WebService/1.1.22256 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283855 Archived-At: Eli Zaretskii writes: >> Cc: 62994@debbugs.gnu.org >> Date: Mon, 22 Apr 2024 08:44:15 +0800 >> From: Po Lu via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> > * src/xterm.c (x_draw_glyph_string): Updated to use renamed >> > FACE_UNDERLINE_SINGLE and FACE_UNDERLINE_WAVE face_underline_type >> > enumerations. >> >> This change should be accompanied by like updates to >> *_draw_glyph_string >> and related functions in the remaining terminal backends. > > I believe Jim Porter wanted to work on that. Jim, have you made any > progress in this matter? > > In any case, given that implementing this for GUI displays should not > be a problem, I don't see a reason to block this changeset until the > GUI parts are done. Hopefully, Jim or someone else will get it ready > soon. I wasn't asking that the new underline styles be ported to other backends, but that the change to account for renamed enumerator values be ported to the remainder of the *term.[cm] files. Without which they will fail to compile, which goes without saying.