* bug#48021: comp.el cannot be loaded without native compilation
@ 2021-04-26 0:43 Glenn Morris
2021-04-26 14:55 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 9+ messages in thread
From: Glenn Morris @ 2021-04-26 0:43 UTC (permalink / raw)
To: 48021
Package: emacs
Version: 28.0.50
At b7c22fab7d, in a default build:
./src/emacs -Q -l ./lisp/emacs-lisp/comp.el
memq: Symbol's value as variable is void: comp-ctxt
(Presumably it works if --with-native-compilation is used.)
This causes test failures for custom tests, and multiple failures for
comp-cstr-tests (perhaps those should be tagged :nativecomp, I don't know.)
Ref eg https://hydra.nixos.org/build/142074384
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#48021: comp.el cannot be loaded without native compilation
2021-04-26 0:43 bug#48021: comp.el cannot be loaded without native compilation Glenn Morris
@ 2021-04-26 14:55 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-26 19:18 ` Glenn Morris
0 siblings, 1 reply; 9+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-04-26 14:55 UTC (permalink / raw)
To: Glenn Morris; +Cc: 48021
Glenn Morris <rgm@gnu.org> writes:
> Package: emacs
> Version: 28.0.50
>
> At b7c22fab7d, in a default build:
>
> ./src/emacs -Q -l ./lisp/emacs-lisp/comp.el
>
> memq: Symbol's value as variable is void: comp-ctxt
>
> (Presumably it works if --with-native-compilation is used.)
>
> This causes test failures for custom tests, and multiple failures for
> comp-cstr-tests (perhaps those should be tagged :nativecomp, I don't know.)
>
> Ref eg https://hydra.nixos.org/build/142074384
Hi Glenn,
with a390a4965f comp-cstr-tests run clean for me also on vanilla build,
please let me know if this is sufficient for the case you are testing.
Thanks
Andrea
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#48021: comp.el cannot be loaded without native compilation
2021-04-26 14:55 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-04-26 19:18 ` Glenn Morris
2021-04-26 20:29 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 9+ messages in thread
From: Glenn Morris @ 2021-04-26 19:18 UTC (permalink / raw)
To: Andrea Corallo; +Cc: 48021
Andrea Corallo wrote:
>> ./src/emacs -Q -l ./lisp/emacs-lisp/comp.el
>>
>> memq: Symbol's value as variable is void: comp-ctxt
> with a390a4965f comp-cstr-tests run clean for me also on vanilla build,
> please let me know if this is sufficient for the case you are testing.
Thanks. comp-cstr-test-70 is still failing for me.
The issue about comp.el being unloadable in builds without native
compilation remains (and hence test-custom-deps still fails).
I believe that in general, .el files should always be loadable, they
should just do nothing if not applicable.
For example, C-h f completion can try to load comp.el.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#48021: comp.el cannot be loaded without native compilation
2021-04-26 19:18 ` Glenn Morris
@ 2021-04-26 20:29 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-26 21:16 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 9+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-04-26 20:29 UTC (permalink / raw)
To: Glenn Morris; +Cc: 48021
Glenn Morris <rgm@gnu.org> writes:
> Andrea Corallo wrote:
>
>>> ./src/emacs -Q -l ./lisp/emacs-lisp/comp.el
>>>
>>> memq: Symbol's value as variable is void: comp-ctxt
>
>> with a390a4965f comp-cstr-tests run clean for me also on vanilla build,
>> please let me know if this is sufficient for the case you are testing.
>
> Thanks. comp-cstr-test-70 is still failing for me.
Could you share the invocation you are using? I'm asking cause here on
449045b2a6 I see this passing.
>
> The issue about comp.el being unloadable in builds without native
> compilation remains (and hence test-custom-deps still fails).
I didn't know about the test-custom-deps, I'll have a look.
> I believe that in general, .el files should always be loadable, they
> should just do nothing if not applicable.
>
> For example, C-h f completion can try to load comp.el.
We should load comp.el only on native compiled instances, if this is not
the case could you point me out exactly where we do this so I can have a
look?
Thanks
Andrea
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#48021: comp.el cannot be loaded without native compilation
2021-04-26 20:29 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-04-26 21:16 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-27 4:56 ` Glenn Morris
0 siblings, 1 reply; 9+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-04-26 21:16 UTC (permalink / raw)
To: Glenn Morris; +Cc: 48021
Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:
> Glenn Morris <rgm@gnu.org> writes:
>
>> Andrea Corallo wrote:
>>
>>>> ./src/emacs -Q -l ./lisp/emacs-lisp/comp.el
>>>>
>>>> memq: Symbol's value as variable is void: comp-ctxt
>>
>>> with a390a4965f comp-cstr-tests run clean for me also on vanilla build,
>>> please let me know if this is sufficient for the case you are testing.
>>
>> Thanks. comp-cstr-test-70 is still failing for me.
>
> Could you share the invocation you are using? I'm asking cause here on
> 449045b2a6 I see this passing.
>
>>
>> The issue about comp.el being unloadable in builds without native
>> compilation remains (and hence test-custom-deps still fails).
>
> I didn't know about the test-custom-deps, I'll have a look.
Hi Glenn,
with 40c71e574a comp-cstr.el and comp.el are loadable for me also on
vanilla builds, please have a look.
Thanks
Andrea
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#48021: comp.el cannot be loaded without native compilation
2021-04-26 21:16 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-04-27 4:56 ` Glenn Morris
2021-04-29 18:44 ` Glenn Morris
0 siblings, 1 reply; 9+ messages in thread
From: Glenn Morris @ 2021-04-27 4:56 UTC (permalink / raw)
To: Andrea Corallo; +Cc: 48021
Andrea Corallo wrote:
>>> Thanks. comp-cstr-test-70 is still failing for me.
>>
>> Could you share the invocation you are using? I'm asking cause here on
>> 449045b2a6 I see this passing.
On CentOS 8.3 with gcc 8.3, I get:
Test comp-cstr-test-70 condition:
(ert-test-failed
((should
(equal
(comp-cstr-test-ts ...)
'...))
:form
(equal
(not
(member b a))
(not
(member a b)))
There is an identical failure on the very different system
https://hydra.nixos.org/build/142153876
> with 40c71e574a comp-cstr.el and comp.el are loadable for me also on
> vanilla builds, please have a look.
Works for me, thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#48021: comp.el cannot be loaded without native compilation
2021-04-27 4:56 ` Glenn Morris
@ 2021-04-29 18:44 ` Glenn Morris
2021-04-29 19:08 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 9+ messages in thread
From: Glenn Morris @ 2021-04-29 18:44 UTC (permalink / raw)
To: Andrea Corallo; +Cc: 48021
>>>> Thanks. comp-cstr-test-70 is still failing for me.
>>>
>>> Could you share the invocation you are using? I'm asking cause here on
>>> 449045b2a6 I see this passing.
>
> On CentOS 8.3 with gcc 8.3, I get:
>
> Test comp-cstr-test-70 condition:
> (ert-test-failed
> ((should
> (equal
> (comp-cstr-test-ts ...)
> '...))
> :form
> (equal
> (not
> (member b a))
> (not
> (member a b)))
>
> There is an identical failure on the very different system
> https://hydra.nixos.org/build/142153876
Same failure on Debian testing.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#48021: comp.el cannot be loaded without native compilation
2021-04-29 18:44 ` Glenn Morris
@ 2021-04-29 19:08 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-29 23:40 ` Glenn Morris
0 siblings, 1 reply; 9+ messages in thread
From: Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2021-04-29 19:08 UTC (permalink / raw)
To: Glenn Morris; +Cc: 48021
Glenn Morris <rgm@gnu.org> writes:
>>>>> Thanks. comp-cstr-test-70 is still failing for me.
>>>>
>>>> Could you share the invocation you are using? I'm asking cause here on
>>>> 449045b2a6 I see this passing.
>>
>> On CentOS 8.3 with gcc 8.3, I get:
>>
>> Test comp-cstr-test-70 condition:
>> (ert-test-failed
>> ((should
>> (equal
>> (comp-cstr-test-ts ...)
>> '...))
>> :form
>> (equal
>> (not
>> (member b a))
>> (not
>> (member a b)))
>>
>> There is an identical failure on the very different system
>> https://hydra.nixos.org/build/142153876
>
> Same failure on Debian testing.
Hi Glenn,
39ebc2689b should fix this, please have a look.
Thanks
Andrea
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#48021: comp.el cannot be loaded without native compilation
2021-04-29 19:08 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2021-04-29 23:40 ` Glenn Morris
0 siblings, 0 replies; 9+ messages in thread
From: Glenn Morris @ 2021-04-29 23:40 UTC (permalink / raw)
To: Andrea Corallo; +Cc: 48021
Andrea Corallo wrote:
> 39ebc2689b should fix this, please have a look.
Works for me, thanks for the fix.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-04-29 23:40 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-26 0:43 bug#48021: comp.el cannot be loaded without native compilation Glenn Morris
2021-04-26 14:55 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-26 19:18 ` Glenn Morris
2021-04-26 20:29 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-26 21:16 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-27 4:56 ` Glenn Morris
2021-04-29 18:44 ` Glenn Morris
2021-04-29 19:08 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-04-29 23:40 ` Glenn Morris
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).