bug#68157: 30.0.50; Size of selected font is wrong

bug#68157: 30.0.50; Size of selected font is wrong

[Arash Esbati]

Hi all,

I didn't bisect this, but when I select another font than the standard
one, the size is wrong.  To reproduce:

  • emacs -Q
  • In scratch, enter 'o', put point on it and enter 'C-u C-x ='.  I see
      mac-ct:-*-Menlo-regular-normal-normal-*-12-*-*-*-m-0-iso10646-1 (#x52)
  • Now choose a new font from 'Options -> Set Default Font', I took
    'Source Code Pro' at 11pt.  Going back to 'o', I now get:
      mac-ct:-*-Menlo-regular-normal-normal-*-22-*-*-*-m-0-iso10646-1 (#x52)
  • Choose another font, I took 'Courier New' at 10pt, I get:
      mac-ct:-*-Courier New-regular-normal-normal-*-20-*-*-*-m-0-iso10646-1 (#x52)

Can others reproduce this?  I didn't have any issues like this until
now.  This means that my setting:

  (custom-set-faces
   '(default ((t (:family "Source Code Pro" :foundry "nil"
                  :slant normal :weight medium :height 110 :width normal)))))

works no more.

Best, Arash

In GNU Emacs 30.0.50 (build 1, aarch64-apple-darwin23.2.0, NS
 appkit-2487.30 Version 14.2.1 (Build 23C71)) of 2023-12-30 built on
 MacMutant.fritz.box
Repository revision: fc8a20f79274a2e533722f636cb538d7f8fb5427
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2487
System Description:  macOS 14.2.1

Configured using:
 'configure --with-ns --without-pop --without-mailutils --with-threads
 --with-modules --with-native-compilation --without-compress-install
 'CFLAGS=-O2 -g0 -pipe'
 'CPPFLAGS=-I/opt/homebrew/Cellar/gcc/13.2.0/include
 -I/opt/homebrew/Cellar/libgccjit/13.2.0/include
 -I/opt/homebrew/Cellar/gmp/6.3.0/include'
 'LDFLAGS=-L/opt/homebrew/Cellar/gcc/13.2.0/lib/gcc/current
 -L/opt/homebrew/Cellar/gmp/6.3.0/lib''

Configured features:
ACL GLIB GMP GNUTLS JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY KQUEUE
NS PDUMPER PNG RSVG SQLITE3 THREADS TOOLKIT_SCROLL_BARS TREE_SITTER WEBP
XIM ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

bug#68157: 30.0.50; Size of selected font is wrong

[Stefan Kangas]

Arash Esbati <arash@gnu.org> writes:

> I didn't bisect this, but when I select another font than the standard
> one, the size is wrong.

Could you please explain how the size is wrong?
What do you expect and what happens?

Also, does `C-x C-M-0 +' work?

bug#68157: 30.0.50; Size of selected font is wrong

[Arash Esbati]

Stefan Kangas <stefankangas@gmail.com> writes:

> Could you please explain how the size is wrong?

The size of the font selected is way too large:

  • I select 'Source Code Pro' at 11pt and get 22pt[1]:
      mac-ct:-*-Source Code Pro-regular-normal-normal-*-22-*-*-*-m-0-iso10646-1 (#x01)
  • I select 'Courier New' at 10pt and get 20pt:
      mac-ct:-*-Courier New-regular-normal-normal-*-20-*-*-*-m-0-iso10646-1 (#x52)

I had this in my custom file:

  (custom-set-faces
   '(default ((t (:family "Source Code Pro" :foundry "nil" :slant normal
                  :weight medium :height 110 :width normal))))

which now gives a huge font.  I had to turn it into:

  (custom-set-faces
   '(default ((t (:family "Source Code Pro" :foundry "nil" :slant normal
                  :weight medium :height 55 :width normal))))

in order to get back to normal state with:

  mac-ct:-*-Source Code Pro-medium-normal-normal-*-11-*-*-*-m-0-iso10646-1 (#x29)

> Also, does `C-x C-M-0 +' work?

Yes, but the baseline is the large font size as described above.

Best, Arash

Footnotes:
[1]  I pasted the wrong snippet in my last message; sorry.

bug#68157: 30.0.50; Size of selected font is wrong

[Alan Third]

On Sat, Dec 30, 2023 at 10:49:15PM +0100, Arash Esbati wrote:
> Hi all,
> 
> I didn't bisect this, but when I select another font than the standard
> one, the size is wrong.  To reproduce:
> 
>   • emacs -Q
>   • In scratch, enter 'o', put point on it and enter 'C-u C-x ='.  I see
>       mac-ct:-*-Menlo-regular-normal-normal-*-12-*-*-*-m-0-iso10646-1 (#x52)
>   • Now choose a new font from 'Options -> Set Default Font', I took
>     'Source Code Pro' at 11pt.  Going back to 'o', I now get:
>       mac-ct:-*-Menlo-regular-normal-normal-*-22-*-*-*-m-0-iso10646-1 (#x52)
>   • Choose another font, I took 'Courier New' at 10pt, I get:
>       mac-ct:-*-Courier New-regular-normal-normal-*-20-*-*-*-m-0-iso10646-1 (#x52)
> 
> Can others reproduce this?  I didn't have any issues like this until
> now.  This means that my setting:
> 
>   (custom-set-faces
>    '(default ((t (:family "Source Code Pro" :foundry "nil"
>                   :slant normal :weight medium :height 110 :width normal)))))
> 
> works no more.

Can you please try reverting change f3dec3439fd5aee885a76622f384f6c7ca67d128?

-- 
Alan Third

bug#68157: 30.0.50; Size of selected font is wrong

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Alan Third <alan@idiocy.org> writes:

> Can you please try reverting change
> f3dec3439fd5aee885a76622f384f6c7ca67d128?

If this commit produced a change in the values of resx and resy, it is
the likely culprit.  On window systems which scale graphics operations
to match the display density, resx and resy should NOT be set to that
density, but rather the density the window system expects graphics
operations to be issued while assuming.

bug#68157: 30.0.50; Size of selected font is wrong

[Arash Esbati]

Alan Third <alan@idiocy.org> writes:

> Can you please try reverting change f3dec3439fd5aee885a76622f384f6c7ca67d128?

Thanks, reverting that change fixes the issue.

Best, Arash

bug#68157: 30.0.50; Size of selected font is wrong

[Alan Third]

On Sun, Dec 31, 2023 at 09:16:55AM +0800, Po Lu wrote:
> Alan Third <alan@idiocy.org> writes:
> 
> > Can you please try reverting change
> > f3dec3439fd5aee885a76622f384f6c7ca67d128?
> 
> If this commit produced a change in the values of resx and resy, it is
> the likely culprit.

It didn't in my testing.

> On window systems which scale graphics operations
> to match the display density, resx and resy should NOT be set to that
> density, but rather the density the window system expects graphics
> operations to be issued while assuming.

Indeed.
-- 
Alan Third

bug#68157: 30.0.50; Size of selected font is wrong

[Alan Third]

On Sun, Dec 31, 2023 at 09:34:31AM +0100, Arash Esbati wrote:
> Alan Third <alan@idiocy.org> writes:
> 
> > Can you please try reverting change f3dec3439fd5aee885a76622f384f6c7ca67d128?
> 
> Thanks, reverting that change fixes the issue.

Thanks. I've reverted the change on master now and am closing the bug
report.

-- 
Alan Third