unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* fix for configure.in
@ 2003-04-10 13:18 Dave Love
  2003-04-10 13:54 ` Andreas Schwab
  0 siblings, 1 reply; 8+ messages in thread
From: Dave Love @ 2003-04-10 13:18 UTC (permalink / raw)


I understand there's going to be a bug-fix version of 21.3.  This
fixes the check for libjpeg under Irix with the proprietary cc, for
instance.  Sorry I didn't spot it before, and I guess Irix isn't
getting other useful testing.

(The CVS head code is OK since I re-wrote that bit for autoconf 2.5x.)

2003-04-09  Dave Love  <fx@gnu.org>

	* configure.in: Fix test of jpeglib.h to avoid leading space.

cd /net/pxfs5/home/fx/packages/emacs-21.3/
diff -c /net/pxfs5/home/fx/packages/emacs-21.3/configure.in\~ /net/pxfs5/home/fx/packages/emacs-21.3/configure.in
*** /net/pxfs5/home/fx/packages/emacs-21.3/configure.in~	Sun Mar 16 22:06:05 2003
--- /net/pxfs5/home/fx/packages/emacs-21.3/configure.in	Wed Apr  9 15:32:49 2003
***************
*** 1879,1889 ****
    if test "${HAVE_JPEG}" = "yes"; then
      AC_DEFINE(HAVE_JPEG)
      AC_EGREP_CPP(
! changequote({, })dnl avoid leadingspace on the next line
  {version= *(6[2-9]|[7-9][0-9])},
  changequote([, ])dnl
!         [#include <jpeglib.h>
! 	 version=JPEG_LIB_VERSION
  ],    
          AC_DEFINE(HAVE_JPEG),
          [AC_MSG_WARN([libjpeg found, but not version 6b or later])
--- 1879,1889 ----
    if test "${HAVE_JPEG}" = "yes"; then
      AC_DEFINE(HAVE_JPEG)
      AC_EGREP_CPP(
! changequote({, })dnl avoid leading space on the next line
  {version= *(6[2-9]|[7-9][0-9])},
  changequote([, ])dnl
! [#include <jpeglib.h>
! version=JPEG_LIB_VERSION
  ],    
          AC_DEFINE(HAVE_JPEG),
          [AC_MSG_WARN([libjpeg found, but not version 6b or later])

Diff finished at Wed Apr  9 15:33:30

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: fix for configure.in
  2003-04-10 13:18 fix for configure.in Dave Love
@ 2003-04-10 13:54 ` Andreas Schwab
  2003-04-11 10:30   ` Dave Love
  2003-04-11 13:27   ` Andreas Schwab
  0 siblings, 2 replies; 8+ messages in thread
From: Andreas Schwab @ 2003-04-10 13:54 UTC (permalink / raw)
  Cc: bug-gnu-emacs

Dave Love <d.love@dl.ac.uk> writes:

|> I understand there's going to be a bug-fix version of 21.3.  This
|> fixes the check for libjpeg under Irix with the proprietary cc, for
|> instance.

Thanks, this is already fixed in CVS.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: fix for configure.in
  2003-04-10 13:54 ` Andreas Schwab
@ 2003-04-11 10:30   ` Dave Love
  2003-04-11 13:25     ` Andreas Schwab
  2003-04-11 13:27   ` Andreas Schwab
  1 sibling, 1 reply; 8+ messages in thread
From: Dave Love @ 2003-04-11 10:30 UTC (permalink / raw)
  Cc: bug-gnu-emacs

Andreas Schwab <schwab@suse.de> writes:

> Thanks, this is already fixed in CVS.

There should be a ChangeLog entry for it, which would have saved me
some time.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: fix for configure.in
  2003-04-11 10:30   ` Dave Love
@ 2003-04-11 13:25     ` Andreas Schwab
  2003-04-12 17:07       ` Richard Stallman
  0 siblings, 1 reply; 8+ messages in thread
From: Andreas Schwab @ 2003-04-11 13:25 UTC (permalink / raw)
  Cc: bug-gnu-emacs

Dave Love <d.love@dl.ac.uk> writes:

|> Andreas Schwab <schwab@suse.de> writes:
|> 
|> > Thanks, this is already fixed in CVS.
|> 
|> There should be a ChangeLog entry for it, which would have saved me
|> some time.

There is.

2003-04-07  Andreas Schwab  <schwab@suse.de>

	* configure.in: Avoid whitespace before preprocessor directive.
	* configure: Rebuild.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: fix for configure.in
  2003-04-10 13:54 ` Andreas Schwab
  2003-04-11 10:30   ` Dave Love
@ 2003-04-11 13:27   ` Andreas Schwab
  1 sibling, 0 replies; 8+ messages in thread
From: Andreas Schwab @ 2003-04-11 13:27 UTC (permalink / raw)
  Cc: bug-gnu-emacs

Andreas Schwab <schwab@suse.de> writes:

|> Dave Love <d.love@dl.ac.uk> writes:
|> 
|> |> I understand there's going to be a bug-fix version of 21.3.  This
|> |> fixes the check for libjpeg under Irix with the proprietary cc, for
|> |> instance.
|> 
|> Thanks, this is already fixed in CVS.

I apologize, I just noticed I forgot to check it in.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: fix for configure.in
  2003-04-11 13:25     ` Andreas Schwab
@ 2003-04-12 17:07       ` Richard Stallman
  2003-04-14 14:25         ` Andreas Schwab
  0 siblings, 1 reply; 8+ messages in thread
From: Richard Stallman @ 2003-04-12 17:07 UTC (permalink / raw)
  Cc: bug-gnu-emacs

Here's the change log entry for the change I already installed.

2003-04-08  Richard M. Stallman  <rms@gnu.org>

	* configure.in: Put #include of jpeglib.h at start of line.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: fix for configure.in
  2003-04-12 17:07       ` Richard Stallman
@ 2003-04-14 14:25         ` Andreas Schwab
  2003-04-15 22:28           ` Dave Love
  0 siblings, 1 reply; 8+ messages in thread
From: Andreas Schwab @ 2003-04-14 14:25 UTC (permalink / raw)
  Cc: bug-gnu-emacs

Richard Stallman <rms@gnu.org> writes:

|> Here's the change log entry for the change I already installed.
|> 
|> 2003-04-08  Richard M. Stallman  <rms@gnu.org>
|> 
|> 	* configure.in: Put #include of jpeglib.h at start of line.

Actually mainline was already safe, but it won't hurt either.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: fix for configure.in
  2003-04-14 14:25         ` Andreas Schwab
@ 2003-04-15 22:28           ` Dave Love
  0 siblings, 0 replies; 8+ messages in thread
From: Dave Love @ 2003-04-15 22:28 UTC (permalink / raw)
  Cc: bug-gnu-emacs

Andreas Schwab <schwab@suse.de> writes:

> Actually mainline was already safe, but it won't hurt either.

As I replied to rms, it hurts from a maintenance point of view.  You
see it and it makes no sense, especially in the context of surrounding
cases which haven't been changed.  If you want to modify it for some
reason, you have to decide whether it's bogus or there's something
else you don't understand.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2003-04-15 22:28 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-04-10 13:18 fix for configure.in Dave Love
2003-04-10 13:54 ` Andreas Schwab
2003-04-11 10:30   ` Dave Love
2003-04-11 13:25     ` Andreas Schwab
2003-04-12 17:07       ` Richard Stallman
2003-04-14 14:25         ` Andreas Schwab
2003-04-15 22:28           ` Dave Love
2003-04-11 13:27   ` Andreas Schwab

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).