unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#12787: Toolbar regression from Emacs 23 to Emacs 24 -- Save As and Help no longer available
@ 2012-11-02 17:29 jxa127
  2012-11-02 18:15 ` Glenn Morris
                   ` (6 more replies)
  0 siblings, 7 replies; 13+ messages in thread
From: jxa127 @ 2012-11-02 17:29 UTC (permalink / raw)
  To: 12787; +Cc: jxa127

The "Save As" and "Help" buttons from the tool bar are no longer available in Emacs 24. This change was not identified in the News.

My attempts to replace them fail.

I make the following changes in tool-bar.el:
-------------------------------------------------------------- 
(defun tool-bar-setup ()
  (setq tool-bar-separator-image-expression
    (tool-bar--image-expression "separator"))
(tool-bar-add-item-from-menu 'find-file "new" nil :label "New File"
     :vert-only t)
(tool-bar-add-item-from-menu 'menu-find-file-existing "open" nil
     :label "Open" :vert-only t)
(tool-bar-add-item-from-menu 'dired "diropen" nil :vert-only t)
(tool-bar-add-item-from-menu 'kill-this-buffer "close" nil :vert-only t)
(tool-bar-add-item-from-menu 'save-buffer "save" nil
     :label "Save")

 
;; ---> I add the ?Save As? button here:
(tool-bar-add-item-from-menu 'write-file "saveas" nil
     :label "Save as")

 
(define-key-after (default-value 'tool-bar-map) [separator-1] menu-bar-separator)
(tool-bar-add-item-from-menu 'undo "undo" nil)
(define-key-after (default-value 'tool-bar-map) [separator-2] menu-bar-separator)
(tool-bar-add-item-from-menu (lookup-key menu-bar-edit-menu [cut])
     "cut" nil :vert-only t)
(tool-bar-add-item-from-menu (lookup-key menu-bar-edit-menu [copy])
     "copy" nil :vert-only t)
(tool-bar-add-item-from-menu (lookup-key menu-bar-edit-menu [paste])
     "paste" nil :vert-only t)
(define-key-after (default-value 'tool-bar-map) [separator-3] menu-bar-separator)
(tool-bar-add-item-from-menu 'isearch-forward "search"
     nil :label "Search" :vert-only t)
;;(tool-bar-add-item-from-menu 'ispell-buffer "spell")
;; There's no icon appropriate for News and we need a command rather
;; than a lambda for Read Mail.
;;(tool-bar-add-item-from-menu 'compose-mail "mail/compose")

 
;; ---> I uncomment the help button here:
;; Help button on a tool bar is rather non-standard...
(let ((tool-bar-map (default-value 'tool-bar-map)))
     (tool-bar-add-item "help" (lambda ()
     (interactive)
     (popup-menu menu-bar-help-menu))
          'help
         :help "Pop up the Help menu"))
)
-------------------------------------------------------------- 
I save tool-bar.el, compile it to tool-bar.elc and then restart Emacs, but the buttons are not there.

 
I can evaluate portions of tool-bar.el to make the button appear during one session, but they will not appear at start-up.

 
Thank you,

 
Drew Ames





^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2012-11-24 21:04 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-02 17:29 bug#12787: Toolbar regression from Emacs 23 to Emacs 24 -- Save As and Help no longer available jxa127
2012-11-02 18:15 ` Glenn Morris
2012-11-02 19:15 ` bug#12787: " jxa127
2012-11-02 20:00   ` Eli Zaretskii
2012-11-02 20:21     ` bug#12787: Re: bug#12787: Toolbar regression from Emacs 23 to Emacs24 " Drew Adams
2012-11-02 19:33 ` bug#12787: Toolbar regression from Emacs 23 to Emacs 24 " Glenn Morris
2012-11-02 20:15 ` bug#12787: " jxa127
2012-11-02 20:27   ` bug#12787: Re: bug#12787: Toolbar regression from Emacs 23 to Emacs24 " Drew Adams
2012-11-02 22:13   ` bug#12787: Toolbar regression from Emacs 23 to Emacs 24 " Glenn Morris
2012-11-24 18:50     ` Glenn Morris
2012-11-02 20:24 ` bug#12787: Re: bug#12787: " jxa127
2012-11-02 20:48 ` bug#12787: RE: bug#12787: Re: bug#12787: Toolbar regression from Emacs 23 to Emacs24 " jxa127
     [not found] ` <handler.12787.D12787.135378310910029.notifdone@debbugs.gnu.org>
2012-11-24 21:04   ` bug#12787: closed (Re: bug#12787: Toolbar regression from Emacs 23 to Emacs 24 -- Save As and Help no longer available) Drew Ames

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).