From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#17393: 24.4.50; [PATCH] diary Chinese support Date: Sat, 03 May 2014 14:39:21 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1399142421 12480 80.91.229.3 (3 May 2014 18:40:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 3 May 2014 18:40:21 +0000 (UTC) Cc: 17393@debbugs.gnu.org, William Xu To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 03 20:40:14 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wger4-0006XB-GJ for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 May 2014 20:40:10 +0200 Original-Received: from localhost ([::1]:49819 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wger3-0002uH-Su for geb-bug-gnu-emacs@m.gmane.org; Sat, 03 May 2014 14:40:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wgeqz-0002ri-TX for bug-gnu-emacs@gnu.org; Sat, 03 May 2014 14:40:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wgeqx-0006BE-9y for bug-gnu-emacs@gnu.org; Sat, 03 May 2014 14:40:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60814) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wgeqx-0006As-7O for bug-gnu-emacs@gnu.org; Sat, 03 May 2014 14:40:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Wgeqw-0001AI-R4 for bug-gnu-emacs@gnu.org; Sat, 03 May 2014 14:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 May 2014 18:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17393 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 17393-submit@debbugs.gnu.org id=B17393.13991423674429 (code B ref 17393); Sat, 03 May 2014 18:40:02 +0000 Original-Received: (at 17393) by debbugs.gnu.org; 3 May 2014 18:39:27 +0000 Original-Received: from localhost ([127.0.0.1]:49932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgeqM-00019L-CW for submit@debbugs.gnu.org; Sat, 03 May 2014 14:39:26 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:45975 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WgeqI-00019A-JK for 17393@debbugs.gnu.org; Sat, 03 May 2014 14:39:23 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WgeqH-000523-PY; Sat, 03 May 2014 14:39:21 -0400 X-Spook: Commecen codes AVN bluebird illuminati world domination X-Ran: Lc!OmreeLR30[9hhu~1U%Y5Lvp!_]!k\6X,EWz?NFA?$xDlH]J0ynT=DA+e]2E$"nL;f=8 X-Hue: blue X-Attribution: GM In-Reply-To: (Leo Liu's message of "Sat, 03 May 2014 12:25:49 +0800") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:88599 Archived-At: Thanks. Please apply, with the necessary doc and NEWS updates. Very minor comments below. Leo Liu wrote: > +(declare-function calendar-mark-1 "diary-lib") > +(declare-function diary-mark-entries-1 "diary-lib") > +(declare-function diary-list-entries-1 "diary-lib") > +(declare-function diary-insert-entry-1 "diary-lib") > +(declare-function diary-date-display-form "diary-lib") The existing files use autoload. > +(declare-function diary-anniversary "diary-lib") Unused? > +Chinese date diary entries must be prefaced by `diary-chinese-entry-symbol' > +\(normally an `C'). "a `C'". > +;;;###cal-autoload > +(defun diary-chinese-anniversary (month day &optional year mark) Doc string please. > +(defcustom diary-chinese-entry-symbol "C" > + "Symbol indicating a diary entry according to the Chinese calendar." > + :type 'string > + :group 'diary) :version tag.