From: Glenn Morris <rgm@gnu.org>
To: Leo Liu <sdl.web@gmail.com>
Cc: 17393@debbugs.gnu.org, William Xu <william.xwl@gmail.com>
Subject: bug#17393: 24.4.50; [PATCH] diary Chinese support
Date: Sat, 03 May 2014 14:39:21 -0400 [thread overview]
Message-ID: <rflhui906e.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <m3tx97h4j6.fsf@gmail.com> (Leo Liu's message of "Sat, 03 May 2014 12:25:49 +0800")
Thanks. Please apply, with the necessary doc and NEWS updates.
Very minor comments below.
Leo Liu wrote:
> +(declare-function calendar-mark-1 "diary-lib")
> +(declare-function diary-mark-entries-1 "diary-lib")
> +(declare-function diary-list-entries-1 "diary-lib")
> +(declare-function diary-insert-entry-1 "diary-lib")
> +(declare-function diary-date-display-form "diary-lib")
The existing files use autoload.
> +(declare-function diary-anniversary "diary-lib")
Unused?
> +Chinese date diary entries must be prefaced by `diary-chinese-entry-symbol'
> +\(normally an `C').
"a `C'".
> +;;;###cal-autoload
> +(defun diary-chinese-anniversary (month day &optional year mark)
Doc string please.
> +(defcustom diary-chinese-entry-symbol "C"
> + "Symbol indicating a diary entry according to the Chinese calendar."
> + :type 'string
> + :group 'diary)
:version tag.
next prev parent reply other threads:[~2014-05-03 18:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-03 4:25 bug#17393: 24.4.50; [PATCH] diary Chinese support Leo Liu
2014-05-03 18:39 ` Glenn Morris [this message]
2014-05-04 0:26 ` Leo Liu
2014-05-04 4:15 ` Stefan Monnier
2014-05-04 4:23 ` Leo Liu
2014-05-04 18:09 ` Glenn Morris
2014-05-04 23:42 ` Leo Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=rflhui906e.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=17393@debbugs.gnu.org \
--cc=sdl.web@gmail.com \
--cc=william.xwl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).