From: Daniel Colascione <dancol@dancol.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 25965@debbugs.gnu.org, Andreas Politz <politza@hochschule-trier.de>
Subject: bug#25965: 26.0.50; iter-lambda may evaluate certain forms twice
Date: Wed, 08 Mar 2017 14:08:07 -0800 [thread overview]
Message-ID: <r0251su7toag.fsf@dancol.org> (raw)
In-Reply-To: <jwv1su74ezy.fsf-monnier+bug#25965@gnu.org> (Stefan Monnier's message of "Wed, 08 Mar 2017 16:52:13 -0500")
On Wed, Mar 08 2017, Stefan Monnier wrote:
>> The unwind-protect form is created in this function.
>>
>> #+BEGIN_SRC emacs-lisp
>> (defun cps--make-dynamic-binding-wrapper (dynamic-var static-var)
>> (cl-assert lexical-binding)
>> (lambda (form)
>> `(let ((,dynamic-var ,static-var))
>> (unwind-protect ; Update the static shadow after evaluation is done
>> ,form
>> (setf ,static-var ,dynamic-var))
>> ,form)))
>> #+END_SRC
>>
>> And it seems to me that the second occurrence of ,form is just an
>> error.
>
> Hmm... indeed that looks odd, and maybe just removing the second ,form
> is the right fix. Daniel, do you happen to remember what the second
> ,form above is meant to do?
Embarrass me years later? :-) I think it's safe to remove it. Let's make
sure to add a test too.
next prev parent reply other threads:[~2017-03-08 22:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-04 8:02 bug#25965: 26.0.50; iter-lambda may evaluate certain forms twice Andreas Politz
2017-03-08 21:52 ` Stefan Monnier
2017-03-08 22:08 ` Daniel Colascione [this message]
2017-09-21 21:36 ` Gemini Lasswell
2017-10-05 19:51 ` Gemini Lasswell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=r0251su7toag.fsf@dancol.org \
--to=dancol@dancol.org \
--cc=25965@debbugs.gnu.org \
--cc=monnier@IRO.UMontreal.CA \
--cc=politza@hochschule-trier.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).