unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#15235: 24.3.50; package.el updates load-path too late
@ 2013-09-01 16:45 Richard Kim
       [not found] ` <handler.15235.B.137805399020499.ack@debbugs.gnu.org>
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Richard Kim @ 2013-09-01 16:45 UTC (permalink / raw)
  To: 15235

A recent change made on bzr trunk is causing one of my ELPA packages to
fail to load due to `load-path' not being updated promptly.

The change in question seems to be Stefan's revision 114047 checked in
on Aug 28, 2013 with check in comment

    Don't add unnecessarily to load-path.

The package in question is icicles which I created by putting together a
few files from emacswiki.org which I have been using for several years.

The problem is that icicles-autoloads.el refers to some custom face
which is provided by icicles-face.el in the icicles package directory.
However Stefan's change now evaluates icicles-autoloads.el first then
updates load-path to add path for icicles.  Following shows
`package-activate-1' from around August 24:

    (defun package-activate-1 (pkg-desc)
      (let* ((name (package-desc-name pkg-desc))
    	 (pkg-dir (package-desc-dir pkg-desc)))
        (unless pkg-dir
          (error "Internal error: unable to find directory for `%s'"
    	     (package-desc-full-name pkg-desc)))
        ;; Add info node.
        (when (file-exists-p (expand-file-name "dir" pkg-dir))
          ;; FIXME: not the friendliest, but simple.
          (require 'info)
          (info-initialize)
          (push pkg-dir Info-directory-list))
        ;; Add to load path, add autoloads, and activate the package.
        (push pkg-dir load-path)
        (load (expand-file-name (format "%s-autoloads" name) pkg-dir) nil t)
        (push name package-activated-list)
        ;; Don't return nil.
        t))

Note that (load) of the "-autolads" file comes after updating of
load-path, i.e., (push pkg-dir load-path).  Thus icicles-face.el can be
found in this version of package.el.

Shouldn't load-path updated first for the packge being intialized so
that code in "*-autoloads.el" can load other elisp files in the package
directory?





^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-06-02 17:09 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-01 16:45 bug#15235: 24.3.50; package.el updates load-path too late Richard Kim
     [not found] ` <handler.15235.B.137805399020499.ack@debbugs.gnu.org>
2013-09-01 22:45   ` bug#15235: Acknowledgement (24.3.50; package.el updates load-path too late) Richard Kim
2013-09-03  2:16     ` Stefan Monnier
2013-09-03  1:50 ` bug#15235: 24.3.50; package.el updates load-path too late Stefan Monnier
2016-06-02 17:09 ` Noam Postavsky

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).