From: Glenn Morris <rgm@gnu.org>
To: 25959@debbugs.gnu.org
Subject: bug#25959: No stop button in gdb toolbar
Date: Fri, 03 Mar 2017 17:35:06 -0500 [thread overview]
Message-ID: <qtmvd27zvp.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <lobmti9hjo.fsf@fencepost.gnu.org> (Glenn Morris's message of "Fri, 03 Mar 2017 16:28:11 -0500")
Glenn Morris wrote:
> emacs -Q -f gdb
> gdb -i=mi a.out RET
>
> Choose "Go" button in toolbar, program starts running, "Go" disappears.
> Now there should be a "Stop" button, but there isn't.
>
> gdb-show-stop-p returns nil because gdb-running-threads-count is 0.
>
> It works in 24.3, and fails in 24.4 through to current master.
Reverting 2e78e6a fixes this for me, so I've cc'd the author of that change.
commit 2e78e6a
Author: Jean-Philippe Gravel <jpgravel@gmail.com>
Date: Tue May 14 14:34:13 2013 -0400
* progmodes/gdb-mi.el (gdb-running, gdb-starting): Remove
signals for which replies are never received.
diff --git a/lisp/progmodes/gdb-mi.el b/lisp/progmodes/gdb-mi.el
index 2799eec..a6ad573 100644
--- a/lisp/progmodes/gdb-mi.el
+++ b/lisp/progmodes/gdb-mi.el
@@ -2376,8 +2376,7 @@ gdb-running
(propertize gdb-inferior-status 'face font-lock-type-face))
(when (not gdb-non-stop)
(setq gud-running t))
- (setq gdb-active-process t)
- (gdb-emit-signal gdb-buf-publisher 'update-threads))
+ (setq gdb-active-process t))
(defun gdb-starting (_output-field _result)
;; CLI commands don't emit ^running at the moment so use gdb-running too.
@@ -2385,11 +2384,7 @@ gdb-starting
(gdb-force-mode-line-update
(propertize gdb-inferior-status 'face font-lock-type-face))
(setq gdb-active-process t)
- (setq gud-running t)
- ;; GDB doesn't seem to respond to -thread-info before first stop or
- ;; thread exit (even in non-stop mode), so this is useless.
- ;; Behavior may change in the future.
- (gdb-emit-signal gdb-buf-publisher 'update-threads))
+ (setq gud-running t))
;; -break-insert -t didn't give a reason before gdb 6.9
next prev parent reply other threads:[~2017-03-03 22:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 21:28 bug#25959: No stop button in gdb toolbar Glenn Morris
2017-03-03 22:35 ` Glenn Morris [this message]
2017-03-04 8:54 ` Eli Zaretskii
2017-03-06 0:00 ` Glenn Morris
2017-03-06 3:38 ` Eli Zaretskii
2017-03-06 18:01 ` Glenn Morris
2017-03-06 18:53 ` Eli Zaretskii
2017-03-06 19:41 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=qtmvd27zvp.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=25959@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).