From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark Lillibridge Newsgroups: gmane.emacs.bugs Subject: bug#7743: unrmail loses extra blank line at end of message Date: Mon, 27 Dec 2010 11:54:10 -0800 Message-ID: Reply-To: mark.lillibridge@hp.com NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1293481429 19768 80.91.229.12 (27 Dec 2010 20:23:49 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 27 Dec 2010 20:23:49 +0000 (UTC) To: 7743@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 27 21:23:45 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PXJbc-0005Md-M2 for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Dec 2010 21:23:45 +0100 Original-Received: from localhost ([127.0.0.1]:43468 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PXJbb-00075o-Up for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Dec 2010 15:23:43 -0500 Original-Received: from [140.186.70.92] (port=46552 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PXJbI-0006wm-Dz for bug-gnu-emacs@gnu.org; Mon, 27 Dec 2010 15:23:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PXJbH-0003LY-5N for bug-gnu-emacs@gnu.org; Mon, 27 Dec 2010 15:23:24 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53276) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PXJbH-0003LT-3t for bug-gnu-emacs@gnu.org; Mon, 27 Dec 2010 15:23:23 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PXJ34-0000U7-Gs; Mon, 27 Dec 2010 14:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mark Lillibridge Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Dec 2010 19:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 7743 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.12934792551822 (code B ref -1); Mon, 27 Dec 2010 19:48:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 27 Dec 2010 19:47:35 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PXJ2c-0000TL-KK for submit@debbugs.gnu.org; Mon, 27 Dec 2010 14:47:34 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PXJ2Z-0000T9-Ui for submit@debbugs.gnu.org; Mon, 27 Dec 2010 14:47:32 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PXJ99-0007BY-HE for submit@debbugs.gnu.org; Mon, 27 Dec 2010 14:54:20 -0500 Original-Received: from lists.gnu.org ([199.232.76.165]:47896) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PXJ99-0007BU-FH for submit@debbugs.gnu.org; Mon, 27 Dec 2010 14:54:19 -0500 Original-Received: from [140.186.70.92] (port=52994 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PXJ98-0002NW-GI for bug-gnu-emacs@gnu.org; Mon, 27 Dec 2010 14:54:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PXJ97-0007B9-Hv for bug-gnu-emacs@gnu.org; Mon, 27 Dec 2010 14:54:18 -0500 Original-Received: from gundega.hpl.hp.com ([192.6.19.190]:39732) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PXJ97-0007B2-63 for bug-gnu-emacs@gnu.org; Mon, 27 Dec 2010 14:54:17 -0500 Original-Received: from mailhub-pa1.hpl.hp.com (mailhub-pa1.hpl.hp.com [15.25.115.25]) by gundega.hpl.hp.com (8.14.3/8.14.3/HPL-PA Relay) with ESMTP id oBRJsCSv029421 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Mon, 27 Dec 2010 11:54:12 -0800 Original-Received: from ts-rhel5 (ts-rhel5.hpl.hp.com [15.25.118.27]) by mailhub-pa1.hpl.hp.com (8.14.3/8.14.3/HPL-PA Hub) with ESMTP id oBRJsAHV001888; Mon, 27 Dec 2010 11:54:11 -0800 X-Scanned-By: MIMEDefang 2.69 on 15.0.48.190 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 27 Dec 2010 14:48:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:42879 Archived-At: As of at least Emacs 23.1 and still present in version 24, unrmail throws away the last blank line of a message if present. The offending code is in unrmail.el: unrmail.el:235: ;; Make sure the message ends with two newlines (goto-char (point-max)) (unless (looking-back "\n\n") (insert "\n")) This is wrong! Mbox format ends every message with a blank line, which is not part of the message, so this code by failing to add the necessary terminator blank line to messages that already end with a blank line effectively removes the last blank line of such messages. The fix is easy: just always add the blank line like so: unrmail.el:235: ;; Add terminator blank line to message (goto-char (point-max)) (insert "\n") - Mark PS, the patch for this change hopefully is: ts-rhel5 [106]% diff original-unrmail.el new-unrmail.el 235c235 < ;; Make sure the message ends with two newlines --- > ;; Add terminator blank line to message 237,238c237 < (unless (looking-back "\n\n") < (insert "\n")) --- > (insert "\n")