From: Mark Lillibridge <mark.lillibridge@hp.com>
To: 9831@debbugs.gnu.org
Subject: bug#9831: narrowing the bug down
Date: Sat, 22 Oct 2011 13:45:05 -0700 [thread overview]
Message-ID: <qmhd3dohi26.fsf@hp.com> (raw)
In-Reply-To: <qmhehy4hjut.fsf@hp.com> (message from Mark Lillibridge on Sat, 22 Oct 2011 13:06:18 -0700)
Some further tracking reveals:
The problem is in rmail-update-summary; rmail-update-summary calls
(indirectly) rmail-summary in the normal unfiltered summary case:
(defun rmail-update-summary (&rest ignore)
(apply (car rmail-summary-redo) (cdr rmail-summary-redo)))
(defun rmail-summary ()
"Display a summary of all messages, one line per message."
(interactive)
(rmail-new-summary "All" '(rmail-summary) nil)
(unless (get-buffer-window rmail-buffer)
(rmail-summary-beginning-of-message)))
Commenting out the last two lines of the above makes the bug go away (at
least for unfiltered summaries):
(defun rmail-summary ()
"Display a summary of all messages, one line per message."
(interactive)
(rmail-new-summary "All" '(rmail-summary) nil)
)
; (unless (get-buffer-window rmail-buffer)
; (rmail-summary-beginning-of-message)))
A bit further tracking shows that the last call is the culprit:
(defun rmail-summary-beginning-of-message ()
"Show current message from the beginning."
(interactive)
(rmail-summary-show-message 'BEG))
(defun rmail-summary-show-message (where)
"Show current mail message.
Position it according to WHERE which can be BEG or END"
(if (and (one-window-p) (not pop-up-frames))
;; If there is just one window, put the summary on the top.
(let ((buffer rmail-buffer))
(split-window (selected-window) rmail-summary-window-size)
(select-window (frame-first-window))
(rmail-pop-to-buffer rmail-buffer)
;; If pop-to-buffer did not use that window, delete that
;; window. (This can happen if it uses another frame.)
(or (eq buffer (window-buffer (next-window (frame-first-window))))
(delete-other-windows)))
(rmail-pop-to-buffer rmail-buffer))
(cond
((eq where 'BEG)
(goto-char (point-min))
(search-forward "\n\n"))
((eq where 'END)
(goto-char (point-max))
(recenter (1- (window-height))))
)
(rmail-pop-to-buffer rmail-summary-buffer))
I'm not sure how to go about fixing this; extra dynamically-bound
variable that stops rmail-update-summary called functions from
displaying the summary in a window?
- Mark
next prev parent reply other threads:[~2011-10-22 20:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-22 11:08 bug#9831: 24.0.90; o and c-o in RMAIL change buffer john ffitch
2011-10-22 20:06 ` bug#9831: narrowing the bug down Mark Lillibridge
2011-10-22 20:45 ` Mark Lillibridge [this message]
2011-10-22 21:26 ` bug#9831: cause of bug found! [PATCH] Mark Lillibridge
2011-10-23 9:19 ` martin rudalics
2011-10-23 20:21 ` Mark Lillibridge
2011-10-24 9:31 ` martin rudalics
2011-10-27 2:53 ` Mark Lillibridge
2011-10-27 9:52 ` martin rudalics
2011-10-27 3:09 ` bug#9831: Your bug report re: o and c-o in RMAIL change buffer Mark Lillibridge
2011-11-14 9:32 ` bug#9831: " Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=qmhd3dohi26.fsf@hp.com \
--to=mark.lillibridge@hp.com \
--cc=9831@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).