From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#74786: [PATCH] Add custom args to test compile step Date: Sun, 15 Dec 2024 02:17:55 +0000 Message-ID: References: <86wmg62pfs.fsf@gnu.org> <87wmg643g4.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11927"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Robert Pluim , Eli Zaretskii , 74786@debbugs.gnu.org To: "O'Brien, Will" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 15 03:19:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tMeE8-0002wB-45 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 15 Dec 2024 03:19:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tMeDt-0002et-68; Sat, 14 Dec 2024 21:19:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMeDn-0002e8-Q1 for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2024 21:19:04 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tMeDn-0001D8-BK for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2024 21:19:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:From:Date:To:Subject; bh=ompwRqZtwKxLTCZ2pC+uc0BexHwFnbxH1QMyfLjzUNg=; b=mR6can6ZMcKo4WUhDod8ePMOUp2A8CTUKX1ednuHvo4YoSElET3YL4bov+dXLSEo6Cl5SFI5KB5xnWCfFKDcBUzJyXmAwNHvgi+oQal7tSohGnH5erYheNZqxJoUqhX1uH4VkF5WaY7/GxZFq4y5QWXnsASfery6+W3Nc7Tku0ex4MvJkC4SxoJdZXWjGsdVyWibGpahppUUmVoEnnBh1ytAifEzQUTohEe7t45MOqflYR09/bLFC2C6SCVrVug0cGp09Skyjlr5JmaRVEHkpPJq0U+XpqmrA+wqzFCebkpy6ILBC2MwNDyPJNizb0NA6gYWtMZYzvtmoiRXNQualg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tMeDm-0006mR-O8 for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2024 21:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Dec 2024 02:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74786 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74786-submit@debbugs.gnu.org id=B74786.173422910425991 (code B ref 74786); Sun, 15 Dec 2024 02:19:02 +0000 Original-Received: (at 74786) by debbugs.gnu.org; 15 Dec 2024 02:18:24 +0000 Original-Received: from localhost ([127.0.0.1]:49016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMeD4-0006ky-88 for submit@debbugs.gnu.org; Sat, 14 Dec 2024 21:18:24 -0500 Original-Received: from mail-4317.proton.ch ([185.70.43.17]:16437) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tMeCs-0006kE-Iz for 74786@debbugs.gnu.org; Sat, 14 Dec 2024 21:18:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail3; t=1734229080; x=1734488280; bh=ompwRqZtwKxLTCZ2pC+uc0BexHwFnbxH1QMyfLjzUNg=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=tyGNYiCundICXd9RCo5p9oFrxmTPBxJ+lKefe7StsP1FlDQqAOyB6ryuRV/o095hb JoDbX2qnPwIDN3o8gT28evf68p8a2SDtnbopYJslCSV3/+teuVscX89kkBldyc5TGM iuMRghyn5gK1zIuJvzCjYH4+IBYCJk+fHeVOysLDOqZ0zegV1WJQIZ0LosHBmc1UtT VHhgi3oL8MmsrhK8gpKC4bbwCbhAodUQKCHJxLPJ72IBK5zBQpJVeqjTqUZsVkzqSL QzHv/xFyKA6Ifv06Wd2m57AKfpBWnIDvH8jGppiGujtK1+mNFVLK8siBn1dpebjD73 uWrdGQxUc6gGg== In-Reply-To: Feedback-ID: 44397038:user:proton X-Pm-Message-ID: 2a04406ea858ba21e8bcc8aa86928b3eb834c86c X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297082 Archived-At: On Wednesday, December 11th, 2024 at 11:31, O'Brien, Will wrote: > [...] >=20 > Ah, thanks! I've attached a new patch with the simplification. >=20 > best > -- > will Thanks for working on this. +(defcustom go-ts-mode-test-args nil + "List of extra args for the Go test commands." Should we call this `go-ts-mode-test-flags' instead? That seems to be the parlance golang uses, and there is an official `-args' that go test supports that has a specific behaviour: =09-args =09 Pass the remainder of the command line (everything after -args) =09 to the test binary, uninterpreted and unchanged. =09 Because this flag consumes the remainder of the command line, =09 the package list (if present) must appear before this flag. + (compile (format "go test %s -v %s -run '%s'" + (string-join go-ts-mode-test-args) With the above in mind, we may want to move the %s to the absolute end so that -args could be used without catastrophe. This will also need a commit message and a NEWS entry. See the CONTRIBUTE file for details.