From: Matt Armstrong <marmstrong@google.com>
To: 30240@debbugs.gnu.org
Subject: bug#30240: emacs-26; xterm.c: undefined reference to `xg_get_scale' happens with --with-x-toolkit=lucid
Date: Wed, 24 Jan 2018 11:44:24 -0800 [thread overview]
Message-ID: <qf58tcnvy7b.fsf@marmstrong-linux.kir.corp.google.com> (raw)
I built from the emacs-26 branch:
$ git checkout emacs-26
$ git log -l
commit 59db8dca030ba6a34d143c3cc6715f02beba1068 (HEAD -> emacs-26, origin/emacs-26)
Author: Robert Pluim <rpluim@gmail.com>
Date: Wed Jan 24 08:55:34 2018 +0100
Use scaled coordinates when calling into GTK
This is part two of a two part fix for the GTK scaling
problems. See the thread starting at
http://lists.gnu.org/archive/html/emacs-devel/2018-01/msg00372.html
for an explanation of why it has been added to Emacs 26.
* src/gtkutil.c (xg_set_geometry): Scale down the coordinates that we
pass to gtk_window_move and to gtk_window_parse_geometry.
* src/xterm.c (x_set_offset): Likewise.
$ ./autogen.sh
$ ./configure --with-x-toolkit=lucid --prefix=$HOME/opt/emacs-git
$ make clean && make bootstrap
[...]
xterm.c: In function `x_set_offset`:
xterm.c:10313:15: warning: implicit declaration of function `xg_get_scale` [-Wimplicit-function-declaration]
int scale = xg_get_scale (f);
^~~~~~~~~~~~
xterm.c:10313:3: warning: nested extern declaration of `x_get_scale` [-Wnested-externs]
int scale = xg_get_scale (f);
^~~
xterm.c:10313:7: warning: unused variable `scale` [-Wunused-variable]
int scale = xg_get_scale (f);
^~~~~
[...]
xterm.o: In function `x_set_offset':
/usr/local/google/home/marmstrong/git/emacs/src/xterm.c:10313: undefined reference to `xg_get_scale'
collect2: error: ld returned 1 exit status
Makefile:600: recipe for target 'temacs' failed
next reply other threads:[~2018-01-24 19:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 19:44 Matt Armstrong [this message]
2018-01-24 20:06 ` bug#30240: emacs-26; xterm.c: undefined reference to `xg_get_scale' happens with --with-x-toolkit=lucid martin rudalics
2018-01-24 23:40 ` Matt Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=qf58tcnvy7b.fsf@marmstrong-linux.kir.corp.google.com \
--to=marmstrong@google.com \
--cc=30240@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).