From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#70362: [PATCH] Add font-locking for Go built-in functions in go-ts-mode Date: Tue, 16 Apr 2024 00:44:16 +0000 Message-ID: References: <25B8E895-4E4B-4D60-BCDC-97A02AD2A1CE@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21555"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , Yuan Fu , 70362@debbugs.gnu.org, Eli Zaretskii To: Noah Peart Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 16 02:45:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rwWwo-0005Qp-U8 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Apr 2024 02:45:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rwWwO-00028W-3O; Mon, 15 Apr 2024 20:44:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwWwN-00028M-4m for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2024 20:44:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rwWwM-0000uD-Sl for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2024 20:44:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rwWwY-0007Pm-GA for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2024 20:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Apr 2024 00:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70362-submit@debbugs.gnu.org id=B70362.171322828528312 (code B ref 70362); Tue, 16 Apr 2024 00:45:02 +0000 Original-Received: (at 70362) by debbugs.gnu.org; 16 Apr 2024 00:44:45 +0000 Original-Received: from localhost ([127.0.0.1]:40580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwWwF-0007MN-4o for submit@debbugs.gnu.org; Mon, 15 Apr 2024 20:44:44 -0400 Original-Received: from mail-4323.proton.ch ([185.70.43.23]:28805) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwWwA-0007Ko-KR for 70362@debbugs.gnu.org; Mon, 15 Apr 2024 20:44:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1713228260; x=1713487460; bh=FSRhpFib/Z0Banc75KADDzhqONyKwHTBuVbOuOv3ERA=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=YodErldPAUQF0Xsm+eK4nJKuGpk7jlmCWuPqHVWct+arrLpCzrxTsPoTl8xvLSyaF fewMtoMI37ptks+Wnwj6MjZjThRWCDR/P4Azxm5wF7FqsgZdiRMkgjBRqy4y/gVQpJ 3Dr76RbqEpu7CHOxozuJDOC+lkh6qzOrUVoMtvm73+7ACaxaIjiri+wi6Ljk8335up oW+FIyUC2MvkYlPOCdEHexoZ5S0Hrkfm1vfPJ00yLuOM9+DlnOFrS/vaTTa6cqFoHa hS9t9c8zSthhrrAw62k1+WUG+C4PoFEAs/L4jCVO/shR/HNEnS1X++0ztj/fX4yUSJ CY6F8ke6VW3kA== In-Reply-To: <25B8E895-4E4B-4D60-BCDC-97A02AD2A1CE@gmail.com> Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283404 Archived-At: On Sunday, April 14th, 2024 at 19:32, Yuan Fu wrote: >=20 > Dmitry Gutov dmitry@gutov.dev writes: >=20 > > On 13/04/2024 10:40, Noah Peart wrote: > >=20 > > > I put it at level 3 following the conventions in other treesit modes > > > I checked: python-ts-mode, ruby-ts-mode, rust-ts-mode all put > > > builtins at level 3. > > > But, I haven't done a full census of the ts modes so there might be > > > variability. > >=20 > > SGTM. If classic major modes highlight a thing (and they do that for > > built-ins), we usually put it in the default highlighting for ts modes > > as well (meaning level 3 or lower). >=20 >=20 > Right. And the patch looks good to me. >=20 > Yuan >=20 Thanks for working on this Noah, it looks good to me as well. Perhaps builtin could come before constant in treesit-font-lock-feature-lis= t to keep things alphabetical?