From: Lawrence Mitchell <wence@gmx.li>
To: 6170@debbugs.gnu.org
Subject: bug#6170: 24.0.50; Compiling on solaris2.10 with gcc doesn't define alloca
Date: Tue, 11 May 2010 11:57:17 +0100 [thread overview]
Message-ID: <pvhpbpcmk8oi.fsf@ed.ac.uk> (raw)
On this system, <stdlib.h> is provided by Sun and therefore
doesn't define alloca, unlike on a typical GNU/linux system where
<stdlib.h> contains the following:
| #if defined __USE_GNU || defined __USE_BSD || defined __USE_MISC
| # include <alloca.h>
| #endif /* Use GNU, BSD, or misc. */
When compiling emacs with gcc, alloca is therefore undefined.
The culprit is this snippet in configure.in:
| #ifndef __GNUC__
| # ifdef HAVE_ALLOCA_H
| # include <alloca.h>
| # else /* AIX files deal with #pragma. */
| # ifndef alloca /* predefined by HP cc +Olibcalls */
| char *alloca ();
| # endif
| # endif /* HAVE_ALLOCA_H */
| #endif /* __GNUC__ */
On this system, configure correctly defines both HAVE_ALLOCA_H
and HAVE_ALLOCA, but since the inclusion is guarded by __GNUC__
not being defined, we never include <alloca.h>.
I think the correct fix is to unconditionally define alloca if
__GNUC__ is detected, see patch below. Note that this is closer
to how autoconf checks for the presence of the alloca function.
Possible changelog entry:
2010-05-11 Lawrence Mitchell <wence@gmx.li>
* configure.in: Unconditionally define alloca if __GNUC__ is
detected.
diff --git a/configure.in b/configure.in
index 8a7d9be..98b6abb 100644
--- a/configure.in
+++ b/configure.in
@@ -3360,6 +3360,9 @@ extern char *getenv ();
char *alloca ();
# endif
# endif /* HAVE_ALLOCA_H */
+#else
+# undef alloca
+# define alloca __builtin_alloca
#endif /* __GNUC__ */
#ifndef HAVE_SIZE_T
typedef unsigned size_t;
next reply other threads:[~2010-05-11 10:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 10:57 Lawrence Mitchell [this message]
2010-05-12 18:29 ` bug#6170: 24.0.50; Compiling on solaris2.10 with gcc doesn't define alloca Dan Nicolaescu
2010-05-31 16:42 ` Lawrence Mitchell
2010-06-02 9:24 ` Dan Nicolaescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pvhpbpcmk8oi.fsf@ed.ac.uk \
--to=wence@gmx.li \
--cc=6170@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).