From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lawrence Mitchell Newsgroups: gmane.emacs.bugs Subject: bug#7488: 24.0.50; format-decode-region acts on whole buffer, not on region Date: Mon, 29 Nov 2010 11:27:40 +0000 Message-ID: References: <6A85A72454A944B98ADFC09FCA3AC821@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1291031127 2363 80.91.229.12 (29 Nov 2010 11:45:27 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 29 Nov 2010 11:45:27 +0000 (UTC) To: bug-gnu-emacs@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 29 12:45:20 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PN2AY-00075Z-Ta for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Nov 2010 12:45:19 +0100 Original-Received: from localhost ([127.0.0.1]:56385 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PN2AS-0007zI-R0 for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Nov 2010 06:45:12 -0500 Original-Received: from [140.186.70.92] (port=42803 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PN2AF-0007y9-Tn for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2010 06:45:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PN2AE-0007Y2-EO for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2010 06:44:59 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40323) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PN2AE-0007Xy-CY for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2010 06:44:58 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PN1oz-00010A-Nz; Mon, 29 Nov 2010 06:23:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <6A85A72454A944B98ADFC09FCA3AC821@us.oracle.com> Resent-From: Lawrence Mitchell Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Nov 2010 11:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7488 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by submit@debbugs.gnu.org id=B.12910297513813 (code B ref -1); Mon, 29 Nov 2010 11:23:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 Nov 2010 11:22:31 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PN1oV-0000zS-Aq for submit@debbugs.gnu.org; Mon, 29 Nov 2010 06:22:31 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PN1oS-0000zF-Hr for submit@debbugs.gnu.org; Mon, 29 Nov 2010 06:22:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PN1to-00040m-Qy for submit@debbugs.gnu.org; Mon, 29 Nov 2010 06:28:01 -0500 Original-Received: from lists.gnu.org ([199.232.76.165]:42368) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PN1to-00040e-GD for submit@debbugs.gnu.org; Mon, 29 Nov 2010 06:28:00 -0500 Original-Received: from [140.186.70.92] (port=35097 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PN1tl-0005Qg-R4 for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2010 06:28:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PN1tk-0003zg-Ba for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2010 06:27:57 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]:44015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PN1tk-0003zM-0f for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2010 06:27:56 -0500 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1PN1th-0001Dg-3I for bug-gnu-emacs@gnu.org; Mon, 29 Nov 2010 12:27:53 +0100 Original-Received: from garnet.epcc.ed.ac.uk ([129.215.56.222]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 29 Nov 2010 12:27:53 +0100 Original-Received: from wence by garnet.epcc.ed.ac.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 29 Nov 2010 12:27:53 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 54 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: garnet.epcc.ed.ac.uk User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (usg-unix-v) Cancel-Lock: sha1:zXNKwlSHHyCbGYJULHnQIMV28KU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 29 Nov 2010 06:23:01 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:42003 Archived-At: Drew Adams wrote: > emacs -Q > ;; On Windows, load cygwin-mount.el and setup-cygwin.el, from Emacs wiki: > http://www.emacswiki.org/cgi-bin/wiki?action=index;match=%5C.(el%7Ctar)(%5C.gz)% > 3F%24 format-decode-run-method seems to ignore the values of its region arguments (assuming the buffer is narrowed maybe?) Here's a patch: >From d1bc7ad648e75979169765d6384314a21c9dcf17 Mon Sep 17 00:00:00 2001 From: Lawrence Mitchell Date: Mon, 29 Nov 2010 11:24:57 +0000 Subject: [PATCH] Make format-decode-run-method pay attention to region arguments. Instead of assuming a narrowed buffer and apply the decoding method to the whole buffer, use the passed in values of FROM and TO. --- lisp/ChangeLog | 6 ++++++ lisp/format.el | 3 +-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 58fce7a..9a12f5e 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,9 @@ +2010-11-29 Lawrence Mitchell + + * format.el (format-decode-run-method): Use values of FROM and TO + rather than point-min and point-max to operate on the region + correctly. + 2010-11-15 Agustín Martín * textmodes/flyspell.el (flyspell-generic-progmode-verify): diff --git a/lisp/format.el b/lisp/format.el index 0436187..b4277ef 100644 --- a/lisp/format.el +++ b/lisp/format.el @@ -181,8 +181,7 @@ it should be a Lisp function. Decoding is done for the given BUFFER." ;; We should perhaps go via a temporary buffer and copy it ;; back, in case of errors. (if (and (zerop (save-window-excursion - (shell-command-on-region (point-min) (point-max) - method t t + (shell-command-on-region from to method t t error-buff))) ;; gzip gives zero exit status with bad args, for instance. (zerop (with-current-buffer error-buff -- 1.7.2.2.180.g9841a.dirty