From: Glenn Morris <rgm@gnu.org>
To: Bernard Hurley <bernard@marcade.biz>
Cc: 13257@debbugs.gnu.org
Subject: bug#13257: GNU Emacs 24.2.1: dired-do-query-replace-regexp calls query-replace-regexp with 3 arguments instead of 2.
Date: Sat, 22 Dec 2012 22:15:41 -0500 [thread overview]
Message-ID: <pf38yxjw6a.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <86a9t5r3mg.fsf@marcade.biz> (Bernard Hurley's message of "Sun, 23 Dec 2012 00:52:55 +0000")
Bernard Hurley wrote:
> In the file dired-aux.el, the function query-replace-regexp is called
> with the wrong number of arguments. Here is a patch:
You talk about query-replace-regexp, but your patch changes a call to
query-replace-read-args, which takes 2-3 args, so I wonder what the
actual issue is supposed to be?
> *** dired-aux.el.old 2012-12-23 00:42:49.000000000 +0000
> --- dired-aux.el.new 2012-12-23 00:48:39.000000000 +0000
> ***************
> *** 2511,2517 ****
> (interactive
> (let ((common
> (query-replace-read-args
> ! "Query replace regexp in marked files" t t)))
> (list (nth 0 common) (nth 1 common) (nth 2 common))))
> (dolist (file (dired-get-marked-files nil nil 'dired-nondirectory-p))
> (let ((buffer (get-file-buffer file)))
> --- 2511,2517 ----
> (interactive
> (let ((common
> (query-replace-read-args
> ! "Query replace regexp in marked files" t)))
> (list (nth 0 common) (nth 1 common) (nth 2 common))))
> (dolist (file (dired-get-marked-files nil nil 'dired-nondirectory-p))
> (let ((buffer (get-file-buffer file)))
prev parent reply other threads:[~2012-12-23 3:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-23 0:52 bug#13257: GNU Emacs 24.2.1: dired-do-query-replace-regexp calls query-replace-regexp with 3 arguments instead of 2 Bernard Hurley
2012-12-23 3:15 ` Glenn Morris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pf38yxjw6a.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=13257@debbugs.gnu.org \
--cc=bernard@marcade.biz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).