From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#33195: 27.0.50; user-login-name has no group-login-name Date: Sat, 10 Nov 2018 13:36:47 -0500 Message-ID: References: <87d0rsegbi.fsf@gmail.com> <837ehzlo3a.fsf@gnu.org> <871s87e1gi.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1541874912 21122 195.159.176.226 (10 Nov 2018 18:35:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 10 Nov 2018 18:35:12 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: 33195@debbugs.gnu.org To: Jules Tamagnan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Nov 10 19:35:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLY63-0005I5-NG for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Nov 2018 19:35:03 +0100 Original-Received: from localhost ([::1]:39564 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gLY8A-00059v-54 for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Nov 2018 13:37:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gLY7z-00059c-3B for bug-gnu-emacs@gnu.org; Sat, 10 Nov 2018 13:37:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gLY7y-00007T-42 for bug-gnu-emacs@gnu.org; Sat, 10 Nov 2018 13:37:03 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40690) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gLY7x-00007F-Uj for bug-gnu-emacs@gnu.org; Sat, 10 Nov 2018 13:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gLY7x-0008SG-Qg for bug-gnu-emacs@gnu.org; Sat, 10 Nov 2018 13:37:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Nov 2018 18:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33195 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33195-submit@debbugs.gnu.org id=B33195.154187501832491 (code B ref 33195); Sat, 10 Nov 2018 18:37:01 +0000 Original-Received: (at 33195) by debbugs.gnu.org; 10 Nov 2018 18:36:58 +0000 Original-Received: from localhost ([127.0.0.1]:44948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLY7u-0008Ry-1k for submit@debbugs.gnu.org; Sat, 10 Nov 2018 13:36:58 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:45064) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gLY7t-0008Rn-1D for 33195@debbugs.gnu.org; Sat, 10 Nov 2018 13:36:57 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gLY7n-0008Jc-2y for 33195@debbugs.gnu.org; Sat, 10 Nov 2018 13:36:51 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gLY7l-0008HD-9l; Sat, 10 Nov 2018 13:36:49 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1gLY7j-0007OE-Te; Sat, 10 Nov 2018 13:36:47 -0500 X-Spook: propaganda Agfa Screening Matamoros Body scanner Denial X-Ran: I;*wAL][oj;nBnQ@$Hm=OUeqx;V1"f4Q6:~0BCd><8ijA+ePHW98p)<^uvDbi9,cHWfI-U X-Hue: blue X-Attribution: GM In-Reply-To: <871s87e1gi.fsf@gmail.com> (Jules Tamagnan's message of "Tue, 30 Oct 2018 11:25:33 -0700") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152258 Archived-At: Jules Tamagnan wrote: > I've tried my hand at writing a test for this but am dubious it will > pass on all machines, I believe it should work on gnu/linux [...] > +(ert-deftest group-name () > + (let ((list `((0 . "root") > + (1000 . ,(user-login-name 1000)) > + (1212345 . nil)))) > + (dolist (test list) > + (should (equal (group-name (car test)) (cdr test)))))) This assumes that user 1000's primary group is the same as their login name. This is not at all guaranteed, so I will remove it. Eg it fails for me on rhel 7.5, and also on hydra.nixos.org, ref https://hydra.nixos.org/eval/1488740 I guess that UID 0 is always the root group, but I wouldn't swear to it. The 1212345 thing relies on UID 1212345 not existing. It seems to me that this is fragile too. So all in all, I'm not sure this test is very useful.