shell-script mode indentation skewed encountering "&"

shell-script mode indentation skewed encountering "&"

[Dan Jacobson]

#!/bin/sh -xeu
#Here we critique shell-script mode indentation
(
    : note how the parentheses are nicely indented
)
(
    : note how the closing parentheses is skewed when we add &
    )&

{
    : same problem with {}
    }&

Re: shell-script mode indentation skewed encountering "&"

[Glenn Morris]

Dan Jacobson wrote:

> (
>     : note how the parentheses are nicely indented
> )
> (
>     : note how the closing parentheses is skewed when we add &
>     )&


Thanks - I installed this fix in CVS:


*** sh-script.el         14 Jun 2005 23:56:03 -0000 1.157
--- sh-script.el         30 Jun 2005 16:45:04 -0000 1.158
***************
*** 2370,2376 ****
    (goto-char where))
      (prog1
      (buffer-substring (point)
!                             (progn (skip-chars-forward "^ \t\n;")(point)))
        (unless and-move
        (goto-char start)))))
  
--- 2370,2376 ----
    (goto-char where))
      (prog1
      (buffer-substring (point)
!                             (progn (skip-chars-forward "^ \t\n;&")(point)))
        (unless and-move
        (goto-char start)))))

Re: shell-script mode indentation skewed encountering "&"

[Dan Jacobson]

rms> Shell mode indentation needs a full rewrite.  Are you interested
rms> in doing it?

With a dwindling number of cells up there, I'm not your man.

All I can do is make remarks like "I am disturbed that "do" is
indented vs. "done", but I respect that that must be a preference,
customizable by sh-indent-for-do".