From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#4533: i can reproduce this Date: Mon, 02 Nov 2009 03:11:16 -0500 Message-ID: References: Reply-To: Glenn Morris , 4533@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1257150531 29422 80.91.229.12 (2 Nov 2009 08:28:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 Nov 2009 08:28:51 +0000 (UTC) Cc: 4533@emacsbugs.donarmstrong.com To: Jack Tanner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 02 09:28:44 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1N4sHK-0008JJ-Cg for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Nov 2009 09:28:42 +0100 Original-Received: from localhost ([127.0.0.1]:58071 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N4sHJ-0004uw-UN for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Nov 2009 03:28:41 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N4sGH-0004LA-IP for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2009 03:27:37 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N4sFz-0004I8-Up for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2009 03:27:26 -0500 Original-Received: from [199.232.76.173] (port=36555 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N4sFz-0004Hh-4F for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2009 03:27:19 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:54880) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N4sFy-0004HB-8u for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2009 03:27:18 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nA28RFaf021602; Mon, 2 Nov 2009 00:27:16 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nA28K3FG020615; Mon, 2 Nov 2009 00:20:03 -0800 Resent-Date: Mon, 2 Nov 2009 00:20:03 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Glenn Morris Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Mon, 02 Nov 2009 08:20:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4533 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: unreproducible moreinfo Original-Received: via spool by 4533-submit@emacsbugs.donarmstrong.com id=B4533.125714948019608 (code B ref 4533); Mon, 02 Nov 2009 08:20:03 +0000 Original-Received: (at 4533) by emacsbugs.donarmstrong.com; 2 Nov 2009 08:11:20 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nA28BJdc019595; Mon, 2 Nov 2009 00:11:20 -0800 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1N4s0T-000432-3t; Mon, 02 Nov 2009 03:11:17 -0500 X-Spook: CDC FIPS140 AK-47 BCCI Jyllandsposten cypherpunk X-Ran: 3$_IpzVjR>Ob>5IP;JwlA, (Jack Tanner's message of "Sun, 1 Nov 2009 12:07:36 -0500") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Mon, 02 Nov 2009 03:27:24 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:32366 Archived-At: tags 4533 = stop Jack Tanner wrote: > - Start emacs -Q . > - C-x C-f ~/foo.txt, creating a new file. > - Enter text: > Line 1 > Line 2 > > - C-x C-s. > - dos2unix ~/foo.txt > - M-x revert-buffer Thanks for the recipe. Saving the file was the missing step. The issue seems to be that saving a file causes basic-save-buffer-1 to set buffer-file-coding-system-explicit. Eg for me on GNU/Linux, it is set to (iso-latin-1-unix). revert-buffer uses this to set coding-system-for-read before it inserts the file contents. So the change in line ending is ignored. If I manually set buffer-file-coding-system-explicit to nil before reverting the buffer, the change in line ending is noticed. I don't know what the right fix is though.