From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#26837: Wrong file in "autoloading failed to define" error Date: Tue, 09 May 2017 14:39:24 -0400 Message-ID: References: <63h90vp3dn.fsf@fencepost.gnu.org> <87bmr24hj0.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1494355212 775 195.159.176.226 (9 May 2017 18:40:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 9 May 2017 18:40:12 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: 26837@debbugs.gnu.org To: Alex Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 09 20:40:04 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8A3I-0008SS-9Z for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 May 2017 20:40:04 +0200 Original-Received: from localhost ([::1]:38874 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8A3N-0000jL-Uq for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 May 2017 14:40:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36023) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8A3I-0000jE-F4 for bug-gnu-emacs@gnu.org; Tue, 09 May 2017 14:40:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8A3H-0002zc-Ez for bug-gnu-emacs@gnu.org; Tue, 09 May 2017 14:40:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60010) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d8A3H-0002zV-Ac for bug-gnu-emacs@gnu.org; Tue, 09 May 2017 14:40:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d8A3G-0002WM-As for bug-gnu-emacs@gnu.org; Tue, 09 May 2017 14:40:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 May 2017 18:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26837 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26837-submit@debbugs.gnu.org id=B26837.14943551749651 (code B ref 26837); Tue, 09 May 2017 18:40:02 +0000 Original-Received: (at 26837) by debbugs.gnu.org; 9 May 2017 18:39:34 +0000 Original-Received: from localhost ([127.0.0.1]:34454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8A2o-0002Vb-8k for submit@debbugs.gnu.org; Tue, 09 May 2017 14:39:34 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8A2n-0002VO-0I for 26837@debbugs.gnu.org; Tue, 09 May 2017 14:39:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8A2g-0002oe-Q8 for 26837@debbugs.gnu.org; Tue, 09 May 2017 14:39:27 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44642) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8A2f-0002nv-3S; Tue, 09 May 2017 14:39:25 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1d8A2e-0003OJ-JK; Tue, 09 May 2017 14:39:24 -0400 X-Spook: Fundamentalism El Paso NASA condor Hazmat Suspicious X-Ran: ]QIy3XQVv.I5Y"do8T\~1&Inj2i7j}KM*,-g%CuYv-+F=6w%TgKp~XFDzDae>T.7%=?MXP X-Hue: magenta X-Attribution: GM In-Reply-To: (Glenn Morris's message of "Tue, 09 May 2017 12:33:42 -0400") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132402 Archived-At: Glenn Morris wrote: >> I can't claim to know what is going on within that function, but your >> patch seems to only work for some files (e.g. your bar.el). If bar >> starts with a comment, then bar isn't moved to the top after evaluating >> (load "bar"). > > The intent of the code seems to be to only adjust an existing > load-history element for some file if the entire file is being loaded. > I guess in the leading comment case, something else has already moved > point looking for a significant leading comment (eg lexbind, script, > prop-line). Hmmm. I think it was the lexical-binding thing. Following seems to work: --- i/src/lread.c +++ w/src/lread.c @@ -1885,7 +1885,7 @@ PREDICATE can also be an integer to pass to the faccessat(2) function, /* On the first cycle, we can easily test here whether we are reading the whole buffer. */ if (b && first_sexp) - whole_buffer = (PT == BEG && ZV == Z); + whole_buffer = (BUF_PT (b) == BUF_BEG (b) && BUF_ZV (b) == BUF_Z (b)); instream = stream; read_next: @@ -2008,6 +2008,7 @@ BUFFER is the buffer to evaluate (nil means use current buffer), record_unwind_protect (save_excursion_restore, save_excursion_save ()); BUF_TEMP_SET_PT (XBUFFER (buf), BUF_BEGV (XBUFFER (buf))); specbind (Qlexical_binding, lisp_file_lexically_bound_p (buf) ? Qt : Qnil); + BUF_TEMP_SET_PT (XBUFFER (buf), BUF_BEGV (XBUFFER (buf))); readevalloop (buf, 0, filename, !NILP (printflag), unibyte, Qnil, Qnil, Qnil); unbind_to (count, Qnil);