From: Glenn Morris <rgm@gnu.org>
To: Xue Fuqiao <xfq.free@gmail.com>
Cc: 13777@debbugs.gnu.org
Subject: bug#13777: [patch] Add toolbars for Edebug and debugger-mode
Date: Wed, 08 May 2013 03:50:35 -0400 [thread overview]
Message-ID: <nlk3n9di5w.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <20130221184913.101bd49379994f15f3156829@gmail.com> (Xue Fuqiao's message of "Thu, 21 Feb 2013 18:49:13 +0800")
Thanks for the patches.
Xue Fuqiao wrote:
> *** trunk/lisp/emacs-lisp/edebug.el.orig 2013-02-03
> 09:46:50.383143000 +0800
> --- trunk/lisp/emacs-lisp/edebug.el 2013-02-21
> 18:10:30.220096536 +0800 *************** be installed in
> `emacs-lisp-mode-map'.") *** 3727,3732 ****
> --- 3727,3745 ----
(These patches seem mangled somehow?)
> + (defvar edebug-tool-bar-map
> + (let ((map (make-sparse-keymap)))
> + (dolist (x '((edebug-set-breakpoint . "gud/break")
> + (edebug-unset-breakpoint . "gud/remove")
> + (edebug-go-mode . "gud/go")
> + (edebug-stop . "gud/stop")
> + (edebug-continue-mode . "gud/cont")
> + (edebug-next-mode . "gud/next")
> + (edebug-step-mode . "gud/step"))
> + map)
> + (tool-bar-local-item-from-menu
> + (car x) (cdr x) map edebug-mode-map))))
Looks alright but:
i) I think this needs to be moved after the easy-menu-define call.
ii) You need to find a way to restore the normal tool-bar after edebug
exits (for whatever reason).
> + (defvar debugger-tool-bar-map
> + (let ((map (make-sparse-keymap)))
> + (dolist (x '((debugger-continue . "gud/cont")
> + (debugger-step-through . "gud/step"))
> + map)
> + (tool-bar-local-item-from-menu
> + (car x) (cdr x) map debugger-mode-map))))
Looks ok, but it's a very sparse tool-bar. Is there nothing more that
can go in it? It looks a bit silly with just 2 items...
Maybe keep some of the standard ones?
next prev parent reply other threads:[~2013-05-08 7:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-21 10:49 bug#13777: [patch] Add toolbars for Edebug and debugger-mode Xue Fuqiao
2013-05-08 7:50 ` Glenn Morris [this message]
2013-05-08 9:39 ` Xue Fuqiao
2013-05-08 15:07 ` Stefan Monnier
2016-02-24 5:45 ` Lars Ingebrigtsen
2016-02-25 0:26 ` Xue Fuqiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nlk3n9di5w.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=13777@debbugs.gnu.org \
--cc=xfq.free@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).