unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 14442@debbugs.gnu.org, Angelo Graziosi <angelo.graziosi@alice.it>
Subject: bug#14442: On syntax decoration of identifiers containing underscore and statements word [f90]
Date: Thu, 23 May 2013 21:03:42 -0400	[thread overview]
Message-ID: <nlk3mp42a9.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <jwvtxlufyoo.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 22 May 2013 18:20:19 -0400")

Stefan Monnier wrote:

> At least this problem was not introduced by my recent change.  It was
> already present in Emacs-24.2 (among other versions).

No, it is extremely long-standing behaviour that I am in no hurry to
change. ( Like the syntax thing. :) )

> The patch below seems to fix it, but I don't know enough the rules of
> Fortran syntax to be sure it's the right thing to do.

Indeed there are some cases where spaces are optional (eg "else if" ==
"elseif"), and some where they are not. This is probably why there are
lots of "[ \t]*" in f90.el.

> -    '("\\_<\\(implicit\\)[ \t]*\\(real\\|integer\\|c\\(haracter\\|omplex\\)\
> +    '("\\_<\\(implicit\\)[ \t]+\\(real\\|integer\\|c\\(haracter\\|omplex\\)\

Probably correct, since I think the space is required in this case.

> -    '("\\_<\\(namelist\\|common\\)[ \t]*\/\\(\\(?:\\sw\\|\\s_\\)+\\)?\/"
> +    '("\\_<\\(namelist\\|common\\)[ \t]*/\\(\\(?:\\sw\\|\\s_\\)+\\)?\/"

Unrelated cosmetic change? You missed the final "\/" BTW.

> -    '("\\_<\\(exit\\|cycle\\)[ \t]*\\(\\(?:\\sw\\|\\s_\\)+\\)?\\_>"
> +    '("\\_<\\(exit\\|cycle\\)[ \t]+\\(\\(?:\\sw\\|\\s_\\)+\\)?\\_>"

Breaks highlighting of plain "exit" (the following label is optional).





  parent reply	other threads:[~2013-05-24  1:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <51955A32.2080302@alice.it>
     [not found] ` <jwvd2sqbfx9.fsf-monnier+emacs@gnu.org>
     [not found]   ` <51960C1D.6070906@alice.it>
2013-05-22 22:20     ` bug#14442: On syntax decoration of identifiers containing underscore and statements word [f90] Stefan Monnier
2013-05-22 23:48       ` Angelo Graziosi
2013-05-25 11:15         ` Angelo Graziosi
2013-05-24  1:03       ` Glenn Morris [this message]
2013-05-24  3:51         ` Stefan Monnier
2021-12-04  4:07         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=nlk3mp42a9.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=14442@debbugs.gnu.org \
    --cc=angelo.graziosi@alice.it \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).