From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#11780: 24.1.50; vc-annotate fails for files in RCS. ("cl.el" `flet' problem?) Date: Tue, 26 Jun 2012 18:41:51 -0400 Message-ID: References: <83k3yv9qik.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1340750528 17090 80.91.229.3 (26 Jun 2012 22:42:08 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 26 Jun 2012 22:42:08 +0000 (UTC) Cc: Richard Copley , 11780@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 27 00:42:07 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SjeSS-0003Vu-0H for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Jun 2012 00:42:04 +0200 Original-Received: from localhost ([::1]:36132 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjeSR-0003lu-Un for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Jun 2012 18:42:03 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:59522) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjeSP-0003lj-NQ for bug-gnu-emacs@gnu.org; Tue, 26 Jun 2012 18:42:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SjeSO-0003LY-4G for bug-gnu-emacs@gnu.org; Tue, 26 Jun 2012 18:42:01 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49632) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjeSO-0003LT-0q for bug-gnu-emacs@gnu.org; Tue, 26 Jun 2012 18:42:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SjeWH-0001Hb-US for bug-gnu-emacs@gnu.org; Tue, 26 Jun 2012 18:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Jun 2012 22:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11780 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11780-submit@debbugs.gnu.org id=B11780.13407507604924 (code B ref 11780); Tue, 26 Jun 2012 22:46:01 +0000 Original-Received: (at 11780) by debbugs.gnu.org; 26 Jun 2012 22:46:00 +0000 Original-Received: from localhost ([127.0.0.1]:59178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SjeWF-0001HM-UL for submit@debbugs.gnu.org; Tue, 26 Jun 2012 18:46:00 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:48791) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SjeWC-0001HE-Cw for 11780@debbugs.gnu.org; Tue, 26 Jun 2012 18:45:57 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1SjeSF-0004on-76; Tue, 26 Jun 2012 18:41:51 -0400 X-Spook: Project Monarch MP5K-SD Vickie Weaver Cocaine high X-Ran: td@Pf"=5*7V`]+cOnFN^+n1(rG$l'ZbC?a`#!3tKY4z>xk#.x//E#@r`_*u]@KZdH.%f,~ X-Hue: magenta X-Attribution: GM In-Reply-To: (Richard Copley's message of "Mon, 25 Jun 2012 20:03:02 +0100") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:61315 Archived-At: Here's what the expansion of (flet ((sw () (skip-chars-forward " \t\n"))) (sw)) looks like in 24.1: (let* ((--cl-letf-bound-- (fboundp 'sw)) (--cl-letf-save-- (and --cl-letf-bound-- (symbol-function 'sw)))) (unwind-protect (progn (fset 'sw (function* (lambda nil (block sw (skip-chars-forward " \n"))))) (sw)) (if --cl-letf-bound-- (fset 'sw --cl-letf-save--) (fmakunbound 'sw)))) whereas in the current trunk it looks like this: (let* ((x (cl-function (lambda nil (cl-block sw (skip-chars-forward " \n"))))) (x (symbol-function 'sw))) (unwind-protect (progn (fset 'sw x) (sw)) (fset 'sw x))) So there's a couple of things wrong with the new version: `x' used twice as a local variable. (symbol-function 'sw) not guarded by an (fboundp 'sw) check. The latter is the immediate source of the error AFAICS.