unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Randy Taylor <dev@rjt.dev>
To: Trevor Arjeski <tmarjeski@gmail.com>
Cc: Yuan Fu <casouri@gmail.com>, Eli Zaretskii <eliz@gnu.org>,
	74277@debbugs.gnu.org, acidbong@tilde.club
Subject: bug#74277: 29.4; rust-ts-mode doesn't highlight some function calls
Date: Fri, 22 Nov 2024 03:30:05 +0000	[thread overview]
Message-ID: <nAEvrQjR9JB-PY31QbiehvgDP-tM3-Zl63PRp5ceHxMFA8gQIbq2aEAOoG5tCsWd2Pux44DLU8ZcpULgumJes1rRtbUkd996xfQ7uo3ddo0=@rjt.dev> (raw)
In-Reply-To: <87ed3522aj.fsf@gmail.com>

On Wednesday, November 20th, 2024 at 13:22, Trevor Arjeski <tmarjeski@gmail.com> wrote:
> 
> Trevor Arjeski tmarjeski@gmail.com writes:
> 
> 
> I decided to hack around with this a little bit and found that adding
> the following lines partially works:
> 
> 
> I'm sure there is an issue with solving it this way, I just need someone
> else more experienced to confirm. It is finicky where it turns the
> highlighting on and off when you make some code changes, for example
> adding and removing the semi-colon after the macro invocation.

Yuan would be the best to answer that.

Personally, I envisioned a custom highlight helper function like
rust-ts-mode--fontify-pattern or rust-ts-mode--fontify-scope which
seems like the simplest solution that should cover this use case, but
I'm not actually aware of all the sorts of craziness one could get up
to in a macro invocation so that might not be enough and maybe injections
are the way to go.

> 
> Here is some example code to test it against:
> 
> fn foo() -> i32 {
> 
> 4
> }
> 
> fn main() {
> println!("{:?}", foo());
> }
> 
> 
> Thanks





  reply	other threads:[~2024-11-22  3:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-08 20:24 bug#74277: 29.4; rust-ts-mode doesn't highlight some function calls acidbong--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-09  8:52 ` Eli Zaretskii
2024-11-10 21:10   ` Randy Taylor
2024-11-19 20:48     ` Trevor Arjeski
2024-11-20 12:34       ` Acid Bong via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-20 18:22       ` Trevor Arjeski
2024-11-22  3:30         ` Randy Taylor [this message]
2024-11-24  5:18           ` Yuan Fu
2024-11-24  7:17             ` Trevor Arjeski
2024-11-25  7:34               ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='nAEvrQjR9JB-PY31QbiehvgDP-tM3-Zl63PRp5ceHxMFA8gQIbq2aEAOoG5tCsWd2Pux44DLU8ZcpULgumJes1rRtbUkd996xfQ7uo3ddo0=@rjt.dev' \
    --to=dev@rjt.dev \
    --cc=74277@debbugs.gnu.org \
    --cc=acidbong@tilde.club \
    --cc=casouri@gmail.com \
    --cc=eliz@gnu.org \
    --cc=tmarjeski@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).